huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#141 Require the MSAspNetCoreToken or send a 400.

This commit is contained in:
Chris R 2016-04-22 10:08:30 -07:00
parent 4d24efc439
commit fcdf8ddc2f
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Microsoft.AspNetCore.Server.IISIntegration/IISMiddleware.cs
View File

@ -56,8 +56,8 @@ namespace Microsoft.AspNetCore.Server.IISIntegration
{ {
if (!string.Equals(_pairingToken, httpContext.Request.Headers[MSAspNetCoreToken], StringComparison.Ordinal)) if (!string.Equals(_pairingToken, httpContext.Request.Headers[MSAspNetCoreToken], StringComparison.Ordinal))
{ {
_logger.LogTrace($"'{MSAspNetCoreToken}' does not match the expected pairing token '{_pairingToken}', skipping {nameof(IISMiddleware)}."); _logger.LogError($"'{MSAspNetCoreToken}' does not match the expected pairing token '{_pairingToken}', request rejected.");
await _next(httpContext); httpContext.Response.StatusCode = 400;
return; return;
} }

11
test/Microsoft.AspNetCore.Server.IISIntegration.Tests/IISMiddlewareTests.cs
View File

@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System; using System;
using System.Net;
using System.Net.Http; using System.Net.Http;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNetCore.Builder; using Microsoft.AspNetCore.Builder;
@ -38,12 +39,13 @@ namespace Microsoft.AspNetCore.Server.IISIntegration
var req = new HttpRequestMessage(HttpMethod.Get, ""); var req = new HttpRequestMessage(HttpMethod.Get, "");
req.Headers.TryAddWithoutValidation("MS-ASPNETCORE-TOKEN", "TestToken"); req.Headers.TryAddWithoutValidation("MS-ASPNETCORE-TOKEN", "TestToken");
await server.CreateClient().SendAsync(req); var response = await server.CreateClient().SendAsync(req);
Assert.True(assertsExecuted); Assert.True(assertsExecuted);
response.EnsureSuccessStatusCode();
} }
[Fact] [Fact]
public async Task MiddlewareSkippedIfTokenHeaderIsMissing() public async Task MiddlewareRejectsRequestIfTokenHeaderIsMissing()
{ {
var assertsExecuted = false; var assertsExecuted = false;
@ -65,8 +67,9 @@ namespace Microsoft.AspNetCore.Server.IISIntegration
var server = new TestServer(builder); var server = new TestServer(builder);
var req = new HttpRequestMessage(HttpMethod.Get, ""); var req = new HttpRequestMessage(HttpMethod.Get, "");
await server.CreateClient().SendAsync(req); var response = await server.CreateClient().SendAsync(req);
Assert.True(assertsExecuted); Assert.False(assertsExecuted);
Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
} }
[Fact] [Fact]