From f95ffb57aebc147c0222bdf48d0b8b763a82e058 Mon Sep 17 00:00:00 2001
From: Ryan Nowak <nowakra@gmail.com>
Date: Mon, 28 Sep 2015 17:07:01 -0700
Subject: [PATCH] Make dictionary allocations lazy on RouteData

This change makes the allocation of DataTokens and Values on RouteData
lazy, and elides copies when copying an 'empty' RouteData.

In our current architecture this change will eliminiate 2 * (N + 1)
dictionary allocations/copies per request, where N is the number of routes
processed. In a large system with lots of attribute routes, this number
could be very significant.

For a small MVC site (ModelBinding, Validation, Views) with one route, it
still shows a modest reduction of dictionary allocations without adding
much complexity.
---
 NuGet.config                                  |  2 +-
 src/Microsoft.AspNet.Routing/RouteData.cs     | 47 ++++++++++++++++---
 .../Template/TemplateRoute.cs                 |  9 +++-
 3 files changed, 49 insertions(+), 9 deletions(-)

diff --git a/NuGet.config b/NuGet.config
index 1707938c61..03704957e8 100644
--- a/NuGet.config
+++ b/NuGet.config
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <packageSources>
     <add key="AspNetVNext" value="https://www.myget.org/F/aspnetcidev/api/v3/index.json" />
diff --git a/src/Microsoft.AspNet.Routing/RouteData.cs b/src/Microsoft.AspNet.Routing/RouteData.cs
index 4d734e3fb4..dbc4da9d6b 100644
--- a/src/Microsoft.AspNet.Routing/RouteData.cs
+++ b/src/Microsoft.AspNet.Routing/RouteData.cs
@@ -11,14 +11,16 @@ namespace Microsoft.AspNet.Routing
     /// </summary>
     public class RouteData
     {
+        private Dictionary<string, object> _dataTokens;
+        private RouteValueDictionary _values;
+
         /// <summary>
         /// Creates a new <see cref="RouteData"/> instance.
         /// </summary>
         public RouteData()
         {
-            DataTokens = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase);
+            // Perf: Avoid allocating DataTokens and RouteValues unless needed.
             Routers = new List<IRouter>();
-            Values = new RouteValueDictionary();
         }
 
         /// <summary>
@@ -32,24 +34,55 @@ namespace Microsoft.AspNet.Routing
                 throw new ArgumentNullException(nameof(other));
             }
 
-            DataTokens = new Dictionary<string, object>(other.DataTokens, StringComparer.OrdinalIgnoreCase);
             Routers = new List<IRouter>(other.Routers);
-            Values = new RouteValueDictionary(other.Values);
+            
+            // Perf: Avoid allocating DataTokens and RouteValues unless we need to make a copy.
+            if (other._dataTokens != null)
+            {
+                _dataTokens = new Dictionary<string, object>(other._dataTokens, StringComparer.OrdinalIgnoreCase);
+            }
+
+            if (other._values != null)
+            {
+                _values = new RouteValueDictionary(other._values);
+            }
         }
 
         /// <summary>
         /// Gets the data tokens produced by routes on the current routing path.
         /// </summary>
-        public IDictionary<string, object> DataTokens { get; private set; }
+        public IDictionary<string, object> DataTokens
+        {
+            get
+            {
+                if (_dataTokens == null)
+                {
+                    _dataTokens = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase);
+                }
+
+                return _dataTokens;
+            }
+        }
 
         /// <summary>
         /// Gets the list of <see cref="IRouter"/> instances on the current routing path.
         /// </summary>
-        public List<IRouter> Routers { get; private set; }
+        public List<IRouter> Routers { get; }
 
         /// <summary>
         /// Gets the set of values produced by routes on the current routing path.
         /// </summary>
-        public IDictionary<string, object> Values { get; private set; }
+        public IDictionary<string, object> Values
+        {
+            get
+            {
+                if (_values == null)
+                {
+                    _values = new RouteValueDictionary();
+                }
+
+                return _values;
+            }
+        }
     }
 }
\ No newline at end of file
diff --git a/src/Microsoft.AspNet.Routing/Template/TemplateRoute.cs b/src/Microsoft.AspNet.Routing/Template/TemplateRoute.cs
index 19f87ebe6a..0f8988ec1a 100644
--- a/src/Microsoft.AspNet.Routing/Template/TemplateRoute.cs
+++ b/src/Microsoft.AspNet.Routing/Template/TemplateRoute.cs
@@ -133,7 +133,14 @@ namespace Microsoft.AspNet.Routing.Template
             var oldRouteData = context.RouteData;
 
             var newRouteData = new RouteData(oldRouteData);
-            MergeValues(newRouteData.DataTokens, _dataTokens);
+
+            // Perf: Avoid accessing data tokens if you don't need to write to it, these dictionaries are all
+            // created lazily.
+            if (_dataTokens.Count > 0)
+            {
+                MergeValues(newRouteData.DataTokens, _dataTokens);
+            }
+
             newRouteData.Routers.Add(_target);
             MergeValues(newRouteData.Values, values);