huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Https][Tooling] Add digital signature to the KeyUsage of the HTTPS dev-cert (#9293) 

* [Https][Tooling] Add digital signature to the KeyUsage of the HTTPS dev-cert
This commit is contained in:
Javier Calvarro Nelson 2019-04-12 09:27:54 +02:00 committed by GitHub
parent 8897b56597
commit f934bfaa7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Shared/CertificateGeneration/CertificateManager.cs
View File

@ -156,7 +156,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation
var sanBuilder = new SubjectAlternativeNameBuilder(); var sanBuilder = new SubjectAlternativeNameBuilder();
sanBuilder.AddDnsName(LocalhostHttpsDnsName); sanBuilder.AddDnsName(LocalhostHttpsDnsName);
var keyUsage = new X509KeyUsageExtension(X509KeyUsageFlags.KeyEncipherment, critical: true); var keyUsage = new X509KeyUsageExtension(X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature, critical: true);
var enhancedKeyUsage = new X509EnhancedKeyUsageExtension( var enhancedKeyUsage = new X509EnhancedKeyUsageExtension(
new OidCollection() { new OidCollection() {
new Oid( new Oid(

4
src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs
View File

@ -75,7 +75,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
httpsCertificate.Extensions.OfType<X509Extension>(), httpsCertificate.Extensions.OfType<X509Extension>(),
e => e is X509KeyUsageExtension keyUsage && e => e is X509KeyUsageExtension keyUsage &&
keyUsage.Critical == true && keyUsage.Critical == true &&
keyUsage.KeyUsages == X509KeyUsageFlags.KeyEncipherment); keyUsage.KeyUsages == (X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature));
Assert.Contains( Assert.Contains(
httpsCertificate.Extensions.OfType<X509Extension>(), httpsCertificate.Extensions.OfType<X509Extension>(),
@ -162,7 +162,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
httpsCertificate.Extensions.OfType<X509Extension>(), httpsCertificate.Extensions.OfType<X509Extension>(),
e => e is X509KeyUsageExtension keyUsage && e => e is X509KeyUsageExtension keyUsage &&
keyUsage.Critical == true && keyUsage.Critical == true &&
keyUsage.KeyUsages == X509KeyUsageFlags.KeyEncipherment); keyUsage.KeyUsages == (X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature));
Assert.Contains( Assert.Contains(
httpsCertificate.Extensions.OfType<X509Extension>(), httpsCertificate.Extensions.OfType<X509Extension>(),