From f8ed1185e4bd9b3c2a3131be112adf8de3bf33c6 Mon Sep 17 00:00:00 2001 From: Brennan Conroy Date: Mon, 11 Nov 2019 10:07:02 -0800 Subject: [PATCH] Re-enable tests --- src/Tools/dotnet-watch/test/DotNetWatcherTests.cs | 3 ++- src/Tools/dotnet-watch/test/GlobbingAppTests.cs | 3 ++- src/Tools/dotnet-watch/test/NoDepsAppTests.cs | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Tools/dotnet-watch/test/DotNetWatcherTests.cs b/src/Tools/dotnet-watch/test/DotNetWatcherTests.cs index 221bd5e899..d6e57ee5cf 100644 --- a/src/Tools/dotnet-watch/test/DotNetWatcherTests.cs +++ b/src/Tools/dotnet-watch/test/DotNetWatcherTests.cs @@ -22,7 +22,8 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests _app = new KitchenSinkApp(logger); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/16912")] + [ConditionalFact] + [SkipOnHelix("https://github.com/aspnet/AspNetCore/issues/8267")] public async Task RunsWithDotnetWatchEnvVariable() { Assert.True(string.IsNullOrEmpty(Environment.GetEnvironmentVariable("DOTNET_WATCH")), "DOTNET_WATCH cannot be set already when this test is running"); diff --git a/src/Tools/dotnet-watch/test/GlobbingAppTests.cs b/src/Tools/dotnet-watch/test/GlobbingAppTests.cs index aa4036ebf2..8667c06e7d 100644 --- a/src/Tools/dotnet-watch/test/GlobbingAppTests.cs +++ b/src/Tools/dotnet-watch/test/GlobbingAppTests.cs @@ -85,7 +85,8 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests await _app.HasRestarted(); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/16912")] + [ConditionalFact] + [SkipOnHelix("https://github.com/aspnet/AspNetCore/issues/8267")] public async Task ChangeExcludedFile() { await _app.StartWatcherAsync(); diff --git a/src/Tools/dotnet-watch/test/NoDepsAppTests.cs b/src/Tools/dotnet-watch/test/NoDepsAppTests.cs index 9ad560d348..4f2b420492 100644 --- a/src/Tools/dotnet-watch/test/NoDepsAppTests.cs +++ b/src/Tools/dotnet-watch/test/NoDepsAppTests.cs @@ -42,7 +42,8 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests Assert.NotEqual(processIdentifier, processIdentifier2); } - [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/16912")] + [ConditionalFact] + [SkipOnHelix("https://github.com/aspnet/AspNetCore/issues/8267")] public async Task RestartProcessThatTerminatesAfterFileChange() { await _app.StartWatcherAsync();