Merge branch 'rel/2.0.0-preview1' into dev

This commit is contained in:
Pavel Krymets 2017-05-05 12:01:50 -07:00
commit f7c9b27985
18 changed files with 14 additions and 62 deletions

View File

@ -3,7 +3,7 @@
<Import Project="..\..\build\dependencies.props" /> <Import Project="..\..\build\dependencies.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>net46;netcoreapp2.0</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -3,7 +3,7 @@
<Import Project="..\..\build\dependencies.props" /> <Import Project="..\..\build\dependencies.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>net46;netcoreapp2.0</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -3,7 +3,7 @@
<Import Project="..\..\build\dependencies.props" /> <Import Project="..\..\build\dependencies.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>net46;netcoreapp2.0</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -3,7 +3,7 @@
<Import Project="..\..\build\dependencies.props" /> <Import Project="..\..\build\dependencies.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>net46;netcoreapp2.0</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -160,7 +160,7 @@ namespace Microsoft.AspNetCore.Buffering
return _innerStream.WriteAsync(buffer, offset, count, cancellationToken); return _innerStream.WriteAsync(buffer, offset, count, cancellationToken);
} }
} }
#if NET46
public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback callback, object state) public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback callback, object state)
{ {
if (_isBuffering) if (_isBuffering)
@ -184,10 +184,7 @@ namespace Microsoft.AspNetCore.Buffering
_innerStream.EndWrite(asyncResult); _innerStream.EndWrite(asyncResult);
} }
} }
#elif NETSTANDARD1_3
#else
#error target frameworks need to be updated
#endif
public override void Flush() public override void Flush()
{ {
_isBuffering = false; _isBuffering = false;

View File

@ -5,7 +5,7 @@
<PropertyGroup> <PropertyGroup>
<VersionPrefix>0.3.0</VersionPrefix> <VersionPrefix>0.3.0</VersionPrefix>
<Description>ASP.NET Core middleware for buffering response bodies.</Description> <Description>ASP.NET Core middleware for buffering response bodies.</Description>
<TargetFrameworks>net46;netstandard1.3</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
<NoWarn>$(NoWarn);CS1591</NoWarn> <NoWarn>$(NoWarn);CS1591</NoWarn>
<GenerateDocumentationFile>true</GenerateDocumentationFile> <GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageTags>aspnetcore;buffer;buffering</PackageTags> <PackageTags>aspnetcore;buffer;buffering</PackageTags>

View File

@ -7,7 +7,7 @@
<Description>ASP.NET Core basic middleware for supporting HTTP method overrides. Includes: <Description>ASP.NET Core basic middleware for supporting HTTP method overrides. Includes:
* X-Forwarded-* headers to forward headers from a proxy. * X-Forwarded-* headers to forward headers from a proxy.
* HTTP method override header.</Description> * HTTP method override header.</Description>
<TargetFramework>netstandard1.3</TargetFramework> <TargetFramework>netcoreapp2.0</TargetFramework>
<NoWarn>$(NoWarn);CS1591</NoWarn> <NoWarn>$(NoWarn);CS1591</NoWarn>
<GenerateDocumentationFile>true</GenerateDocumentationFile> <GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageTags>aspnetcore;proxy;headers;xforwarded</PackageTags> <PackageTags>aspnetcore;proxy;headers;xforwarded</PackageTags>

View File

@ -137,7 +137,6 @@ namespace Microsoft.AspNetCore.ResponseCompression
} }
} }
#if NET46
public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback callback, Object state) public override IAsyncResult BeginWrite(byte[] buffer, int offset, int count, AsyncCallback callback, Object state)
{ {
var tcs = new TaskCompletionSource<object>(state); var tcs = new TaskCompletionSource<object>(state);
@ -184,10 +183,6 @@ namespace Microsoft.AspNetCore.ResponseCompression
var task = (Task)asyncResult; var task = (Task)asyncResult;
task.GetAwaiter().GetResult(); task.GetAwaiter().GetResult();
} }
#elif NETSTANDARD1_3
#else
#error target frameworks need to be updated
#endif
public override async Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken) public override async Task WriteAsync(byte[] buffer, int offset, int count, CancellationToken cancellationToken)
{ {

View File

@ -3,9 +3,6 @@
using System; using System;
using System.Collections.ObjectModel; using System.Collections.ObjectModel;
#if NETSTANDARD1_3
using System.Reflection;
#endif
namespace Microsoft.AspNetCore.ResponseCompression namespace Microsoft.AspNetCore.ResponseCompression
{ {

View File

@ -37,13 +37,7 @@ namespace Microsoft.AspNetCore.ResponseCompression
{ {
get get
{ {
#if NET46
return false;
#elif NETSTANDARD1_3
return true; return true;
#else
#error target frameworks need to be updated
#endif
} }
} }

View File

@ -5,7 +5,7 @@
<PropertyGroup> <PropertyGroup>
<VersionPrefix>2.0.0</VersionPrefix> <VersionPrefix>2.0.0</VersionPrefix>
<Description>ASP.NET Core middleware for HTTP Response compression.</Description> <Description>ASP.NET Core middleware for HTTP Response compression.</Description>
<TargetFrameworks>net46;netstandard1.3</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
<GenerateDocumentationFile>true</GenerateDocumentationFile> <GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageTags>aspnetcore</PackageTags> <PackageTags>aspnetcore</PackageTags>
</PropertyGroup> </PropertyGroup>

View File

@ -8,7 +8,7 @@
* Support for custom URL rewrite rules * Support for custom URL rewrite rules
* Support for running IIS URL Rewrite module rules * Support for running IIS URL Rewrite module rules
* Support for running Apache mod_rewrite rules.</Description> * Support for running Apache mod_rewrite rules.</Description>
<TargetFramework>netstandard1.3</TargetFramework> <TargetFramework>netcoreapp2.0</TargetFramework>
<NoWarn>$(NoWarn);CS1591</NoWarn> <NoWarn>$(NoWarn);CS1591</NoWarn>
<GenerateDocumentationFile>true</GenerateDocumentationFile> <GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageTags>aspnetcore;urlrewrite;mod_rewrite</PackageTags> <PackageTags>aspnetcore;urlrewrite;mod_rewrite</PackageTags>

View File

@ -3,10 +3,7 @@
<Import Project="..\..\build\common.props" /> <Import Project="..\..\build\common.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>netcoreapp2.0;net46</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -3,10 +3,7 @@
<Import Project="..\..\build\common.props" /> <Import Project="..\..\build\common.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>netcoreapp2.0;net46</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -108,7 +108,6 @@ namespace Microsoft.AspNetCore.ResponseCompression.Tests
Assert.Equal(File.ReadAllBytes(path), written); Assert.Equal(File.ReadAllBytes(path), written);
} }
#if NET46
[Theory] [Theory]
[InlineData(true)] [InlineData(true)]
[InlineData(false)] [InlineData(false)]
@ -133,10 +132,6 @@ namespace Microsoft.AspNetCore.ResponseCompression.Tests
Assert.Equal(buffer, written); Assert.Equal(buffer, written);
} }
#elif NETCOREAPP2_0
#else
#error Target framework needs to be updated
#endif
private class MockResponseCompressionProvider: IResponseCompressionProvider private class MockResponseCompressionProvider: IResponseCompressionProvider
{ {

View File

@ -3,10 +3,7 @@
<Import Project="..\..\build\common.props" /> <Import Project="..\..\build\common.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>netcoreapp2.0;net46</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>

View File

@ -505,16 +505,9 @@ namespace Microsoft.AspNetCore.ResponseCompression.Tests
var response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead); var response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead);
#if NET46 // Flush not supported, compression disabled
Assert.NotNull(response.Headers.GetValues(HeaderNames.ContentMD5));
Assert.Empty(response.Content.Headers.ContentEncoding);
#elif NETCOREAPP2_0 // Flush supported, compression enabled
IEnumerable<string> contentMD5 = null; IEnumerable<string> contentMD5 = null;
Assert.False(response.Headers.TryGetValues(HeaderNames.ContentMD5, out contentMD5)); Assert.False(response.Headers.TryGetValues(HeaderNames.ContentMD5, out contentMD5));
Assert.Single(response.Content.Headers.ContentEncoding, "gzip"); Assert.Single(response.Content.Headers.ContentEncoding, "gzip");
#else
#error Target frameworks need to be updated.
#endif
var body = await response.Content.ReadAsStreamAsync(); var body = await response.Content.ReadAsStreamAsync();
@ -570,16 +563,9 @@ namespace Microsoft.AspNetCore.ResponseCompression.Tests
var response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead); var response = await client.SendAsync(request, HttpCompletionOption.ResponseHeadersRead);
#if NET46 // Flush not supported, compression disabled
Assert.NotNull(response.Headers.GetValues(HeaderNames.ContentMD5));
Assert.Empty(response.Content.Headers.ContentEncoding);
#elif NETCOREAPP2_0 // Flush supported, compression enabled
IEnumerable<string> contentMD5 = null; IEnumerable<string> contentMD5 = null;
Assert.False(response.Headers.TryGetValues(HeaderNames.ContentMD5, out contentMD5)); Assert.False(response.Headers.TryGetValues(HeaderNames.ContentMD5, out contentMD5));
Assert.Single(response.Content.Headers.ContentEncoding, "gzip"); Assert.Single(response.Content.Headers.ContentEncoding, "gzip");
#else
#error Target framework needs to be updated
#endif
var body = await response.Content.ReadAsStreamAsync(); var body = await response.Content.ReadAsStreamAsync();

View File

@ -3,10 +3,7 @@
<Import Project="..\..\build\common.props" /> <Import Project="..\..\build\common.props" />
<PropertyGroup> <PropertyGroup>
<TargetFrameworks>netcoreapp2.0;net46</TargetFrameworks> <TargetFramework>netcoreapp2.0</TargetFramework>
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netcoreapp2.0</TargetFrameworks>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>