huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add + to allowed username characters by default

This commit is contained in:
Hao Kung 2016-02-23 13:18:11 -08:00
parent d1585617f9
commit f78c13c2fa
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Microsoft.AspNetCore.Identity/UserOptions.cs
View File

@ -14,7 +14,7 @@ namespace Microsoft.AspNetCore.Identity
/// <value> /// <value>
/// The list of allowed characters in the username used to validate user names. /// The list of allowed characters in the username used to validate user names.
/// </value> /// </value>
public string AllowedUserNameCharacters { get; set; } = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._@"; public string AllowedUserNameCharacters { get; set; } = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._@+";
/// <summary> /// <summary>
/// Gets or sets a flag indicating whether the application requires unique emails for its users. /// Gets or sets a flag indicating whether the application requires unique emails for its users.

4
test/Microsoft.AspNetCore.Identity.Test/IdentityOptionsTest.cs
View File

@ -28,7 +28,7 @@ namespace Microsoft.AspNetCore.Identity.Test
Assert.True(options.Password.RequireUppercase); Assert.True(options.Password.RequireUppercase);
Assert.Equal(6, options.Password.RequiredLength); Assert.Equal(6, options.Password.RequiredLength);
Assert.Equal("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._@", options.User.AllowedUserNameCharacters); Assert.Equal("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._@+", options.User.AllowedUserNameCharacters);
Assert.False(options.User.RequireUniqueEmail); Assert.False(options.User.RequireUniqueEmail);
Assert.Equal(ClaimTypes.Role, options.ClaimsIdentity.RoleClaimType); Assert.Equal(ClaimTypes.Role, options.ClaimsIdentity.RoleClaimType);
@ -76,7 +76,7 @@ namespace Microsoft.AspNetCore.Identity.Test
Assert.Equal(usernameClaimType, options.ClaimsIdentity.UserNameClaimType); Assert.Equal(usernameClaimType, options.ClaimsIdentity.UserNameClaimType);
Assert.Equal(securityStampClaimType, options.ClaimsIdentity.SecurityStampClaimType); Assert.Equal(securityStampClaimType, options.ClaimsIdentity.SecurityStampClaimType);
Assert.True(options.User.RequireUniqueEmail); Assert.True(options.User.RequireUniqueEmail);
Assert.Equal("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._@", options.User.AllowedUserNameCharacters); Assert.Equal("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-._@+", options.User.AllowedUserNameCharacters);
Assert.False(options.Password.RequireDigit); Assert.False(options.Password.RequireDigit);
Assert.False(options.Password.RequireLowercase); Assert.False(options.Password.RequireLowercase);
Assert.False(options.Password.RequireNonAlphanumeric); Assert.False(options.Password.RequireNonAlphanumeric);

1
test/Microsoft.AspNetCore.Identity.Test/UserValidatorTest.cs
View File

@ -44,6 +44,7 @@ namespace Microsoft.AspNetCore.Identity.Test
[InlineData("hao", true)] [InlineData("hao", true)]
[InlineData("test123", true)] [InlineData("test123", true)]
[InlineData("hyphen-yes@foo-bar.com", true)] [InlineData("hyphen-yes@foo-bar.com", true)]
[InlineData("+plus+yes+@foo-bar.com", true)]
[InlineData("!noway", false)] [InlineData("!noway", false)]
[InlineData("foo@boz#.com", false)] [InlineData("foo@boz#.com", false)]
public async Task DefaultAlphaNumericOnlyUserNameValidation(string userName, bool expectSuccess) public async Task DefaultAlphaNumericOnlyUserNameValidation(string userName, bool expectSuccess)