From f6d589a6c4f79ec078e91b38b5e1bbf10ddc701d Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Wed, 7 Nov 2018 17:08:44 -0800 Subject: [PATCH] Remove invalid Debug.Assert in Http2Connection (#3080) The _streams dictionary may not contain the completing stream in OnStreamCompleted since the IsDraining flag is applied beforehand which allows it to be removed by the request processing thread. --- src/Kestrel.Core/Internal/Http2/Http2Connection.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Kestrel.Core/Internal/Http2/Http2Connection.cs b/src/Kestrel.Core/Internal/Http2/Http2Connection.cs index 859862a541..abb2ec13e1 100644 --- a/src/Kestrel.Core/Internal/Http2/Http2Connection.cs +++ b/src/Kestrel.Core/Internal/Http2/Http2Connection.cs @@ -1062,10 +1062,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2 _streams.TryRemove(streamId, out _); } } - else - { - Debug.Assert(false, "Missing stream"); - } if (_activeStreamCount == 0) {