diff --git a/src/Microsoft.AspNetCore.Razor.Runtime/Runtime/TagHelpers/TagHelperScopeManager.cs b/src/Microsoft.AspNetCore.Razor.Runtime/Runtime/TagHelpers/TagHelperScopeManager.cs index a48e95ee28..28b824c7be 100644 --- a/src/Microsoft.AspNetCore.Razor.Runtime/Runtime/TagHelpers/TagHelperScopeManager.cs +++ b/src/Microsoft.AspNetCore.Razor.Runtime/Runtime/TagHelpers/TagHelperScopeManager.cs @@ -20,9 +20,26 @@ namespace Microsoft.AspNetCore.Razor.Runtime.TagHelpers /// /// Instantiates a new . /// - public TagHelperScopeManager() + /// + /// A delegate used to start a writing scope in a Razor page and optionally override the page's + /// within that scope. + /// + /// A delegate used to end a writing scope in a Razor page. + public TagHelperScopeManager( + Action startTagHelperWritingScope, + Func endTagHelperWritingScope) { - _executionContextPool = new ExecutionContextPool(); + if (startTagHelperWritingScope == null) + { + throw new ArgumentNullException(nameof(startTagHelperWritingScope)); + } + + if (endTagHelperWritingScope == null) + { + throw new ArgumentNullException(nameof(endTagHelperWritingScope)); + } + + _executionContextPool = new ExecutionContextPool(startTagHelperWritingScope, endTagHelperWritingScope); } /// @@ -32,19 +49,12 @@ namespace Microsoft.AspNetCore.Razor.Runtime.TagHelpers /// HTML syntax of the element in the Razor source. /// An identifier unique to the HTML element this scope is for. /// A delegate used to execute the child content asynchronously. - /// - /// A delegate used to start a writing scope in a Razor page and optionally override the page's - /// within that scope. - /// - /// A delegate used to end a writing scope in a Razor page. /// A to use. public TagHelperExecutionContext Begin( string tagName, TagMode tagMode, string uniqueId, - Func executeChildContentAsync, - Action startTagHelperWritingScope, - Func endTagHelperWritingScope) + Func executeChildContentAsync) { if (tagName == null) { @@ -61,16 +71,6 @@ namespace Microsoft.AspNetCore.Razor.Runtime.TagHelpers throw new ArgumentNullException(nameof(executeChildContentAsync)); } - if (startTagHelperWritingScope == null) - { - throw new ArgumentNullException(nameof(startTagHelperWritingScope)); - } - - if (endTagHelperWritingScope == null) - { - throw new ArgumentNullException(nameof(endTagHelperWritingScope)); - } - IDictionary items; var parentExecutionContext = _executionContextPool.Current; @@ -91,9 +91,7 @@ namespace Microsoft.AspNetCore.Razor.Runtime.TagHelpers tagMode, items, uniqueId, - executeChildContentAsync, - startTagHelperWritingScope, - endTagHelperWritingScope); + executeChildContentAsync); return executionContext; } @@ -123,12 +121,18 @@ namespace Microsoft.AspNetCore.Razor.Runtime.TagHelpers private class ExecutionContextPool { + private readonly Action _startTagHelperWritingScope; + private readonly Func _endTagHelperWritingScope; private readonly List _executionContexts; private int _nextIndex; - public ExecutionContextPool() + public ExecutionContextPool( + Action startTagHelperWritingScope, + Func endTagHelperWritingScope) { _executionContexts = new List(); + _startTagHelperWritingScope = startTagHelperWritingScope; + _endTagHelperWritingScope = endTagHelperWritingScope; } public TagHelperExecutionContext Current => _nextIndex > 0 ? _executionContexts[_nextIndex - 1] : null; @@ -138,9 +142,7 @@ namespace Microsoft.AspNetCore.Razor.Runtime.TagHelpers TagMode tagMode, IDictionary items, string uniqueId, - Func executeChildContentAsync, - Action startTagHelperWritingScope, - Func endTagHelperWritingScope) + Func executeChildContentAsync) { TagHelperExecutionContext tagHelperExecutionContext; @@ -152,8 +154,8 @@ namespace Microsoft.AspNetCore.Razor.Runtime.TagHelpers items, uniqueId, executeChildContentAsync, - startTagHelperWritingScope, - endTagHelperWritingScope); + _startTagHelperWritingScope, + _endTagHelperWritingScope); _executionContexts.Add(tagHelperExecutionContext); } diff --git a/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpCodeGenerator.cs b/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpCodeGenerator.cs index ab81d26494..a67b9a865a 100644 --- a/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpCodeGenerator.cs +++ b/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpCodeGenerator.cs @@ -78,7 +78,7 @@ namespace Microsoft.AspNetCore.Razor.CodeGenerators { using (writer.BuildMethodDeclaration("public override async", "Task", Host.GeneratedClassContext.ExecuteMethodName)) { - new CSharpTagHelperRunnerInitializationVisitor(writer, Context).Accept(Tree.Children); + new CSharpTagHelperPropertyInitializationVisitor(writer, Context).Accept(Tree.Children); csharpCodeVisitor.Accept(Tree.Children); } } diff --git a/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpTagHelperCodeRenderer.cs b/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpTagHelperCodeRenderer.cs index 93ec604d4c..132915b4f3 100644 --- a/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpTagHelperCodeRenderer.cs +++ b/src/Microsoft.AspNetCore.Razor/CodeGenerators/CSharpTagHelperCodeRenderer.cs @@ -173,11 +173,7 @@ namespace Microsoft.AspNetCore.Razor.CodeGenerators _context.TargetWriterName = oldWriter; - _writer.WriteParameterSeparator() - .Write(_tagHelperContext.StartTagHelperWritingScopeMethodName) - .WriteParameterSeparator() - .Write(_tagHelperContext.EndTagHelperWritingScopeMethodName) - .WriteEndMethodInvocation(); + _writer.WriteEndMethodInvocation(); } /// diff --git a/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperFieldDeclarationVisitor.cs b/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperFieldDeclarationVisitor.cs index c01bb2fa2f..47ea26068d 100644 --- a/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperFieldDeclarationVisitor.cs +++ b/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperFieldDeclarationVisitor.cs @@ -69,13 +69,10 @@ namespace Microsoft.AspNetCore.Razor.CodeGenerators.Visitors CSharpTagHelperCodeRenderer.RunnerVariableName, value: null); - Writer - .Write("private global::") - .Write(_tagHelperContext.ScopeManagerTypeName) - .Write(" ") - .WriteStartAssignment(CSharpTagHelperCodeRenderer.ScopeManagerVariableName) - .WriteStartNewObject("global::" + _tagHelperContext.ScopeManagerTypeName) - .WriteEndMethodInvocation(); + WritePrivateField( + _tagHelperContext.ScopeManagerTypeName, + CSharpTagHelperCodeRenderer.ScopeManagerVariableName, + value: null); } } diff --git a/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperRunnerInitializationVisitor.cs b/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperPropertyInitializationVisitor.cs similarity index 77% rename from src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperRunnerInitializationVisitor.cs rename to src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperPropertyInitializationVisitor.cs index 7712116efc..4408443f1a 100644 --- a/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperRunnerInitializationVisitor.cs +++ b/src/Microsoft.AspNetCore.Razor/CodeGenerators/Visitors/CSharpTagHelperPropertyInitializationVisitor.cs @@ -9,18 +9,19 @@ namespace Microsoft.AspNetCore.Razor.CodeGenerators.Visitors /// /// The that generates the code to initialize the TagHelperRunner. /// - public class CSharpTagHelperRunnerInitializationVisitor : CodeVisitor + public class CSharpTagHelperPropertyInitializationVisitor : CodeVisitor { private readonly GeneratedTagHelperContext _tagHelperContext; private bool _foundTagHelpers; /// - /// Creates a new instance of . + /// Creates a new instance of . /// /// The used to generate code. /// The . - public CSharpTagHelperRunnerInitializationVisitor(CSharpCodeWriter writer, - CodeGeneratorContext context) + public CSharpTagHelperPropertyInitializationVisitor( + CSharpCodeWriter writer, + CodeGeneratorContext context) : base(writer, context) { if (writer == null) @@ -76,6 +77,16 @@ namespace Microsoft.AspNetCore.Razor.CodeGenerators.Visitors .Write(" ?? ") .WriteStartNewObject("global::" + _tagHelperContext.RunnerTypeName) .WriteEndMethodInvocation(); + + Writer + .WriteStartAssignment(CSharpTagHelperCodeRenderer.ScopeManagerVariableName) + .Write(CSharpTagHelperCodeRenderer.ScopeManagerVariableName) + .Write(" ?? ") + .WriteStartNewObject("global::" + _tagHelperContext.ScopeManagerTypeName) + .Write(_tagHelperContext.StartTagHelperWritingScopeMethodName) + .WriteParameterSeparator() + .Write(_tagHelperContext.EndTagHelperWritingScopeMethodName) + .WriteEndMethodInvocation(); } } } diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/AttributeTargetingTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/AttributeTargetingTagHelpers.cs index dc1531366e..93e2424409 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/AttributeTargetingTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/AttributeTargetingTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("btn")); private global::TestNamespace.CatchAllTagHelper __TestNamespace_CatchAllTagHelper = null; @@ -28,6 +28,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(28, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -40,7 +41,7 @@ namespace TestOutput WriteLiteral("Hello"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_1); @@ -58,7 +59,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -82,7 +83,7 @@ __TestNamespace_InputTagHelper2.Checked = true; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -108,7 +109,7 @@ __TestNamespace_InputTagHelper2.Checked = true; WriteLiteral("\r\n"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.CustomAttributeCodeGenerator.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.CustomAttributeCodeGenerator.cs index d86203ceda..dcf75126ea 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.CustomAttributeCodeGenerator.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.CustomAttributeCodeGenerator.cs @@ -11,7 +11,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("Hello World")); private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_1 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("data-delay", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("1000")); @@ -27,6 +27,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(33, 71, true); WriteLiteral("\r\n
\r\n "); Instrumentation.EndContext(); @@ -36,7 +37,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_2); @@ -50,7 +51,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagOnly, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -78,7 +79,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -101,7 +102,7 @@ __TestNamespace_InputTagHelper2.Checked = **From custom attribute code renderer* WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.Prefixed.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.Prefixed.cs index d42bdc4786..999fa5c606 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.Prefixed.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.Prefixed.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("Hello World")); private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; @@ -26,6 +26,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(55, 52, true); WriteLiteral("\r\n\r\n "); Instrumentation.EndContext(); @@ -35,7 +36,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagOnly, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -58,7 +59,7 @@ namespace TestOutput WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.cs index 895cebdf9a..8917b36a81 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/BasicTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("Hello World")); private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_1 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("data-delay", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("1000")); @@ -28,6 +28,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(33, 71, true); WriteLiteral("\r\n
\r\n "); Instrumentation.EndContext(); @@ -37,7 +38,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_2); @@ -51,7 +52,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagOnly, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -79,7 +80,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -102,7 +103,7 @@ __TestNamespace_InputTagHelper2.Checked = true; WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/ComplexTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/ComplexTagHelpers.cs index 29f64215b9..335d9229bd 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/ComplexTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/ComplexTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; private global::TestNamespace.InputTagHelper2 __TestNamespace_InputTagHelper2 = null; @@ -32,6 +32,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -73,7 +74,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -89,7 +90,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.End(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); await __tagHelperRunner.RunAsync(__tagHelperExecutionContext); @@ -121,7 +122,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -148,7 +149,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.End(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); await __tagHelperRunner.RunAsync(__tagHelperExecutionContext); @@ -165,7 +166,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -190,7 +191,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagOnly, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -250,7 +251,7 @@ namespace TestOutput WriteLiteral(" "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "time", 3); @@ -295,7 +296,7 @@ AddHtmlAttributeValue(" ", 159, DateTime.Now, 160, 14, false); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagOnly, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -315,7 +316,7 @@ __TestNamespace_InputTagHelper2.Checked = (@object); WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_2); @@ -344,7 +345,7 @@ __TestNamespace_InputTagHelper2.Checked = (@object); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -366,7 +367,7 @@ __TestNamespace_InputTagHelper2.Checked = (@object); WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); #line 25 "ComplexTagHelpers.cshtml" @@ -393,7 +394,7 @@ __TestNamespace_PTagHelper.Age = -1970 + @DateTimeOffset.Now.Year; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagOnly, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -413,7 +414,7 @@ __TestNamespace_InputTagHelper2.Checked = DateTimeOffset.Now.Year > 2014; WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); #line 28 "ComplexTagHelpers.cshtml" @@ -440,7 +441,7 @@ __TestNamespace_PTagHelper.Age = DateTimeOffset.Now.Year - 1970; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -460,7 +461,7 @@ __TestNamespace_InputTagHelper2.Checked = @( DateTimeOffset.Now.Year ) > 20 WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); #line 31 "ComplexTagHelpers.cshtml" @@ -487,7 +488,7 @@ __TestNamespace_PTagHelper.Age = ("My age is this long.".Length); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -504,7 +505,7 @@ __TestNamespace_PTagHelper.Age = ("My age is this long.".Length); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.End(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); #line 34 "ComplexTagHelpers.cshtml" diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateAttributeTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateAttributeTagHelpers.cs index 63a2993bff..4d9afe8936 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateAttributeTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateAttributeTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("AGE", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("40")); private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_1 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("Age", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("500")); @@ -30,6 +30,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -39,7 +40,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -58,7 +59,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -83,7 +84,7 @@ __TestNamespace_InputTagHelper2.Checked = true; WriteLiteral("\r\n"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); #line 3 "DuplicateAttributeTagHelpers.cshtml" diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateTargetTagHelper.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateTargetTagHelper.cs index 29206f02de..abb57d084e 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateTargetTagHelper.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DuplicateTargetTagHelper.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; private global::TestNamespace.CatchAllTagHelper __TestNamespace_CatchAllTagHelper = null; #line hidden @@ -24,12 +24,13 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DynamicAttributeTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DynamicAttributeTagHelpers.cs index e490ed94c4..4d27238b05 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DynamicAttributeTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/DynamicAttributeTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; #line hidden public DynamicAttributeTagHelpers() @@ -23,12 +23,13 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "unbound", 2); @@ -49,7 +50,7 @@ AddHtmlAttributeValue(" ", 55, DateTime.Now, 56, 14, false); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "unbound", 2); @@ -100,7 +101,7 @@ WriteTo(__razor_attribute_value_writer, string.Empty); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); StartTagHelperWritingScope(null); @@ -133,7 +134,7 @@ AddHtmlAttributeValue(" ", 210, DateTime.Now, 211, 14, false); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); StartTagHelperWritingScope(null); @@ -237,7 +238,7 @@ AddHtmlAttributeValue(" ", 404, int.MaxValue, 405, 14, false); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "unbound", 5); @@ -269,7 +270,7 @@ AddHtmlAttributeValue(" ", 488, int.MaxValue, 489, 14, false); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "unbound", 1); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EmptyAttributeTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EmptyAttributeTagHelpers.cs index dcd84747ed..a0b7078833 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EmptyAttributeTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EmptyAttributeTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; private global::TestNamespace.InputTagHelper2 __TestNamespace_InputTagHelper2 = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("")); @@ -26,12 +26,13 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(25, 13, true); WriteLiteral("\r\n
\r\n "); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -60,7 +61,7 @@ __TestNamespace_InputTagHelper2.Checked = ; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -84,7 +85,7 @@ __TestNamespace_InputTagHelper2.Checked = ; WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); #line 5 "EmptyAttributeTagHelpers.cshtml" diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EnumTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EnumTagHelpers.cs index 1653b925ae..587cd21663 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EnumTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EnumTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; private global::TestNamespace.CatchAllTagHelper __TestNamespace_CatchAllTagHelper = null; #line hidden @@ -24,6 +24,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -39,7 +40,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); @@ -60,7 +61,7 @@ __TestNamespace_InputTagHelper.Value = MyEnum.MyValue; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); @@ -82,7 +83,7 @@ AddHtmlAttributeValue("", 128, MyEnum.MySecondValue, 128, 21, false); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); @@ -103,7 +104,7 @@ __TestNamespace_InputTagHelper.Value = global::Microsoft.AspNetCore.Razor.Test.G Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); @@ -130,7 +131,7 @@ __TestNamespace_CatchAllTagHelper.CatchAll = global::Microsoft.AspNetCore.Razor. Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EscapedTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EscapedTagHelpers.cs index d4c9c88840..3edaaca1ec 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EscapedTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/EscapedTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; private global::TestNamespace.InputTagHelper2 __TestNamespace_InputTagHelper2 = null; #line hidden @@ -24,6 +24,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(25, 72, true); WriteLiteral("\r\n
\r\n

{ } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/IncompleteTagHelper.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/IncompleteTagHelper.cs index 6c5ba5eb91..4875509ad1 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/IncompleteTagHelper.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/IncompleteTagHelper.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("")); #line hidden @@ -24,12 +24,13 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/MinimizedTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/MinimizedTagHelpers.cs index 13a263c3e0..180b9662c7 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/MinimizedTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/MinimizedTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.CatchAllTagHelper __TestNamespace_CatchAllTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("catchall-unbound-required"); private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_1 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("btn")); @@ -29,6 +29,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -38,7 +39,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_1); @@ -53,7 +54,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); @@ -73,7 +74,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); @@ -95,7 +96,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); @@ -115,7 +116,7 @@ namespace TestOutput WriteLiteral("\r\n"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/NestedScriptTagTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/NestedScriptTagTagHelpers.cs index edb8e513c5..b9db37ceee 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/NestedScriptTagTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/NestedScriptTagTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("Hello World")); private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_1 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("data-delay", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("1000")); @@ -27,6 +27,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 106, true); WriteLiteral("\r\n\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.Reversed.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.Reversed.cs index 6849c67323..5b8dcae72f 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.Reversed.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.Reversed.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.InputTagHelper2 __TestNamespace_InputTagHelper2 = null; private global::TestNamespace.InputTagHelper1 __TestNamespace_InputTagHelper1 = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("type", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("checkbox")); @@ -28,6 +28,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -51,7 +52,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper2 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper2); __TestNamespace_InputTagHelper1 = CreateTagHelper(); @@ -81,7 +82,7 @@ __TestNamespace_InputTagHelper2.IntDictionaryProperty = intDictionary; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper2 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper2); if (__TestNamespace_InputTagHelper2.IntDictionaryProperty == null) @@ -126,7 +127,7 @@ __TestNamespace_InputTagHelper2.IntDictionaryProperty = intDictionary; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper2 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper2); if (__TestNamespace_InputTagHelper2.IntDictionaryProperty == null) @@ -198,7 +199,7 @@ __TestNamespace_InputTagHelper2.IntDictionaryProperty["salt"] = 37; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper2 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper2); if (__TestNamespace_InputTagHelper2.IntDictionaryProperty == null) diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.cs index b265168668..0c74fef753 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/PrefixedAttributeTagHelpers.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.InputTagHelper1 __TestNamespace_InputTagHelper1 = null; private global::TestNamespace.InputTagHelper2 __TestNamespace_InputTagHelper2 = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("type", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("checkbox")); @@ -28,6 +28,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -51,7 +52,7 @@ namespace TestOutput Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper1 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper1); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -81,7 +82,7 @@ __TestNamespace_InputTagHelper1.IntDictionaryProperty = intDictionary; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper1 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper1); if (__TestNamespace_InputTagHelper1.IntDictionaryProperty == null) @@ -126,7 +127,7 @@ __TestNamespace_InputTagHelper1.IntDictionaryProperty = intDictionary; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper1 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper1); if (__TestNamespace_InputTagHelper1.IntDictionaryProperty == null) @@ -198,7 +199,7 @@ __TestNamespace_InputTagHelper1.IntDictionaryProperty["salt"] = 37; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper1 = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper1); if (__TestNamespace_InputTagHelper1.IntDictionaryProperty == null) diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelper.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelper.cs index 0c08dee9fa..74809dd046 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelper.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelper.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("Hello World")); #line hidden @@ -24,6 +24,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -32,7 +33,7 @@ namespace TestOutput WriteLiteral("Body of Tag"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelperWithNewlineBeforeAttributes.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelperWithNewlineBeforeAttributes.cs index 44dfeb7838..90a11c2c00 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelperWithNewlineBeforeAttributes.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SingleTagHelperWithNewlineBeforeAttributes.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("Hello World")); #line hidden @@ -24,6 +24,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -32,7 +33,7 @@ namespace TestOutput WriteLiteral("Body of Tag"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SymbolBoundAttributes.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SymbolBoundAttributes.cs index 57ce9959e2..f119694e16 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SymbolBoundAttributes.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/SymbolBoundAttributes.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.CatchAllTagHelper __TestNamespace_CatchAllTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("bound"); private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_1 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("[item]", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("items")); @@ -31,12 +31,13 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(23, 253, true); WriteLiteral("\r\n

    \r\n
      \r\n\r\n\r\n\r\n
      \r\n
      \r\n\r\n"); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("ul", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -57,7 +58,7 @@ __TestNamespace_CatchAllTagHelper.ListItems = items; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("ul", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -81,7 +82,7 @@ __TestNamespace_CatchAllTagHelper.ArrayItems = items; WriteLiteral("Click Me"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -109,7 +110,7 @@ __TestNamespace_CatchAllTagHelper.Event1 = doSomething(); WriteLiteral("Click Me"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -137,7 +138,7 @@ __TestNamespace_CatchAllTagHelper.Event2 = doSomething(); WriteLiteral("\r\n"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -158,7 +159,7 @@ __TestNamespace_CatchAllTagHelper.Event2 = doSomething(); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("div", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -173,7 +174,7 @@ __TestNamespace_CatchAllTagHelper.Event2 = doSomething(); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("div", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_CatchAllTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_CatchAllTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersInSection.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersInSection.cs index b8aadb20ef..781587b136 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersInSection.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersInSection.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.MyTagHelper __TestNamespace_MyTagHelper = null; private global::TestNamespace.NestedTagHelper __TestNamespace_NestedTagHelper = null; #line hidden @@ -24,6 +24,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -57,7 +58,7 @@ namespace TestOutput #line hidden Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_NestedTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_NestedTagHelper); await __tagHelperRunner.RunAsync(__tagHelperExecutionContext); @@ -73,7 +74,7 @@ namespace TestOutput WriteLiteral("\r\n "); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_MyTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_MyTagHelper); StartTagHelperWritingScope(null); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersWithWeirdlySpacedAttributes.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersWithWeirdlySpacedAttributes.cs index d1bfbb3299..8113aa23e6 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersWithWeirdlySpacedAttributes.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TagHelpersWithWeirdlySpacedAttributes.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("Hello World")); private global::TestNamespace.InputTagHelper __TestNamespace_InputTagHelper = null; @@ -29,6 +29,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); Instrumentation.BeginContext(31, 2, true); WriteLiteral("\r\n"); Instrumentation.EndContext(); @@ -37,7 +38,7 @@ namespace TestOutput WriteLiteral("Body of Tag"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -69,7 +70,7 @@ __TestNamespace_PTagHelper.Age = 1337; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); @@ -88,7 +89,7 @@ __TestNamespace_PTagHelper.Age = 1337; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); #line 11 "TagHelpersWithWeirdlySpacedAttributes.cshtml" @@ -108,7 +109,7 @@ __TestNamespace_PTagHelper.Age = 1234; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("input", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.SelfClosing, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_InputTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_InputTagHelper); __TestNamespace_InputTagHelper2 = CreateTagHelper(); diff --git a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TransitionsInTagHelperAttributes.cs b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TransitionsInTagHelperAttributes.cs index 765d661782..8d0622722a 100644 --- a/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TransitionsInTagHelperAttributes.cs +++ b/test/Microsoft.AspNetCore.Razor.Test/TestFiles/CodeGenerator/Output/TransitionsInTagHelperAttributes.cs @@ -12,7 +12,7 @@ namespace TestOutput #pragma warning restore 0414 private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperExecutionContext __tagHelperExecutionContext = null; private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner __tagHelperRunner = null; - private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(); + private global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager __tagHelperScopeManager = null; private global::TestNamespace.PTagHelper __TestNamespace_PTagHelper = null; private static readonly global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute __tagHelperAttribute_0 = new global::Microsoft.AspNetCore.Razor.TagHelpers.TagHelperAttribute("class", new global::Microsoft.AspNetCore.Html.HtmlEncodedString("test")); #line hidden @@ -24,6 +24,7 @@ namespace TestOutput public override async Task ExecuteAsync() { __tagHelperRunner = __tagHelperRunner ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperRunner(); + __tagHelperScopeManager = __tagHelperScopeManager ?? new global::Microsoft.AspNetCore.Razor.Runtime.TagHelperScopeManager(StartTagHelperWritingScope, EndTagHelperWritingScope); #line 2 "TransitionsInTagHelperAttributes.cshtml" var @class = "container-fluid"; @@ -40,7 +41,7 @@ namespace TestOutput WriteLiteral("Body of Tag"); Instrumentation.EndContext(); } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "class", 1); @@ -68,7 +69,7 @@ __TestNamespace_PTagHelper.Age = 1337; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "class", 1); @@ -94,7 +95,7 @@ __TestNamespace_PTagHelper.Age = 42; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -114,7 +115,7 @@ __TestNamespace_PTagHelper.Age = 42 + @int; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -134,7 +135,7 @@ __TestNamespace_PTagHelper.Age = int; Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); __tagHelperExecutionContext.AddHtmlAttribute(__tagHelperAttribute_0); @@ -154,7 +155,7 @@ __TestNamespace_PTagHelper.Age = (@int); Instrumentation.EndContext(); __tagHelperExecutionContext = __tagHelperScopeManager.Begin("p", global::Microsoft.AspNetCore.Razor.TagHelpers.TagMode.StartTagAndEndTag, "test", async() => { } - , StartTagHelperWritingScope, EndTagHelperWritingScope); + ); __TestNamespace_PTagHelper = CreateTagHelper(); __tagHelperExecutionContext.Add(__TestNamespace_PTagHelper); BeginAddHtmlAttributeValues(__tagHelperExecutionContext, "class", 2);