From f4679fe74fd1cae59183de729c54ece87eb9954d Mon Sep 17 00:00:00 2001 From: Kristian Hellang Date: Mon, 2 May 2016 20:50:06 +0200 Subject: [PATCH] Changed RequireHttpsAttribute to default to 302 instead of 301 --- src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs | 2 +- .../RequireHttpsAttributeTests.cs | 4 ++-- test/Microsoft.AspNetCore.Mvc.FunctionalTests/BasicTests.cs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs b/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs index bcfa5673a9..40975dd211 100644 --- a/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs +++ b/src/Microsoft.AspNetCore.Mvc.Core/RequireHttpsAttribute.cs @@ -84,7 +84,7 @@ namespace Microsoft.AspNetCore.Mvc request.QueryString.ToUriComponent()); // redirect to HTTPS version of page - filterContext.Result = new RedirectResult(newUrl, permanent: true); + filterContext.Result = new RedirectResult(newUrl, permanent: false); } } } diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs index 31929aaf74..713b58e3cc 100644 --- a/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/RequireHttpsAttributeTests.cs @@ -99,7 +99,7 @@ namespace Microsoft.AspNetCore.Mvc Assert.NotNull(authContext.Result); var result = Assert.IsType(authContext.Result); - Assert.True(result.Permanent); + Assert.False(result.Permanent); Assert.Equal(expectedUrl, result.Url); } @@ -216,4 +216,4 @@ namespace Microsoft.AspNetCore.Mvc return services.BuildServiceProvider(); } } -} \ No newline at end of file +} diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/BasicTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/BasicTests.cs index 3dafb33608..e83888f4d1 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/BasicTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/BasicTests.cs @@ -178,7 +178,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests var response = await Client.GetAsync("Home/HttpsOnlyAction"); // Assert - Assert.Equal(HttpStatusCode.MovedPermanently, response.StatusCode); + Assert.Equal(HttpStatusCode.Found, response.StatusCode); Assert.NotNull(response.Headers.Location); Assert.Equal("https://localhost/Home/HttpsOnlyAction", response.Headers.Location.ToString()); Assert.Equal(0, response.Content.Headers.ContentLength);