huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Quick fix: Simplify `OrderUsingHtmlHelpers.cshtml` layout 

- intent was to make HTML helper output close to the tag helper output but source got over-complicated
- the output files for `Order.cshtml` and `OrderUsingHtmlHelpers.cshtml` now differ only in attribute order
 - i.e. HTML helpers output attribute alphabetically while tag helpers output them in order added
This commit is contained in:
Doug Bunting 2016-05-02 12:53:32 -07:00
parent ad1375abdb
commit f05f6d5bd2
3 changed files with 21 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/Microsoft.AspNetCore.Mvc.FunctionalTests/compiler/resources/HtmlGenerationWebSite.HtmlGeneration_Home.OrderUsingHtmlHelpers.Encoded.html
View File

@ -4,7 +4,8 @@
<title></title> <title></title>
</head> </head>
<body> <body>
<form action="HtmlEncode[[/UrlEncode[[HtmlGeneration_Order]]/UrlEncode[[Submit]]]]" method="HtmlEncode[[post]]"> <div> <form action="HtmlEncode[[/UrlEncode[[HtmlGeneration_Order]]/UrlEncode[[Submit]]]]" method="HtmlEncode[[post]]">
<div>
<label class="HtmlEncode[[order]]" for="HtmlEncode[[Shipping]]">HtmlEncode[[Shipping]]</label> <label class="HtmlEncode[[order]]" for="HtmlEncode[[Shipping]]">HtmlEncode[[Shipping]]</label>
<input id="HtmlEncode[[Shipping]]" name="HtmlEncode[[Shipping]]" size="HtmlEncode[[50]]" type="HtmlEncode[[text]]" value="HtmlEncode[[Your shipping method is UPSP]]" /> <input id="HtmlEncode[[Shipping]]" name="HtmlEncode[[Shipping]]" size="HtmlEncode[[50]]" type="HtmlEncode[[text]]" value="HtmlEncode[[Your shipping method is UPSP]]" />
</div> </div>
@ -74,6 +75,8 @@
</div> </div>
<div class="HtmlEncode[[validation-summary-valid order]]" data-valmsg-summary="HtmlEncode[[true]]"><ul><li style="display:none"></li> <div class="HtmlEncode[[validation-summary-valid order]]" data-valmsg-summary="HtmlEncode[[true]]"><ul><li style="display:none"></li>
</ul></div> </ul></div>
<input id="HtmlEncode[[Customer_Key]]" name="HtmlEncode[[Customer.Key]]" type="HtmlEncode[[hidden]]" value="HtmlEncode[[KeyA]]" /> <input type="submit"/> <input id="HtmlEncode[[Customer_Key]]" name="HtmlEncode[[Customer.Key]]" type="HtmlEncode[[hidden]]" value="HtmlEncode[[KeyA]]" />
<input name="HtmlEncode[[__RequestVerificationToken]]" type="hidden" value="{0}" /><input name="HtmlEncode[[NeedSpecialHandle]]" type="HtmlEncode[[hidden]]" value="HtmlEncode[[false]]" /></form></body> <input type="submit"/>
<input name="HtmlEncode[[__RequestVerificationToken]]" type="hidden" value="{0}" /><input name="HtmlEncode[[NeedSpecialHandle]]" type="HtmlEncode[[hidden]]" value="HtmlEncode[[false]]" /></form>
</body>
</html> </html>

9
test/Microsoft.AspNetCore.Mvc.FunctionalTests/compiler/resources/HtmlGenerationWebSite.HtmlGeneration_Home.OrderUsingHtmlHelpers.html
View File

@ -4,7 +4,8 @@
<title></title> <title></title>
</head> </head>
<body> <body>
<form action="/HtmlGeneration_Order/Submit" method="post"> <div> <form action="/HtmlGeneration_Order/Submit" method="post">
<div>
<label class="order" for="Shipping">Shipping</label> <label class="order" for="Shipping">Shipping</label>
<input id="Shipping" name="Shipping" size="50" type="text" value="Your shipping method is UPSP" /> <input id="Shipping" name="Shipping" size="50" type="text" value="Your shipping method is UPSP" />
</div> </div>
@ -74,6 +75,8 @@
</div> </div>
<div class="validation-summary-valid order" data-valmsg-summary="true"><ul><li style="display:none"></li> <div class="validation-summary-valid order" data-valmsg-summary="true"><ul><li style="display:none"></li>
</ul></div> </ul></div>
<input id="Customer_Key" name="Customer.Key" type="hidden" value="KeyA" /> <input type="submit"/> <input id="Customer_Key" name="Customer.Key" type="hidden" value="KeyA" />
<input name="__RequestVerificationToken" type="hidden" value="{0}" /><input name="NeedSpecialHandle" type="hidden" value="false" /></form></body> <input type="submit"/>
<input name="__RequestVerificationToken" type="hidden" value="{0}" /><input name="NeedSpecialHandle" type="hidden" value="false" /></form>
</body>
</html> </html>

18
test/WebSites/HtmlGenerationWebSite/Views/HtmlGeneration_Home/OrderUsingHtmlHelpers.cshtml
View File

@ -11,9 +11,9 @@
<title></title> <title></title>
</head> </head>
<body> <body>
@* Use comments and <text/> elements to force whitespace in generated HTML. *@@using ( @* Use <text/> element to force whitespace in generated HTML. *@
Html.BeginForm(actionName: "Submit", controllerName: "HtmlGeneration_Order")) @using (Html.BeginForm(actionName: "Submit", controllerName: "HtmlGeneration_Order"))
{<text></text> {<text>
<div> <div>
@Html.LabelFor(m => m.Shipping, htmlAttributes: new { @class = "order" }) @Html.LabelFor(m => m.Shipping, htmlAttributes: new { @class = "order" })
@Html.TextBoxFor(m => m.Shipping, format: "Your shipping method is {0}", htmlAttributes: new { size = "50" }) @Html.TextBoxFor(m => m.Shipping, format: "Your shipping method is {0}", htmlAttributes: new { size = "50" })
@ -74,11 +74,11 @@ Html.BeginForm(actionName: "Submit", controllerName: "HtmlGeneration_Order"))
@Html.LabelFor(m => m.Customer.Gender, htmlAttributes: new { @class = "order" }) @Html.LabelFor(m => m.Customer.Gender, htmlAttributes: new { @class = "order" })
@Html.EditorFor(model => model.Customer.Gender, templateName: "GenderUsingHtmlHelpers") @Html.EditorFor(model => model.Customer.Gender, templateName: "GenderUsingHtmlHelpers")
@Html.ValidationMessageFor(m => m.Customer.Gender) @Html.ValidationMessageFor(m => m.Customer.Gender)
</div><text> </div>
</text>@Html.ValidationSummary(message: null, htmlAttributes: new { @class = "order" })<text> @Html.ValidationSummary(message: null, htmlAttributes: new { @class = "order" })
</text>@Html.HiddenFor(m => m.Customer.Key)<text></text> @Html.HiddenFor(m => m.Customer.Key)
<input type="submit"/><text> <input type="submit"/>
</text>@Html.AntiForgeryToken(); </text>}
}@**@
</body> </body>
</html> </html>