From f05b0e792d2361be214947798857ef3eac77825d Mon Sep 17 00:00:00 2001
From: Pranav K <prkrishn@hotmail.com>
Date: Thu, 8 Nov 2018 11:28:52 -0800
Subject: [PATCH] Add some logging for functional tests

---
 .../CorsMiddlewareFunctionalTest.cs               |  2 +-
 test/FunctionalTests/ProcessManager.cs            |  8 ++++++--
 test/FunctionalTests/test.js                      | 15 ++++++++++-----
 3 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/test/FunctionalTests/CorsMiddlewareFunctionalTest.cs b/test/FunctionalTests/CorsMiddlewareFunctionalTest.cs
index 7c61d1f77b..ebeebb2d74 100644
--- a/test/FunctionalTests/CorsMiddlewareFunctionalTest.cs
+++ b/test/FunctionalTests/CorsMiddlewareFunctionalTest.cs
@@ -50,7 +50,7 @@ namespace FunctionalTests
                 }
 
                 // Act
-                var result = await ProcessManager.RunProcessAsync(processStartInfo);
+                var result = await ProcessManager.RunProcessAsync(processStartInfo, loggerFactory.CreateLogger("ProcessManager"));
 
                 // Assert
                 Assert.Success(result);
diff --git a/test/FunctionalTests/ProcessManager.cs b/test/FunctionalTests/ProcessManager.cs
index 77bebe26c8..40091810d0 100644
--- a/test/FunctionalTests/ProcessManager.cs
+++ b/test/FunctionalTests/ProcessManager.cs
@@ -6,6 +6,7 @@ using System.Diagnostics;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
 
 namespace FunctionalTests
 {
@@ -13,7 +14,7 @@ namespace FunctionalTests
     {
         private static readonly TimeSpan Timeout = TimeSpan.FromMinutes(3);
 
-        public static Task<ProcessResult> RunProcessAsync(ProcessStartInfo processStartInfo)
+        public static Task<ProcessResult> RunProcessAsync(ProcessStartInfo processStartInfo, ILogger logger)
         {
             processStartInfo.UseShellExecute = false;
             processStartInfo.RedirectStandardError = true;
@@ -31,6 +32,7 @@ namespace FunctionalTests
             process.ErrorDataReceived += Process_ErrorDataReceived;
             process.OutputDataReceived += Process_OutputDataReceived;
 
+            logger.LogInformation($"Executing command '{process.StartInfo.FileName} {process.StartInfo.Arguments}'");
             process.Start();
             process.BeginErrorReadLine();
             process.BeginOutputReadLine();
@@ -52,7 +54,7 @@ namespace FunctionalTests
 
                 // This is a timeout.
                 process.Kill();
-                throw new TimeoutException($"command '${process.StartInfo.FileName} {process.StartInfo.Arguments}' timed out after {Timeout}.");
+                throw new TimeoutException($"command '{process.StartInfo.FileName} {process.StartInfo.Arguments}' timed out after {Timeout}.");
             });
 
             var waitTask = Task.Run(() =>
@@ -83,6 +85,7 @@ namespace FunctionalTests
 
             void Process_ErrorDataReceived(object sender, DataReceivedEventArgs e)
             {
+                logger.LogInformation(e.Data);
                 lock (outputLock)
                 {
                     output.AppendLine(e.Data);
@@ -91,6 +94,7 @@ namespace FunctionalTests
 
             void Process_OutputDataReceived(object sender, DataReceivedEventArgs e)
             {
+                logger.LogInformation(e.Data);
                 lock (outputLock)
                 {
                     output.AppendLine(e.Data);
diff --git a/test/FunctionalTests/test.js b/test/FunctionalTests/test.js
index c39ffeaa6b..f994029bf2 100644
--- a/test/FunctionalTests/test.js
+++ b/test/FunctionalTests/test.js
@@ -16,12 +16,17 @@ beforeAll(async () => {
     const options = debug ?
         { headless: false, slowMo: 100 } :
         { args: ['--no-sandbox'] };
+    const label = 'Launch puppeteer ';
 
-        try {
-            browser = await puppeteer.launch(options);
-        } catch (ex) {
-            error = ex;
-        }
+    console.log('Begin launching puppeteer');
+    console.time(label);
+
+    try {
+        browser = await puppeteer.launch(options);
+    } catch (ex) {
+        error = ex;
+    }
+    console.timeEnd(label);
 });
 
 afterAll(async () => {