From efd38a6dd132d82765132af6412684c12aab2790 Mon Sep 17 00:00:00 2001 From: Doug Bunting Date: Sat, 30 Jan 2016 00:02:36 -0800 Subject: [PATCH] Revert "Move aspnet/External#18 comments into `SkipReason`" This reverts commit 5a0fb8551bd673f3e72e479c459c9cc243e31f0e. --- ...ataContractSerializerInputFormatterTest.cs | 42 +++++++++----- ...taContractSerializerOutputFormatterTest.cs | 58 ++++++++++++------- .../ApiExplorerTest.cs | 6 +- .../ConsumesAttributeTests.cs | 4 +- .../ContentNegotiationTest.cs | 6 +- .../InputFormatterTests.cs | 3 +- .../InputObjectValidationTests.cs | 3 +- .../JsonOutputFormatterTests.cs | 3 +- .../RespectBrowserAcceptHeaderTests.cs | 9 ++- .../SerializableErrorTests.cs | 14 +++-- ...ontractSerializerFormattersWrappingTest.cs | 24 +++++--- ...ataContractSerializerInputFormatterTest.cs | 9 ++- .../XmlOutputFormatterTests.cs | 3 +- 13 files changed, 122 insertions(+), 62 deletions(-) diff --git a/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerInputFormatterTest.cs b/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerInputFormatterTest.cs index 2c10ba7b09..4673dc3ec9 100644 --- a/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerInputFormatterTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerInputFormatterTest.cs @@ -54,7 +54,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("application/xml", true)] [InlineData("application/*", false)] [InlineData("*/*", false)] @@ -90,7 +91,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public void XmlDataContractSerializer_CachesSerializerForType() { // Arrange @@ -135,7 +137,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_ReadsSimpleTypes() { // Arrange @@ -163,7 +166,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_ReadsComplexTypes() { // Arrange @@ -194,7 +198,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_ReadsWhenMaxDepthIsModified() { // Arrange @@ -269,7 +274,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_VerifyStreamIsOpenAfterRead() { // Arrange @@ -290,7 +296,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_FallsbackToUTF8_WhenCharSet_NotInContentType() { // Arrange @@ -318,7 +325,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_UsesContentTypeCharSet_ToReadStream() { // Arrange @@ -350,7 +358,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_IgnoresBOMCharacters() { // Arrange @@ -383,7 +392,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_AcceptsUTF16Characters() { // Arrange @@ -422,7 +432,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_ThrowsWhenNotConfiguredWithRootName() { // Arrange @@ -442,7 +453,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_ReadsWhenConfiguredWithRootName() { // Arrange @@ -480,7 +492,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_ThrowsWhenNotConfiguredWithKnownTypes() { // Arrange @@ -501,7 +514,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ReadAsync_ReadsWhenConfiguredWithKnownTypes() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs b/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs index 40323a28cb..ba9de64a2a 100644 --- a/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.Formatters.Xml.Test/XmlDataContractSerializerOutputFormatterTest.cs @@ -94,7 +94,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [MemberData(nameof(BasicTypeValues))] public async Task WriteAsync_CanWriteBasicTypes(object input, string expectedOutput) { @@ -114,7 +115,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public void XmlDataContractSerializer_CachesSerializerForType() { // Arrange @@ -133,7 +135,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public void DefaultConstructor_ExpectedWriterSettings_Created() { // Arrange and Act @@ -148,7 +151,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task SuppliedWriterSettings_TakeAffect() { // Arrange @@ -175,7 +179,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesSimpleTypes() { // Arrange @@ -199,7 +204,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesComplexTypes() { // Arrange @@ -233,7 +239,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesOnModifiedWriterSettings() { // Arrange @@ -263,7 +270,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesUTF16Output() { // Arrange @@ -292,7 +300,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesIndentedOutput() { // Arrange @@ -317,7 +326,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_VerifyBodyIsNotClosedAfterOutputIsWritten() { // Arrange @@ -334,7 +344,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_DoesntFlushOutputStream() { // Arrange @@ -364,7 +375,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [MemberData(nameof(TypesForCanWriteResult))] public void CanWriteResult_ReturnsExpectedOutput(object input, Type declaredType, bool expectedOutput) { @@ -391,7 +403,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [MemberData(nameof(TypesForGetSupportedContentTypes))] public void GetSupportedContentTypes_ReturnsSupportedTypes(Type type, object expectedOutput) { @@ -415,10 +428,11 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } #if !DNXCORE50 - [ConditionalFact] // DataContractSerializer in CoreCLR does not throw if the declared type is different from the type being - // serialized. Is this the same issue as aspnet/External#18??? - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // serialized. + [ConditionalFact] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_ThrowsWhenNotConfiguredWithKnownTypes() { // Arrange @@ -453,7 +467,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml #endif [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_ThrowsWhenNotConfiguredWithPreserveReferences() { // Arrange @@ -470,7 +485,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesWhenConfiguredWithRootName() { // Arrange @@ -512,7 +528,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesWhenConfiguredWithKnownTypes() { // Arrange @@ -557,7 +574,8 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Xml } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task WriteAsync_WritesWhenConfiguredWithPreserveReferences() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ApiExplorerTest.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ApiExplorerTest.cs index 7711051f3a..e121481499 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ApiExplorerTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ApiExplorerTest.cs @@ -487,7 +487,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ApiExplorer_ResponseContentType_Unset() { // Arrange & Act @@ -552,7 +553,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("Controller", "text/xml", "Microsoft.AspNetCore.Mvc.Formatters.XmlDataContractSerializerOutputFormatter")] [InlineData("Action", "application/json", "Microsoft.AspNetCore.Mvc.Formatters.JsonOutputFormatter")] public async Task ApiExplorer_ResponseContentType_OverrideOnAction( diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ConsumesAttributeTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ConsumesAttributeTests.cs index 8c04ff7ad3..18e162e3d6 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ConsumesAttributeTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ConsumesAttributeTests.cs @@ -6,6 +6,7 @@ using System.Net.Http; using System.Text; using System.Threading.Tasks; using BasicWebSite.Models; +using Microsoft.AspNetCore.Mvc.Infrastructure; using Microsoft.AspNetCore.Testing.xunit; using Newtonsoft.Json; using Xunit; @@ -99,7 +100,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task DerivedClassLevelAttribute_OveridesBaseClassLevel() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ContentNegotiationTest.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ContentNegotiationTest.cs index 5688a17712..f03bd99478 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ContentNegotiationTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/ContentNegotiationTest.cs @@ -107,7 +107,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ProducesAttribute_WithTypeAndContentType_UsesContentType() { // Arrange @@ -298,7 +299,8 @@ END:VCARD } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task XmlFormatter_SupportedMediaType_DoesNotChangeAcrossRequests() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputFormatterTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputFormatterTests.cs index d6980e556f..eb56bc0298 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputFormatterTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputFormatterTests.cs @@ -22,7 +22,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests public HttpClient Client { get; } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task CheckIfXmlInputFormatterIsBeingCalled() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputObjectValidationTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputObjectValidationTests.cs index d563b2cc2e..42e99ec106 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputObjectValidationTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/InputObjectValidationTests.cs @@ -46,7 +46,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task CheckIfObjectIsDeserializedWithoutErrors() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/JsonOutputFormatterTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/JsonOutputFormatterTests.cs index 4842090b97..2d17bd5365 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/JsonOutputFormatterTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/JsonOutputFormatterTests.cs @@ -48,7 +48,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task SerializableErrorIsReturnedInExpectedFormat() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RespectBrowserAcceptHeaderTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RespectBrowserAcceptHeaderTests.cs index 6390426326..147b131524 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RespectBrowserAcceptHeaderTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/RespectBrowserAcceptHeaderTests.cs @@ -41,7 +41,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("application/xml,*/*;q=0.2")] [InlineData("application/xml,*/*")] public async Task AllMediaRangeAcceptHeader_ProducesAttributeIsHonored(string acceptHeader) @@ -68,7 +69,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("application/xml,*/*;q=0.2")] [InlineData("application/xml,*/*")] public async Task AllMediaRangeAcceptHeader_WithContentTypeHeader_ContentTypeIsIgnored(string acceptHeader) @@ -99,7 +101,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("application/xml,application/json;q=0.2")] [InlineData("application/xml,application/json")] public async Task AllMediaRangeAcceptHeader_WithExactMatch_ReturnsExpectedContent(string acceptHeader) diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs index d277704f93..6c86fd75dd 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/SerializableErrorTests.cs @@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests "application/xml-xmlser" }; - // Avoid aspnet/External#18, a DCS issue on Mono. + // Mono issue - https://github.com/aspnet/External/issues/18 if (!TestPlatformHelper.IsMono) { data.Add("application/xml-dcs"); @@ -63,8 +63,10 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - // Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. Is this the same bug as aspnet/External#18??? - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + // XmlSerializer test is disabled Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. + // This is fixed in mono 4.3.0. + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("application/xml-xmlser")] [InlineData("application/xml-dcs")] public async Task PostedSerializableError_IsBound(string acceptHeader) @@ -88,8 +90,10 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - // Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. Is this the same bug as aspnet/External#18??? - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + // XmlSerializer test is disabled Mono.Xml2.XmlTextReader.ReadText is unable to read the XML. + // This is fixed in mono 4.3.0. + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("application/xml-xmlser")] [InlineData("application/xml-dcs")] public async Task IsReturnedInExpectedFormat(string acceptHeader) diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerFormattersWrappingTest.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerFormattersWrappingTest.cs index 4656d5c3b0..5bd38a326c 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerFormattersWrappingTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerFormattersWrappingTest.cs @@ -21,7 +21,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests public HttpClient Client { get; } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("http://localhost/IEnumerable/ValueTypes")] [InlineData("http://localhost/IQueryable/ValueTypes")] public async Task CanWrite_ValueTypes(string url) @@ -44,7 +45,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("http://localhost/IEnumerable/NonWrappedTypes")] [InlineData("http://localhost/IQueryable/NonWrappedTypes")] public async Task CanWrite_NonWrappedTypes(string url) @@ -67,7 +69,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("http://localhost/IEnumerable/NonWrappedTypes_Empty")] [InlineData("http://localhost/IQueryable/NonWrappedTypes_Empty")] public async Task CanWrite_NonWrappedTypes_Empty(string url) @@ -89,7 +92,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("http://localhost/IEnumerable/NonWrappedTypes_NullInstance")] [InlineData("http://localhost/IQueryable/NonWrappedTypes_NullInstance")] public async Task CanWrite_NonWrappedTypes_NullInstance(string url) @@ -111,7 +115,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("http://localhost/IEnumerable/WrappedTypes")] [InlineData("http://localhost/IQueryable/WrappedTypes")] public async Task CanWrite_WrappedTypes(string url) @@ -135,7 +140,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("http://localhost/IEnumerable/WrappedTypes_Empty")] [InlineData("http://localhost/IQueryable/WrappedTypes_Empty")] public async Task CanWrite_WrappedTypes_Empty(string url) @@ -157,7 +163,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalTheory] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] [InlineData("http://localhost/IEnumerable/WrappedTypes_NullInstance")] [InlineData("http://localhost/IQueryable/WrappedTypes_NullInstance")] public async Task CanWrite_WrappedTypes_NullInstance(string url) @@ -179,7 +186,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task CanWrite_IEnumerableOf_SerializableErrors() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerInputFormatterTest.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerInputFormatterTest.cs index e03578f4cd..eec000aabf 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerInputFormatterTest.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlDataContractSerializerInputFormatterTest.cs @@ -35,7 +35,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests public HttpClient Client { get; } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task ThrowsOnInvalidInput_AndAddsToModelState() { // Arrange @@ -56,7 +57,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task RequiredDataIsProvided_AndModelIsBound_NoValidationErrors() { // Arrange @@ -85,7 +87,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests // Verifies that the model state has errors related to body model validation. [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mon, SkipReason = "aspnet/External#18, DCS issue on Mono"o)] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task DataMissingForRefereneceTypeProperties_AndModelIsBound_AndHasMixedValidationErrors() { // Arrange diff --git a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlOutputFormatterTests.cs b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlOutputFormatterTests.cs index 4e5a25a96f..cc9e8eb5be 100644 --- a/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlOutputFormatterTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.FunctionalTests/XmlOutputFormatterTests.cs @@ -64,7 +64,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests } [ConditionalFact] - [FrameworkSkipCondition(RuntimeFrameworks.Mono, SkipReason = "aspnet/External#18, DCS issue on Mono")] + // Mono issue - https://github.com/aspnet/External/issues/18 + [FrameworkSkipCondition(RuntimeFrameworks.Mono)] public async Task XmlSerializerFailsAndDataContractSerializerIsCalled() { // Arrange