huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove usage of `async void` in unit tests 

Yes I know xUnit supports it, but it's non-standard and it shouldn't show
up anywhere in our codebase.
This commit is contained in:
Ryan Nowak 2016-05-20 15:07:48 -07:00
parent 230a13d0e1
commit ef29749e72
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/Microsoft.AspNetCore.Mvc.Core.Test/Internal/ObjectMethodExecutorTest.cs
View File

@ -70,7 +70,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Fact] [Fact]
public async void ExecuteValueMethodAsync() public async Task ExecuteValueMethodAsync()
{ {
var executor = GetExecutorForMethod("ValueMethodAsync"); var executor = GetExecutorForMethod("ValueMethodAsync");
var result = await executor.ExecuteAsync( var result = await executor.ExecuteAsync(
@ -80,7 +80,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Fact] [Fact]
public async void ExecuteValueMethodWithReturnTypeAsync() public async Task ExecuteValueMethodWithReturnTypeAsync()
{ {
var executor = GetExecutorForMethod("ValueMethodWithReturnTypeAsync"); var executor = GetExecutorForMethod("ValueMethodWithReturnTypeAsync");
var result = await executor.ExecuteAsync( var result = await executor.ExecuteAsync(
@ -91,7 +91,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Fact] [Fact]
public async void ExecuteValueMethodUpdateValueAsync() public async Task ExecuteValueMethodUpdateValueAsync()
{ {
var executor = GetExecutorForMethod("ValueMethodUpdateValueAsync"); var executor = GetExecutorForMethod("ValueMethodUpdateValueAsync");
var parameter = new TestObject(); var parameter = new TestObject();
@ -103,7 +103,7 @@ namespace Microsoft.AspNetCore.Mvc.Internal
} }
[Fact] [Fact]
public async void ExecuteValueMethodWithReturnTypeThrowsExceptionAsync() public async Task ExecuteValueMethodWithReturnTypeThrowsExceptionAsync()
{ {
var executor = GetExecutorForMethod("ValueMethodWithReturnTypeThrowsExceptionAsync"); var executor = GetExecutorForMethod("ValueMethodWithReturnTypeThrowsExceptionAsync");
var parameter = new TestObject(); var parameter = new TestObject();

2
test/Microsoft.AspNetCore.Mvc.Core.Test/RedirectToActionResultTest.cs
View File

@ -19,7 +19,7 @@ namespace Microsoft.AspNetCore.Mvc
public class RedirectToActionResultTest public class RedirectToActionResultTest
{ {
[Fact] [Fact]
public async void RedirectToAction_Execute_PassesCorrectValuesToRedirect() public async Task RedirectToAction_Execute_PassesCorrectValuesToRedirect()
{ {
// Arrange // Arrange
var expectedUrl = "SampleAction"; var expectedUrl = "SampleAction";

2
test/Microsoft.AspNetCore.Mvc.Core.Test/RedirectToRouteResultTest.cs
View File

@ -22,7 +22,7 @@ namespace Microsoft.AspNetCore.Mvc
{ {
[Theory] [Theory]
[MemberData(nameof(RedirectToRouteData))] [MemberData(nameof(RedirectToRouteData))]
public async void RedirectToRoute_Execute_PassesCorrectValuesToRedirect(object values) public async Task RedirectToRoute_Execute_PassesCorrectValuesToRedirect(object values)
{ {
// Arrange // Arrange
var expectedUrl = "SampleAction"; var expectedUrl = "SampleAction";