From edf5abed265993690492dd2530fa731259caacfb Mon Sep 17 00:00:00 2001 From: Ryan Nowak Date: Mon, 1 Jul 2019 17:43:30 -0700 Subject: [PATCH] Remove unwanted EventCallbackFactory overload --- ...soft.AspNetCore.Components.netstandard2.0.cs | 2 -- .../Components/src/EventCallbackFactory.cs | 17 ----------------- .../Components/test/EventCallbackFactoryTest.cs | 14 -------------- 3 files changed, 33 deletions(-) diff --git a/src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs b/src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs index aeb2ea8b73..99aa532c10 100644 --- a/src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs +++ b/src/Components/Components/ref/Microsoft.AspNetCore.Components.netstandard2.0.cs @@ -143,8 +143,6 @@ namespace Microsoft.AspNetCore.Components public Microsoft.AspNetCore.Components.EventCallback Create(object receiver, System.Action callback) { throw null; } public Microsoft.AspNetCore.Components.EventCallback Create(object receiver, System.Func callback) { throw null; } public Microsoft.AspNetCore.Components.EventCallback Create(object receiver, System.Func callback) { throw null; } - [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)] - public string Create(object receiver, string callback) { throw null; } } public static partial class EventCallbackFactoryBinderExtensions { diff --git a/src/Components/Components/src/EventCallbackFactory.cs b/src/Components/Components/src/EventCallbackFactory.cs index a93b897ab5..a920d2277d 100644 --- a/src/Components/Components/src/EventCallbackFactory.cs +++ b/src/Components/Components/src/EventCallbackFactory.cs @@ -98,23 +98,6 @@ namespace Microsoft.AspNetCore.Components return CreateCore(receiver, callback); } - /// - /// Returns the provided . For internal framework use only. - /// - /// - /// - /// - [EditorBrowsable(EditorBrowsableState.Never)] - public string Create(object receiver, string callback) - { - if (receiver == null) - { - throw new ArgumentNullException(nameof(receiver)); - } - - return callback; - } - /// /// Returns the provided . For internal framework use only. /// diff --git a/src/Components/Components/test/EventCallbackFactoryTest.cs b/src/Components/Components/test/EventCallbackFactoryTest.cs index e88e74badd..714c73c656 100644 --- a/src/Components/Components/test/EventCallbackFactoryTest.cs +++ b/src/Components/Components/test/EventCallbackFactoryTest.cs @@ -296,20 +296,6 @@ namespace Microsoft.AspNetCore.Components Assert.True(callback.RequiresExplicitReceiver); } - [Fact] - public void CreateT_String_ReturnsInput() - { - // Arrange - var component = new EventComponent(); - var input = "some_js"; - - // Act - var callback = EventCallback.Factory.Create(component, input); - - // Assert - Assert.Same(input, callback); - } - [Fact] public void CreateT_EventCallback_ReturnsInput() {