huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove the temporary fix where HttpClient was not sending cookies more than a certain length

This commit is contained in:
Kiran Challa 2016-03-31 12:01:30 -07:00
parent 8e38221bf8
commit ed7d5eb5e7
1 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
test/E2ETests/Implementation/Validator.cs
View File

@ -45,7 +45,6 @@ namespace E2ETests
_logger.LogInformation("GET {0}", uri.ToString()); _logger.LogInformation("GET {0}", uri.ToString());
var resp= await _httpClient.GetAsync(uri); var resp= await _httpClient.GetAsync(uri);
LogHeaders(resp, LogLevel.Information); LogHeaders(resp, LogLevel.Information);
SaveCookies(resp);
return resp; return resp;
} }
@ -57,7 +56,6 @@ namespace E2ETests
_logger.LogInformation("POST {0}", uri.ToString()); _logger.LogInformation("POST {0}", uri.ToString());
var resp= await _httpClient.PostAsync(uri, content); var resp= await _httpClient.PostAsync(uri, content);
LogHeaders(resp, LogLevel.Information); LogHeaders(resp, LogLevel.Information);
SaveCookies(resp);
return resp; return resp;
} }
private void LogHeaders(HttpResponseMessage response, LogLevel logLevel) private void LogHeaders(HttpResponseMessage response, LogLevel logLevel)
@ -75,35 +73,6 @@ namespace E2ETests
formatter: (o, e) => o.ToString()); formatter: (o, e) => o.ToString());
} }
// TODO https://github.com/dotnet/corefx/issues/6737
private void SaveCookies(HttpResponseMessage response)
{
if (!_httpClientHandler.UseCookies)
{
return;
}
foreach (var cookieString in response.Headers
.Where(k => k.Key.Equals("Set-Cookie", StringComparison.OrdinalIgnoreCase))
.SelectMany(k => k.Value))
{
try
{
var helper = new CookieContainer();
helper.SetCookies(response.RequestMessage.RequestUri, cookieString);
foreach (Cookie cookie in helper.GetCookies(response.RequestMessage.RequestUri))
{
_httpClientHandler.CookieContainer.Add(response.RequestMessage.RequestUri, cookie);
}
}
catch
{
//bad cookie
_logger.LogInformation("Received bad cookie string: {0}", cookieString);
}
}
}
public async Task VerifyHomePage( public async Task VerifyHomePage(
HttpResponseMessage response, HttpResponseMessage response,
bool useNtlmAuthentication = false) bool useNtlmAuthentication = false)