From ecd468b16607b9c33685c668cf124b994c194d66 Mon Sep 17 00:00:00 2001 From: "N. Taylor Mullen" Date: Fri, 6 Mar 2015 16:21:25 -0800 Subject: [PATCH] Remove second public ctor from TagHelperDescriptor. - TagHelperDescriptors are serialized/deserialized regularly, they can't have more than 1 ctor. --- .../TagHelpers/TagHelperDescriptorFactory.cs | 10 ++++++---- .../TagHelpers/TagHelperDescriptor.cs | 12 ++---------- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs index 0beb8d9955..600427cf58 100644 --- a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs +++ b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs @@ -41,10 +41,12 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers var attributeDescriptors = GetAttributeDescriptors(type); return tagNames.Select(tagName => - new TagHelperDescriptor(tagName, - typeName, - assemblyName, - attributeDescriptors)); + new TagHelperDescriptor( + prefix: string.Empty, + tagName: tagName, + typeName: typeName, + assemblyName: assemblyName, + attributes: attributeDescriptors)); } private static IEnumerable GetTagNames(Type tagHelperType) diff --git a/src/Microsoft.AspNet.Razor/TagHelpers/TagHelperDescriptor.cs b/src/Microsoft.AspNet.Razor/TagHelpers/TagHelperDescriptor.cs index ce9133081c..57f4fdb6d3 100644 --- a/src/Microsoft.AspNet.Razor/TagHelpers/TagHelperDescriptor.cs +++ b/src/Microsoft.AspNet.Razor/TagHelpers/TagHelperDescriptor.cs @@ -26,17 +26,9 @@ namespace Microsoft.AspNet.Razor.TagHelpers } /// - /// Instantiates a new instance of the class with the given - /// . + /// Internal for testing. /// - /// The tag name that the tag helper targets. '*' indicates a catch-all - /// which applies to every HTML tag. - /// The full name of the tag helper class. - /// The name of the assembly containing the tag helper class. - /// - /// The s to request from the HTML tag. - /// - public TagHelperDescriptor( + internal TagHelperDescriptor( [NotNull] string tagName, [NotNull] string typeName, [NotNull] string assemblyName,