Fix build break
We didn't have a test for the case where RazorCompileOnPublish is false and Publish is being called. This is breaking the precompilation repo.
This commit is contained in:
parent
d1cfc51c9d
commit
eaa201703d
|
|
@ -162,14 +162,15 @@
|
||||||
</Target>
|
</Target>
|
||||||
|
|
||||||
<!--
|
<!--
|
||||||
This target is called after PrepareForPublish when RazorCompileOnBuild=true so that we can hook into publish.
|
This target is called after PrepareForPublish when RazorCompileOnPublish=true so that we can hook into publish.
|
||||||
This target just hooks up other targets since Publish and PrepareForPublish don't have a DependsOnTargets
|
This target just hooks up other targets since Publish and PrepareForPublish don't have a DependsOnTargets
|
||||||
property we can use.
|
property we can use.
|
||||||
-->
|
-->
|
||||||
<Target
|
<Target
|
||||||
Name="_RazorPrepareForPublish"
|
Name="_RazorPrepareForPublish"
|
||||||
AfterTargets="PrepareForPublish"
|
AfterTargets="PrepareForPublish"
|
||||||
DependsOnTargets="RazorCompile">
|
DependsOnTargets="RazorCompile"
|
||||||
|
Condition="'$(RazorCompileOnPublish)'=='true'">
|
||||||
</Target>
|
</Target>
|
||||||
|
|
||||||
<!--
|
<!--
|
||||||
|
|
|
||||||
|
|
@ -91,6 +91,23 @@ namespace Microsoft.AspNetCore.Razor.Design.IntegrationTests
|
||||||
Assert.FileDoesNotExist(result, PublishOutputPath, "SimpleMvc.PrecompiledViews.pdb");
|
Assert.FileDoesNotExist(result, PublishOutputPath, "SimpleMvc.PrecompiledViews.pdb");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
[InitializeTestProject("SimpleMvc")]
|
||||||
|
public async Task Publish_NoopsWith_RazorCompileOnPublishFalse()
|
||||||
|
{
|
||||||
|
Directory.Delete(Path.Combine(Project.DirectoryPath, "Views"), recursive: true);
|
||||||
|
|
||||||
|
var result = await DotnetMSBuild("Publish", "/p:RazorCompileOnPublish=false");
|
||||||
|
|
||||||
|
Assert.BuildPassed(result);
|
||||||
|
|
||||||
|
// Everything we do should noop - including building the app.
|
||||||
|
Assert.FileExists(result, PublishOutputPath, "SimpleMvc.dll");
|
||||||
|
Assert.FileExists(result, PublishOutputPath, "SimpleMvc.pdb");
|
||||||
|
Assert.FileDoesNotExist(result, PublishOutputPath, "SimpleMvc.PrecompiledViews.dll");
|
||||||
|
Assert.FileDoesNotExist(result, PublishOutputPath, "SimpleMvc.PrecompiledViews.pdb");
|
||||||
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
[InitializeTestProject("SimpleMvc")]
|
[InitializeTestProject("SimpleMvc")]
|
||||||
public async Task Publish_SkipsCopyingBinariesToOutputDirectory_IfCopyBuildOutputToOutputDirectory_IsUnset()
|
public async Task Publish_SkipsCopyingBinariesToOutputDirectory_IfCopyBuildOutputToOutputDirectory_IsUnset()
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue