From e8fba43b1ffc2619196d18eeb241d2e5e02044de Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Tue, 25 Jun 2019 20:43:07 -0700 Subject: [PATCH] Move to 3.0 Preview 6 SDK (#11472) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Work around https://github.com/dotnet/cli/issues/11378 * Fix site extensions - thanks @JunTaoLuo❕ --- eng/Workarounds.targets | 7 ++++++- eng/targets/ReferenceAssembly.targets | 4 ---- global.json | 4 ++-- src/SiteExtensions/build.cmd | 7 ++++--- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/eng/Workarounds.targets b/eng/Workarounds.targets index b22f887bf5..029cbbc390 100644 --- a/eng/Workarounds.targets +++ b/eng/Workarounds.targets @@ -31,7 +31,6 @@ false - @@ -58,4 +57,10 @@ + + + + + + diff --git a/eng/targets/ReferenceAssembly.targets b/eng/targets/ReferenceAssembly.targets index dccc945227..bb6230e633 100644 --- a/eng/targets/ReferenceAssembly.targets +++ b/eng/targets/ReferenceAssembly.targets @@ -76,10 +76,6 @@ - $(MSBuildThisFileDirectory)..\eng\ProjectReferences.props - $(TargetFrameworks) - $(TargetFramework) - diff --git a/global.json b/global.json index 6828849fa2..3755502123 100644 --- a/global.json +++ b/global.json @@ -1,9 +1,9 @@ { "sdk": { - "version": "3.0.100-preview5-011568" + "version": "3.0.100-preview6-012264" }, "tools": { - "dotnet": "3.0.100-preview5-011568", + "dotnet": "3.0.100-preview6-012264", "runtimes": { "dotnet/x64": [ "$(MicrosoftNETCoreAppRuntimeVersion)" diff --git a/src/SiteExtensions/build.cmd b/src/SiteExtensions/build.cmd index b8b980af6f..af51ba3dd6 100644 --- a/src/SiteExtensions/build.cmd +++ b/src/SiteExtensions/build.cmd @@ -10,8 +10,9 @@ IF %ERRORLEVEL% NEQ 0 ( ) ECHO Building LoggingBranch -CALL %RepoRoot%\build.cmd -forceCoreMsbuild -arch x64 -projects %~dp0LoggingBranch\LB.csproj /bl:artifacts/log/SiteExtensions-LoggingBranch-x64.binlog %* -CALL %RepoRoot%\build.cmd -forceCoreMsbuild -arch x86 -projects %~dp0LoggingBranch\LB.csproj /bl:artifacts/log/SiteExtensions-LoggingBranch-x86.binlog %* +REM Remove /p:DisablePackageAssetsCache=true /p:DisableTransitiveFrameworkReferences=true which workarounds dotnet store and publish behaviour changes in preview 6 +CALL %RepoRoot%\build.cmd -forceCoreMsbuild -arch x64 -projects %~dp0LoggingBranch\LB.csproj /p:DisablePackageAssetsCache=true /p:DisableTransitiveFrameworkReferences=true /bl:artifacts/log/SiteExtensions-LoggingBranch-x64.binlog %* +CALL %RepoRoot%\build.cmd -forceCoreMsbuild -arch x86 -projects %~dp0LoggingBranch\LB.csproj /p:DisablePackageAssetsCache=true /p:DisableTransitiveFrameworkReferences=true /bl:artifacts/log/SiteExtensions-LoggingBranch-x86.binlog %* IF %ERRORLEVEL% NEQ 0 ( EXIT /b %ErrorLevel% @@ -24,4 +25,4 @@ IF %ERRORLEVEL% NEQ 0 ( EXIT /b %ErrorLevel% ) -ECHO SiteExtensions successly built! +ECHO SiteExtensions successfully built!