diff --git a/samples/IdentitySample.Mvc/Models/SampleData.cs b/samples/IdentitySample.Mvc/Models/SampleData.cs index d96cf66945..46d4feb316 100644 --- a/samples/IdentitySample.Mvc/Models/SampleData.cs +++ b/samples/IdentitySample.Mvc/Models/SampleData.cs @@ -12,7 +12,7 @@ namespace IdentitySample.Models { public static async Task InitializeIdentityDatabaseAsync(IServiceProvider serviceProvider) { - using (var db = serviceProvider.GetService()) + using (var db = serviceProvider.GetRequiredService()) { var sqlServerDataStore = db.Configuration.DataStore as SqlServerDataStore; if (sqlServerDataStore != null) @@ -36,11 +36,11 @@ namespace IdentitySample.Models /// private static async Task CreateAdminUser(IServiceProvider serviceProvider) { - var options = serviceProvider.GetService>().Options; + var options = serviceProvider.GetRequiredService>().Options; const string adminRole = "Administrator"; - var userManager = serviceProvider.GetService>(); - var roleManager = serviceProvider.GetService>(); + var userManager = serviceProvider.GetRequiredService>(); + var roleManager = serviceProvider.GetRequiredService>(); if (!await roleManager.RoleExistsAsync(adminRole)) { await roleManager.CreateAsync(new IdentityRole(adminRole)); diff --git a/src/Microsoft.AspNet.Identity/SecurityStampValidator.cs b/src/Microsoft.AspNet.Identity/SecurityStampValidator.cs index 9fc9d16af9..755afcf4c2 100644 --- a/src/Microsoft.AspNet.Identity/SecurityStampValidator.cs +++ b/src/Microsoft.AspNet.Identity/SecurityStampValidator.cs @@ -20,7 +20,7 @@ namespace Microsoft.AspNet.Identity /// public virtual async Task Validate(CookieValidateIdentityContext context, ClaimsIdentity identity) { - var manager = context.HttpContext.RequestServices.GetService>(); + var manager = context.HttpContext.RequestServices.GetRequiredService>(); var userId = identity.GetUserId(); var user = await manager.ValidateSecurityStampAsync(identity, userId); if (user != null) diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/InMemoryEFUserStoreTest.cs b/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/InMemoryEFUserStoreTest.cs index abc427d180..72aa757d62 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/InMemoryEFUserStoreTest.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/InMemoryEFUserStoreTest.cs @@ -33,7 +33,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.InMemory.Test options.Password.RequireUppercase = false; options.User.UserNameValidationRegex = null; }); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } protected override RoleManager CreateRoleManager(object context) @@ -46,7 +46,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.InMemory.Test services.Add(OptionsServices.GetDefaultServices()); services.AddEntityFramework().AddInMemoryStore(); services.AddIdentityInMemory((InMemoryContext)context); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } } } diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/RoleStoreTest.cs b/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/RoleStoreTest.cs index 03bc139ca5..a04ad66e2c 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/RoleStoreTest.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/RoleStoreTest.cs @@ -20,7 +20,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.InMemory.Test var store = new RoleStore(new InMemoryContext()); services.AddIdentity().AddRoleStore(store); var provider = services.BuildServiceProvider(); - var manager = provider.GetService>(); + var manager = provider.GetRequiredService>(); Assert.NotNull(manager); IdentityResultAssert.IsSuccess(await manager.CreateAsync(new IdentityRole("arole"))); } @@ -34,7 +34,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.InMemory.Test services.AddTransient, RoleValidator>(); services.AddSingleton>(); var provider = services.BuildServiceProvider(); - var manager = provider.GetService>(); + var manager = provider.GetRequiredService>(); Assert.NotNull(manager); IdentityResultAssert.IsSuccess(await manager.CreateAsync(new IdentityRole("someRole"))); } diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/TestIdentityFactory.cs b/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/TestIdentityFactory.cs index 910551dc0f..369dd36a34 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/TestIdentityFactory.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.InMemory.Test/TestIdentityFactory.cs @@ -35,7 +35,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.InMemory.Test { var services = new ServiceCollection(); services.AddIdentity().AddRoleStore(new RoleStore(context)); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } public static RoleManager CreateRoleManager() diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.Test/DbUtil.cs b/test/Microsoft.AspNet.Identity.EntityFramework.Test/DbUtil.cs index fccea8f43b..e0f9098c03 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.Test/DbUtil.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.Test/DbUtil.cs @@ -41,7 +41,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test public static TContext Create(string connectionString) where TContext : DbContext, new() { var serviceProvider = ConfigureDbServices(connectionString).BuildServiceProvider(); - return serviceProvider.GetService(); + return serviceProvider.GetRequiredService(); } } diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.Test/DefaultPocoTest.cs b/test/Microsoft.AspNet.Identity.EntityFramework.Test/DefaultPocoTest.cs index 9cc9c11541..dcad05dea6 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.Test/DefaultPocoTest.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.Test/DefaultPocoTest.cs @@ -54,8 +54,8 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test services.AddDefaultIdentity(); }); - var userStore = builder.ApplicationServices.GetService>(); - var userManager = builder.ApplicationServices.GetService>(); + var userStore = builder.ApplicationServices.GetRequiredService>(); + var userManager = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(userStore); Assert.NotNull(userManager); diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.Test/SqlStoreTestBase.cs b/test/Microsoft.AspNet.Identity.EntityFramework.Test/SqlStoreTestBase.cs index 4c9655dd48..f8013e73bc 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.Test/SqlStoreTestBase.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.Test/SqlStoreTestBase.cs @@ -76,7 +76,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test context = CreateTestContext(); } services.AddIdentity().AddRoleStore(new RoleStore((TestDbContext)context)); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } public void EnsureDatabase() @@ -96,8 +96,8 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test services.AddIdentityEntityFramework(); }); - var userStore = builder.ApplicationServices.GetService>(); - var userManager = builder.ApplicationServices.GetService>(); + var userStore = builder.ApplicationServices.GetRequiredService>(); + var userManager = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(userStore); Assert.NotNull(userManager); @@ -130,8 +130,8 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test }); }); - var userStore = builder.ApplicationServices.GetService>(); - var userManager = builder.ApplicationServices.GetService>(); + var userStore = builder.ApplicationServices.GetRequiredService>(); + var userManager = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(userStore); Assert.NotNull(userManager); diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreGuidKeyTest.cs b/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreGuidKeyTest.cs index a3469c34ec..43185a33b8 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreGuidKeyTest.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreGuidKeyTest.cs @@ -77,7 +77,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test } var services = DbUtil.ConfigureDbServices(ConnectionString); services.AddIdentity().AddRoleStore(new ApplicationRoleStore((TestDbContext)context)); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } } } \ No newline at end of file diff --git a/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreTest.cs b/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreTest.cs index e2f94908b2..c0d62cd66e 100644 --- a/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreTest.cs +++ b/test/Microsoft.AspNet.Identity.EntityFramework.Test/UserStoreTest.cs @@ -56,8 +56,8 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test services.AddDefaultIdentity(); }); - var userStore = builder.ApplicationServices.GetService>(); - var userManager = builder.ApplicationServices.GetService>(); + var userStore = builder.ApplicationServices.GetRequiredService>(); + var userManager = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(userStore); Assert.NotNull(userManager); @@ -92,8 +92,8 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test }); }); - var userStore = builder.ApplicationServices.GetService>(); - var userManager = builder.ApplicationServices.GetService>(); + var userStore = builder.ApplicationServices.GetRequiredService>(); + var userManager = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(userStore); Assert.NotNull(userManager); @@ -164,7 +164,7 @@ namespace Microsoft.AspNet.Identity.EntityFramework.Test { var services = DbUtil.ConfigureDbServices(ConnectionString); services.AddIdentity().AddRoleStore(new RoleStore(context)); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } protected override RoleManager CreateRoleManager(object context) diff --git a/test/Microsoft.AspNet.Identity.InMemory.Test/HttpSignInTest.cs b/test/Microsoft.AspNet.Identity.InMemory.Test/HttpSignInTest.cs index deed93526d..a0066ca23d 100644 --- a/test/Microsoft.AspNet.Identity.InMemory.Test/HttpSignInTest.cs +++ b/test/Microsoft.AspNet.Identity.InMemory.Test/HttpSignInTest.cs @@ -45,8 +45,8 @@ namespace Microsoft.AspNet.Identity.InMemory.Test UserName = "Yolo" }; const string password = "Yol0Sw@g!"; - var userManager = app.ApplicationServices.GetService>(); - var signInManager = app.ApplicationServices.GetService>(); + var userManager = app.ApplicationServices.GetRequiredService>(); + var signInManager = app.ApplicationServices.GetRequiredService>(); IdentityResultAssert.IsSuccess(await userManager.CreateAsync(user, password)); var result = await signInManager.PasswordSignInAsync(user.UserName, password, isPersistent, false); diff --git a/test/Microsoft.AspNet.Identity.InMemory.Test/InMemoryStoreTest.cs b/test/Microsoft.AspNet.Identity.InMemory.Test/InMemoryStoreTest.cs index 7759c4f5d5..55b8e69c7b 100644 --- a/test/Microsoft.AspNet.Identity.InMemory.Test/InMemoryStoreTest.cs +++ b/test/Microsoft.AspNet.Identity.InMemory.Test/InMemoryStoreTest.cs @@ -29,14 +29,14 @@ namespace Microsoft.AspNet.Identity.InMemory.Test options.Password.RequireUppercase = false; options.User.UserNameValidationRegex = null; }); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } protected override RoleManager CreateRoleManager(object context) { var services = new ServiceCollection(); services.AddIdentity().AddInMemory(); - return services.BuildServiceProvider().GetService>(); + return services.BuildServiceProvider().GetRequiredService>(); } } } \ No newline at end of file diff --git a/test/Microsoft.AspNet.Identity.InMemory.Test/StartupTest.cs b/test/Microsoft.AspNet.Identity.InMemory.Test/StartupTest.cs index 899117a67a..b8e2959d96 100644 --- a/test/Microsoft.AspNet.Identity.InMemory.Test/StartupTest.cs +++ b/test/Microsoft.AspNet.Identity.InMemory.Test/StartupTest.cs @@ -23,10 +23,10 @@ namespace Microsoft.AspNet.Identity.InMemory.Test builder.UseServices(services => services.AddIdentity().AddInMemory()); - var userStore = builder.ApplicationServices.GetService>(); - var roleStore = builder.ApplicationServices.GetService>(); - var userManager = builder.ApplicationServices.GetService>(); - var roleManager = builder.ApplicationServices.GetService>(); + var userStore = builder.ApplicationServices.GetRequiredService>(); + var roleStore = builder.ApplicationServices.GetRequiredService>(); + var userManager = builder.ApplicationServices.GetRequiredService>(); + var roleManager = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(userStore); Assert.NotNull(userManager); @@ -42,20 +42,20 @@ namespace Microsoft.AspNet.Identity.InMemory.Test var builder = new ApplicationBuilder(new ServiceCollection().BuildServiceProvider()); builder.UseServices(services => services.AddIdentity().AddInMemory()); - var userStore = builder.ApplicationServices.GetService>(); - var roleStore = builder.ApplicationServices.GetService>(); - var userManager = builder.ApplicationServices.GetService>(); - var roleManager = builder.ApplicationServices.GetService>(); + var userStore = builder.ApplicationServices.GetRequiredService>(); + var roleStore = builder.ApplicationServices.GetRequiredService>(); + var userManager = builder.ApplicationServices.GetRequiredService>(); + var roleManager = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(userStore); Assert.NotNull(userManager); Assert.NotNull(roleStore); Assert.NotNull(roleManager); - var userStore2 = builder.ApplicationServices.GetService>(); - var roleStore2 = builder.ApplicationServices.GetService>(); - var userManager2 = builder.ApplicationServices.GetService>(); - var roleManager2 = builder.ApplicationServices.GetService>(); + var userStore2 = builder.ApplicationServices.GetRequiredService>(); + var roleStore2 = builder.ApplicationServices.GetRequiredService>(); + var userManager2 = builder.ApplicationServices.GetRequiredService>(); + var roleManager2 = builder.ApplicationServices.GetRequiredService>(); // Stores are singleton, managers are scoped Assert.Equal(userStore, userStore2); @@ -70,8 +70,8 @@ namespace Microsoft.AspNet.Identity.InMemory.Test const string userName = "admin"; const string roleName = "Admins"; const string password = "1qaz@WSX"; - var userManager = serviceProvider.GetService>(); - var roleManager = serviceProvider.GetService>(); + var userManager = serviceProvider.GetRequiredService>(); + var roleManager = serviceProvider.GetRequiredService>(); var user = new ApplicationUser { UserName = userName }; IdentityResultAssert.IsSuccess(await userManager.CreateAsync(user, password)); diff --git a/test/Microsoft.AspNet.Identity.Test/IdentityBuilderTest.cs b/test/Microsoft.AspNet.Identity.Test/IdentityBuilderTest.cs index 41820382dc..dcea443aea 100644 --- a/test/Microsoft.AspNet.Identity.Test/IdentityBuilderTest.cs +++ b/test/Microsoft.AspNet.Identity.Test/IdentityBuilderTest.cs @@ -16,7 +16,7 @@ namespace Microsoft.AspNet.Identity.Test var services = new ServiceCollection(); var validator = new UserValidator(); services.AddIdentity().AddUserValidator(validator); - Assert.Equal(validator, services.BuildServiceProvider().GetService>()); + Assert.Equal(validator, services.BuildServiceProvider().GetRequiredService>()); } [Fact] @@ -25,7 +25,7 @@ namespace Microsoft.AspNet.Identity.Test var services = new ServiceCollection(); var validator = new PasswordValidator(); services.AddIdentity().AddPasswordValidator(validator); - Assert.Equal(validator, services.BuildServiceProvider().GetService>()); + Assert.Equal(validator, services.BuildServiceProvider().GetRequiredService>()); } [Fact] @@ -41,13 +41,13 @@ namespace Microsoft.AspNet.Identity.Test services.AddIdentity(); var provider = services.BuildServiceProvider(); - var userValidator = provider.GetService>() as UserValidator; + var userValidator = provider.GetRequiredService>() as UserValidator; Assert.NotNull(userValidator); - var pwdValidator = provider.GetService>() as PasswordValidator; + var pwdValidator = provider.GetRequiredService>() as PasswordValidator; Assert.NotNull(pwdValidator); - var hasher = provider.GetService>() as PasswordHasher; + var hasher = provider.GetRequiredService>() as PasswordHasher; Assert.NotNull(hasher); } @@ -55,7 +55,7 @@ namespace Microsoft.AspNet.Identity.Test { var services = new ServiceCollection(); services.AddIdentity().AddInstance(instance); - Assert.Equal(instance, services.BuildServiceProvider().GetService()); + Assert.Equal(instance, services.BuildServiceProvider().GetRequiredService()); } } diff --git a/test/Microsoft.AspNet.Identity.Test/IdentityOptionsTest.cs b/test/Microsoft.AspNet.Identity.Test/IdentityOptionsTest.cs index 83f13416c2..4d7983804a 100644 --- a/test/Microsoft.AspNet.Identity.Test/IdentityOptionsTest.cs +++ b/test/Microsoft.AspNet.Identity.Test/IdentityOptionsTest.cs @@ -66,7 +66,7 @@ namespace Microsoft.AspNet.Identity.Test var services = new ServiceCollection {OptionsServices.GetDefaultServices()}; services.AddIdentity(config.GetSubKey("identity")); - var accessor = services.BuildServiceProvider().GetService>(); + var accessor = services.BuildServiceProvider().GetRequiredService>(); Assert.NotNull(accessor); var options = accessor.Options; Assert.Equal(roleClaimType, options.ClaimsIdentity.RoleClaimType); @@ -96,7 +96,7 @@ namespace Microsoft.AspNet.Identity.Test var services = new ServiceCollection { OptionsServices.GetDefaultServices() }; services.AddIdentity(config.GetSubKey("identity"), o => { o.User.RequireUniqueEmail = false; o.Lockout.MaxFailedAccessAttempts++; }); - var accessor = services.BuildServiceProvider().GetService>(); + var accessor = services.BuildServiceProvider().GetRequiredService>(); Assert.NotNull(accessor); var options = accessor.Options; Assert.False(options.User.RequireUniqueEmail); @@ -120,9 +120,9 @@ namespace Microsoft.AspNet.Identity.Test services.ConfigureOptions(); }); - var setup = builder.ApplicationServices.GetService>(); + var setup = builder.ApplicationServices.GetRequiredService>(); Assert.IsType(typeof(PasswordsNegativeLengthSetup), setup); - var optionsGetter = builder.ApplicationServices.GetService>(); + var optionsGetter = builder.ApplicationServices.GetRequiredService>(); Assert.NotNull(optionsGetter); var myOptions = optionsGetter.Options; Assert.True(myOptions.Password.RequireLowercase); @@ -141,7 +141,7 @@ namespace Microsoft.AspNet.Identity.Test services.AddIdentity().ConfigureIdentity(options => options.User.RequireUniqueEmail = true); }); - var optionsGetter = app.ApplicationServices.GetService>(); + var optionsGetter = app.ApplicationServices.GetRequiredService>(); Assert.NotNull(optionsGetter); var myOptions = optionsGetter.Options; diff --git a/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs b/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs index b1d56f25d7..96d6c3e14b 100644 --- a/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs +++ b/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs @@ -53,8 +53,8 @@ namespace Microsoft.AspNet.Identity.Test // UserName = "Yolo" // }; // const string password = "Yol0Sw@g!"; - // var userManager = app.ApplicationServices.GetService(); - // var HttpSignInManager = app.ApplicationServices.GetService(); + // var userManager = app.ApplicationServices.GetRequiredService(); + // var HttpSignInManager = app.ApplicationServices.GetRequiredService(); // IdentityResultAssert.IsSuccess(await userManager.CreateAsync(user, password)); // var result = await HttpSignInManager.PasswordSignInAsync(user.UserName, password, isPersistent, false); diff --git a/test/Microsoft.AspNet.Identity.Test/UserManagerTest.cs b/test/Microsoft.AspNet.Identity.Test/UserManagerTest.cs index 342229a2ec..7bf2214d3f 100644 --- a/test/Microsoft.AspNet.Identity.Test/UserManagerTest.cs +++ b/test/Microsoft.AspNet.Identity.Test/UserManagerTest.cs @@ -34,7 +34,7 @@ namespace Microsoft.AspNet.Identity.Test services.Add(OptionsServices.GetDefaultServices()); services.AddTransient, NoopUserStore>(); services.AddTransient(); - var manager = services.BuildServiceProvider().GetService(); + var manager = services.BuildServiceProvider().GetRequiredService(); Assert.NotNull(manager.PasswordHasher); Assert.NotNull(manager.PasswordValidator); Assert.NotNull(manager.UserValidator);