huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Policheck errors

This commit is contained in:
David Fowler 2018-04-06 13:01:20 -07:00
parent e3d90bdf6a
commit e51676fb47
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Microsoft.AspNetCore.Http.Connections/HttpConnectionContext.cs
View File

@ -205,7 +205,7 @@ namespace Microsoft.AspNetCore.Http.Connections
try try
{ {
// A poorly written application *could* in theory hang forever and it'll show up as a memory leak // A poorly written application *could* in theory get stuck forever and it'll show up as a memory leak
Log.WaitingForApplication(_logger); Log.WaitingForApplication(_logger);
await applicationTask; await applicationTask;
@ -230,7 +230,7 @@ namespace Microsoft.AspNetCore.Http.Connections
try try
{ {
Log.WaitingForTransportAndApplication(_logger, TransportType); Log.WaitingForTransportAndApplication(_logger, TransportType);
// A poorly written application *could* in theory hang forever and it'll show up as a memory leak // A poorly written application *could* in theory get stuck forever and it'll show up as a memory leak
await Task.WhenAll(applicationTask, transportTask); await Task.WhenAll(applicationTask, transportTask);
} }
finally finally

6
test/Microsoft.AspNetCore.Http.Connections.Tests/HttpConnectionDispatcherTests.cs
View File

@ -1271,7 +1271,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Tests
var options = new HttpConnectionOptions(); var options = new HttpConnectionOptions();
options.AuthorizationData.Add(new AuthorizeAttribute("test")); options.AuthorizationData.Add(new AuthorizeAttribute("test"));
// would hang if EndPoint was running // would get stuck if EndPoint was running
await dispatcher.ExecuteAsync(context, options, app).OrTimeout(); await dispatcher.ExecuteAsync(context, options, app).OrTimeout();
Assert.Equal(StatusCodes.Status401Unauthorized, context.Response.StatusCode); Assert.Equal(StatusCodes.Status401Unauthorized, context.Response.StatusCode);
@ -1320,7 +1320,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Tests
context.User = new ClaimsPrincipal(new ClaimsIdentity("authenticated")); context.User = new ClaimsPrincipal(new ClaimsIdentity("authenticated"));
// would hang if EndPoint was running // would get stuck if EndPoint was running
await dispatcher.ExecuteAsync(context, options, app).OrTimeout(); await dispatcher.ExecuteAsync(context, options, app).OrTimeout();
Assert.Equal(StatusCodes.Status403Forbidden, context.Response.StatusCode); Assert.Equal(StatusCodes.Status403Forbidden, context.Response.StatusCode);
@ -1438,7 +1438,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Tests
// partially "authorize" user // partially "authorize" user
context.User = new ClaimsPrincipal(new ClaimsIdentity(new[] { new Claim(ClaimTypes.NameIdentifier, "name") })); context.User = new ClaimsPrincipal(new ClaimsIdentity(new[] { new Claim(ClaimTypes.NameIdentifier, "name") }));
// would hang if EndPoint was running // would get stuck if EndPoint was running
await dispatcher.ExecuteAsync(context, options, app).OrTimeout(); await dispatcher.ExecuteAsync(context, options, app).OrTimeout();
Assert.Equal(StatusCodes.Status401Unauthorized, context.Response.StatusCode); Assert.Equal(StatusCodes.Status401Unauthorized, context.Response.StatusCode);