From e35c4a8acc52ee5b259ae2d74e2ae62cdade9552 Mon Sep 17 00:00:00 2001
From: Chris Ross <Tratcher@Outlook.com>
Date: Thu, 13 Aug 2020 08:52:29 -0700
Subject: [PATCH] Apply suggestions from code review

---
 Directory.Build.props                                       | 4 ++--
 .../TransportTestHelpers/HostNameIsReachableAttribute.cs    | 6 ------
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index bf28690cfb..bc09f78c3a 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -126,10 +126,10 @@
     <RuntimeInstallerBaseName>aspnetcore-runtime</RuntimeInstallerBaseName>
     <TargetingPackInstallerBaseName>aspnetcore-targeting-pack</TargetingPackInstallerBaseName>
 
-    <!-- This is used to produce targeting pack installers/packages once per major.minor except in extraordinary cases i.e. 3.1.8. -->
+    <!-- This is used to produce targeting pack installers/packages once per major.minor. -->
     <IsTargetingPackBuilding Condition=" '$(DotNetBuildFromSource)' == 'true' ">false</IsTargetingPackBuilding>
     <IsTargetingPackBuilding
-        Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(AspNetCorePatchVersion)' != '8' ">false</IsTargetingPackBuilding>
+        Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(AspNetCorePatchVersion)' != '0' ">false</IsTargetingPackBuilding>
     <IsTargetingPackBuilding Condition=" '$(IsTargetingPackBuilding)' == '' ">true</IsTargetingPackBuilding>
 
     <!--
diff --git a/src/Servers/Kestrel/shared/test/TransportTestHelpers/HostNameIsReachableAttribute.cs b/src/Servers/Kestrel/shared/test/TransportTestHelpers/HostNameIsReachableAttribute.cs
index 67dbeed364..1c15cd164e 100644
--- a/src/Servers/Kestrel/shared/test/TransportTestHelpers/HostNameIsReachableAttribute.cs
+++ b/src/Servers/Kestrel/shared/test/TransportTestHelpers/HostNameIsReachableAttribute.cs
@@ -31,12 +31,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
 
         private async Task<bool> HostNameIsReachable()
         {
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
-            {
-                // Code below is unreliable on macOS and tests fail on that platform.
-                return false;
-            }
-
             try
             {
                 _hostname = Dns.GetHostName();