From e16d263cd587f25e8b7dd05e856e9461f4c6b914 Mon Sep 17 00:00:00 2001 From: Ryan Nowak Date: Fri, 13 Mar 2015 18:00:45 -0700 Subject: [PATCH] Reduce use of TypeActivation for ModelBinders These model binders don't have any per-request state so there is no need for them to be type activated. In one case the model binder actually does its own caching which is being defeated by the fact that we register it as type activated. More changes to come in this area. --- src/Microsoft.AspNet.Mvc/MvcOptionsSetup.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Microsoft.AspNet.Mvc/MvcOptionsSetup.cs b/src/Microsoft.AspNet.Mvc/MvcOptionsSetup.cs index 2049547f8e..7b0f2e183d 100644 --- a/src/Microsoft.AspNet.Mvc/MvcOptionsSetup.cs +++ b/src/Microsoft.AspNet.Mvc/MvcOptionsSetup.cs @@ -29,8 +29,8 @@ namespace Microsoft.AspNet.Mvc options.ViewEngines.Add(typeof(RazorViewEngine)); // Set up ModelBinding - options.ModelBinders.Add(typeof(BinderTypeBasedModelBinder)); - options.ModelBinders.Add(typeof(ServicesModelBinder)); + options.ModelBinders.Add(new BinderTypeBasedModelBinder()); + options.ModelBinders.Add(new ServicesModelBinder()); options.ModelBinders.Add(typeof(BodyModelBinder)); options.ModelBinders.Add(new HeaderModelBinder()); options.ModelBinders.Add(new TypeConverterModelBinder()); @@ -39,7 +39,7 @@ namespace Microsoft.AspNet.Mvc options.ModelBinders.Add(new ByteArrayModelBinder()); options.ModelBinders.Add(new FormFileModelBinder()); options.ModelBinders.Add(new FormCollectionModelBinder()); - options.ModelBinders.Add(typeof(GenericModelBinder)); + options.ModelBinders.Add(new GenericModelBinder()); options.ModelBinders.Add(new MutableObjectModelBinder()); options.ModelBinders.Add(new ComplexModelDtoModelBinder());