From e0e9eb0b3609807912b1b885c67a5d0047800686 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 1 May 2018 16:57:36 -0700 Subject: [PATCH] Add pre-generated shims to dotnet tool packages --- NuGetPackageVerifier.json | 70 +++++++++---------- build/dependencies.props | 20 +++--- korebuild-lock.txt | 4 +- src/Directory.Build.props | 9 --- src/Directory.Build.targets | 3 - src/DotnetTool.props | 15 ---- ...NetCore.DeveloperCertificates.XPlat.csproj | 2 - src/PackGlobalTool.targets | 19 ----- src/dotnet-dev-certs/DotnetToolSettings.xml | 6 -- src/dotnet-dev-certs/dotnet-dev-certs.csproj | 10 ++- src/dotnet-dev-certs/dotnet-dev-certs.nuspec | 25 ------- src/dotnet-sql-cache/DotnetToolSettings.xml | 6 -- src/dotnet-sql-cache/dotnet-sql-cache.csproj | 24 +++---- src/dotnet-sql-cache/dotnet-sql-cache.nuspec | 25 ------- .../DotnetToolSettings.xml | 6 -- .../dotnet-user-secrets.csproj | 30 +++----- .../dotnet-user-secrets.nuspec | 25 ------- src/dotnet-watch/DotnetToolSettings.xml | 6 -- src/dotnet-watch/dotnet-watch.csproj | 12 +++- src/dotnet-watch/dotnet-watch.nuspec | 25 ------- .../dotnet-user-secrets.Tests.csproj | 4 ++ 21 files changed, 85 insertions(+), 261 deletions(-) delete mode 100644 src/DotnetTool.props delete mode 100644 src/PackGlobalTool.targets delete mode 100644 src/dotnet-dev-certs/DotnetToolSettings.xml delete mode 100644 src/dotnet-dev-certs/dotnet-dev-certs.nuspec delete mode 100644 src/dotnet-sql-cache/DotnetToolSettings.xml delete mode 100644 src/dotnet-sql-cache/dotnet-sql-cache.nuspec delete mode 100644 src/dotnet-user-secrets/DotnetToolSettings.xml delete mode 100644 src/dotnet-user-secrets/dotnet-user-secrets.nuspec delete mode 100644 src/dotnet-watch/DotnetToolSettings.xml delete mode 100644 src/dotnet-watch/dotnet-watch.nuspec diff --git a/NuGetPackageVerifier.json b/NuGetPackageVerifier.json index ca0d81e371..3e59aeb910 100644 --- a/NuGetPackageVerifier.json +++ b/NuGetPackageVerifier.json @@ -15,39 +15,39 @@ ], "Exclusions": { "NEUTRAL_RESOURCES_LANGUAGE": { - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." }, "WRONG_PUBLICKEYTOKEN": { - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." }, "ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH": { - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." }, "ASSEMBLY_FILE_VERSION_MISMATCH": { - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." }, "ASSEMBLY_VERSION_MISMATCH": { - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.0/System.Text.Encoding.CodePages.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/unix/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/runtimes/win/lib/netcoreapp2.1/System.Data.SqlClient.dll": "Assembly is built by another project but bundled in our nupkg." } } }, @@ -57,26 +57,26 @@ ], "Exclusions": { "NEUTRAL_RESOURCES_LANGUAGE": { - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." }, "SERVICING_ATTRIBUTE": { - "tools/any/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg." }, "WRONG_PUBLICKEYTOKEN": { - "tools/any/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." }, "ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH": { - "tools/any/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." }, "ASSEMBLY_FILE_VERSION_MISMATCH": { - "tools/any/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." }, "ASSEMBLY_VERSION_MISMATCH": { - "tools/any/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", - "tools/any/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." + "tools/netcoreapp2.1/any/Newtonsoft.Json.dll": "Assembly is built by another project but bundled in our nupkg.", + "tools/netcoreapp2.1/any/System.Runtime.CompilerServices.Unsafe.dll": "Assembly is built by another project but bundled in our nupkg." } } }, diff --git a/build/dependencies.props b/build/dependencies.props index 02852a5e72..73aaaa8abf 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -3,18 +3,18 @@ $(MSBuildAllProjects);$(MSBuildThisFileFullPath) - 2.1.0-rc1-15774 - 2.1.0-rc1-30613 - 2.1.0-rc1-30613 - 2.1.0-rc1-30613 - 2.1.0-rc1-30613 - 2.1.0-rc1-30613 + 2.1.0-rtm-15776 + 2.1.0-rc1-30677 + 2.1.0-rc1-30677 + 2.1.0-rc1-30677 + 2.1.0-rc1-30677 + 2.1.0-rc1-30677 2.0.0 - 2.1.0-rc1-26419-02 + 2.1.0-rc1-26423-06 15.6.1 - 2.0.1 - 4.5.0-rc1-26419-03 - 4.5.0-rc1-26419-03 + 2.0.3 + 4.5.0-rc1-26423-06 + 4.5.0-rc1-26423-06 9.0.1 2.3.1 2.4.0-beta.1.build3945 diff --git a/korebuild-lock.txt b/korebuild-lock.txt index d35f5d62cf..d455c7a7a6 100644 --- a/korebuild-lock.txt +++ b/korebuild-lock.txt @@ -1,2 +1,2 @@ -version:2.1.0-rc1-15774 -commithash:ed5ca9de3c652347dbb0158a9a65eff3471d2114 +version:2.1.0-rtm-15780 +commithash:4b54ae92ccebdf2a5aabca9748cc874eeafe5ac9 diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 7129734857..4b89a431e7 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -1,15 +1,6 @@ - - - false - - - false - - - diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets index 9dd4a760bf..c7b5f24861 100644 --- a/src/Directory.Build.targets +++ b/src/Directory.Build.targets @@ -1,8 +1,5 @@ - - - diff --git a/src/DotnetTool.props b/src/DotnetTool.props deleted file mode 100644 index ec4a5965f3..0000000000 --- a/src/DotnetTool.props +++ /dev/null @@ -1,15 +0,0 @@ - - - $(MSBuildProjectDirectory)\$(MSBuildProjectName).nuspec - - true - - Microsoft - true - false - - - - - - diff --git a/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj b/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj index ae5cc3d68d..81c90a297c 100644 --- a/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj +++ b/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj @@ -5,8 +5,6 @@ Package for the CLI first run experience. $(DefineConstants);XPLAT aspnet;cli - - Microsoft diff --git a/src/PackGlobalTool.targets b/src/PackGlobalTool.targets deleted file mode 100644 index d97666110c..0000000000 --- a/src/PackGlobalTool.targets +++ /dev/null @@ -1,19 +0,0 @@ - - - - - publishDir=$(PublishDir); - version=$(PackageVersion); - licenseUrl=$(PackageLicenseUrl); - projectUrl=$(PackageProjectUrl); - iconUrl=$(PackageIconUrl); - serviceable=$(Serviceable); - copyright=$(Copyright); - description=$(Description); - repositoryUrl=$(RepositoryUrl); - targetframework=$(TargetFramework); - repositoryCommit=$(RepositoryCommit); - - - - diff --git a/src/dotnet-dev-certs/DotnetToolSettings.xml b/src/dotnet-dev-certs/DotnetToolSettings.xml deleted file mode 100644 index dbc7a5b6d9..0000000000 --- a/src/dotnet-dev-certs/DotnetToolSettings.xml +++ /dev/null @@ -1,6 +0,0 @@ - - - - - - diff --git a/src/dotnet-dev-certs/dotnet-dev-certs.csproj b/src/dotnet-dev-certs/dotnet-dev-certs.csproj index 8c4d039c02..024cc705d2 100644 --- a/src/dotnet-dev-certs/dotnet-dev-certs.csproj +++ b/src/dotnet-dev-certs/dotnet-dev-certs.csproj @@ -1,11 +1,17 @@ - + + + netcoreapp2.1 exe Command line tool to generate certificates used in ASP.NET Core during development. - DotnetTool Microsoft.AspNetCore.DeveloperCertificates.Tools + dotnet;developercertificates + true + + + true diff --git a/src/dotnet-dev-certs/dotnet-dev-certs.nuspec b/src/dotnet-dev-certs/dotnet-dev-certs.nuspec deleted file mode 100644 index 878e0f4ab2..0000000000 --- a/src/dotnet-dev-certs/dotnet-dev-certs.nuspec +++ /dev/null @@ -1,25 +0,0 @@ - - - - dotnet-dev-certs - dotnet developercertificates - $version$ - Microsoft - Microsoft - $licenseUrl$ - $projectUrl$ - $iconUrl$ - $description$ - $copyright$ - true - $serviceable$ - - - - - - - - - - diff --git a/src/dotnet-sql-cache/DotnetToolSettings.xml b/src/dotnet-sql-cache/DotnetToolSettings.xml deleted file mode 100644 index 2619964f0e..0000000000 --- a/src/dotnet-sql-cache/DotnetToolSettings.xml +++ /dev/null @@ -1,6 +0,0 @@ - - - - - - diff --git a/src/dotnet-sql-cache/dotnet-sql-cache.csproj b/src/dotnet-sql-cache/dotnet-sql-cache.csproj index 64d2c8b51b..ad1105f2b8 100644 --- a/src/dotnet-sql-cache/dotnet-sql-cache.csproj +++ b/src/dotnet-sql-cache/dotnet-sql-cache.csproj @@ -1,28 +1,20 @@ - + + + netcoreapp2.1 exe Command line tool to create tables and indexes in a Microsoft SQL Server database for distributed caching. - DotnetTool - tools/any/any/ + cache;distributedcache;sqlserver + true + + + true - - - - - - - - - - - - - diff --git a/src/dotnet-sql-cache/dotnet-sql-cache.nuspec b/src/dotnet-sql-cache/dotnet-sql-cache.nuspec deleted file mode 100644 index 0c6e9d05e2..0000000000 --- a/src/dotnet-sql-cache/dotnet-sql-cache.nuspec +++ /dev/null @@ -1,25 +0,0 @@ - - - - dotnet-sql-cache - cache distributedcache sqlserver - $version$ - Microsoft - Microsoft - $licenseUrl$ - $projectUrl$ - $iconUrl$ - $description$ - $copyright$ - true - $serviceable$ - - - - - - - - - - diff --git a/src/dotnet-user-secrets/DotnetToolSettings.xml b/src/dotnet-user-secrets/DotnetToolSettings.xml deleted file mode 100644 index 0de9f13c31..0000000000 --- a/src/dotnet-user-secrets/DotnetToolSettings.xml +++ /dev/null @@ -1,6 +0,0 @@ - - - - - - diff --git a/src/dotnet-user-secrets/dotnet-user-secrets.csproj b/src/dotnet-user-secrets/dotnet-user-secrets.csproj index 9f578a0c36..f431447a01 100644 --- a/src/dotnet-user-secrets/dotnet-user-secrets.csproj +++ b/src/dotnet-user-secrets/dotnet-user-secrets.csproj @@ -1,35 +1,23 @@ - + + + netcoreapp2.1 exe Command line tool to manage user secrets for Microsoft.Extensions.Configuration. - DotnetTool false Microsoft.Extensions.SecretManager.Tools - tools/any/any/ + configuration;secrets;usersecrets + true + + + true - - - - - - - - - - - - - - - - - - + diff --git a/src/dotnet-user-secrets/dotnet-user-secrets.nuspec b/src/dotnet-user-secrets/dotnet-user-secrets.nuspec deleted file mode 100644 index 54caef9177..0000000000 --- a/src/dotnet-user-secrets/dotnet-user-secrets.nuspec +++ /dev/null @@ -1,25 +0,0 @@ - - - - dotnet-user-secrets - configuration secrets usersecrets - $version$ - Microsoft - Microsoft - $licenseUrl$ - $projectUrl$ - $iconUrl$ - $description$ - $copyright$ - true - $serviceable$ - - - - - - - - - - diff --git a/src/dotnet-watch/DotnetToolSettings.xml b/src/dotnet-watch/DotnetToolSettings.xml deleted file mode 100644 index 7e9a7f40d4..0000000000 --- a/src/dotnet-watch/DotnetToolSettings.xml +++ /dev/null @@ -1,6 +0,0 @@ - - - - - - diff --git a/src/dotnet-watch/dotnet-watch.csproj b/src/dotnet-watch/dotnet-watch.csproj index 19db471fe7..f20ea3ebc5 100644 --- a/src/dotnet-watch/dotnet-watch.csproj +++ b/src/dotnet-watch/dotnet-watch.csproj @@ -1,16 +1,22 @@ - + + + netcoreapp2.1 exe Command line tool to watch for source file changes during development and restart the dotnet command. - DotnetTool Microsoft.DotNet.Watcher.Tools + dotnet;watch + true + + + true - + diff --git a/src/dotnet-watch/dotnet-watch.nuspec b/src/dotnet-watch/dotnet-watch.nuspec deleted file mode 100644 index 5442df0874..0000000000 --- a/src/dotnet-watch/dotnet-watch.nuspec +++ /dev/null @@ -1,25 +0,0 @@ - - - - dotnet-watch - dotnet watch - $version$ - Microsoft - Microsoft - $licenseUrl$ - $projectUrl$ - $iconUrl$ - $description$ - $copyright$ - true - $serviceable$ - - - - - - - - - - diff --git a/test/dotnet-user-secrets.Tests/dotnet-user-secrets.Tests.csproj b/test/dotnet-user-secrets.Tests/dotnet-user-secrets.Tests.csproj index 360e9301cf..fd8be34db7 100644 --- a/test/dotnet-user-secrets.Tests/dotnet-user-secrets.Tests.csproj +++ b/test/dotnet-user-secrets.Tests/dotnet-user-secrets.Tests.csproj @@ -14,4 +14,8 @@ + + + +