diff --git a/build/PackageArchive.targets b/build/PackageArchive.targets index 7688976518..580a67bcf4 100644 --- a/build/PackageArchive.targets +++ b/build/PackageArchive.targets @@ -2,29 +2,12 @@ <_TemplatesDirectory>$(MSBuildThisFileDirectory)tools\templates\ <_WorkRoot>$(RepositoryRoot).w\ - $(RepositoryRoot).deps\Signed\Packages\ - $(RepositoryRoot).deps\Signed\Packages-NoTimeStamp\ - nuGetPackagesArchive.timestamped - nuGetPackagesArchive.notimestamp + $(RepositoryRoot).deps\Signed\Packages\ + nuGetPackagesArchive-$(PackageVersion) - - - - - - - - - + - @@ -40,14 +23,13 @@ BuildArtifacts="@(ArtifactInfo)" PackageArtifacts="@(PackageArtifact)" ExternalDependencies="@(ExternalDependency)" - RemoveTimestamp="$(RemoveTimestamp)" MetapackageVersion="$(MetapackageVersion)" /> - $(_WorkRoot)obj\$(OutputPackageName) + $(_WorkRoot)obj\$(LzmaOutputPackageName) $(ArtifactsDir)lzma\ - $(FallbackOutputDir)$(OutputPackageName).lzma - $(_WorkRoot)restoresources.$(OutputPackageName).props + $(FallbackOutputDir)$(LzmaOutputPackageName).lzma + $(_WorkRoot)restoresources.$(LzmaOutputPackageName).props diff --git a/build/RepositoryBuild.targets b/build/RepositoryBuild.targets index faaf0a0799..f13bb407af 100644 --- a/build/RepositoryBuild.targets +++ b/build/RepositoryBuild.targets @@ -43,7 +43,9 @@ $(RepositoryBuildArguments) /p:DotNetRestoreSourcePropsPath=$(GeneratedRestoreSourcesPropsPath) $(RepositoryBuildArguments) /p:DotNetPackageVersionPropsPath=$(GeneratedPackageVersionPropsPath) - $(RepositoryBuildArguments) /p:BuildNumber=$(BuildNumber) /p:Configuration=$(Configuration) + $(RepositoryBuildArguments) /p:BuildNumber=$(BuildNumber) + $(RepositoryBuildArguments) /p:Configuration=$(Configuration) + $(RepositoryBuildArguments) /p:IsFinalBuild=$(IsFinalBuild) $(RepositoryBuildArguments) /noconsolelogger '/l:RepoTasks.FlowLogger,$(MSBuildThisFileDirectory)tasks\bin\publish\RepoTasks.dll;Summary;FlowId=$(RepositoryToBuild)' $(_RepositoryBuildTargets) $(RepositoryBuildArguments) diff --git a/build/RuntimeStoreInstaller.targets b/build/RuntimeStoreInstaller.targets index 08f6ecf3a8..bf788a6778 100644 --- a/build/RuntimeStoreInstaller.targets +++ b/build/RuntimeStoreInstaller.targets @@ -4,8 +4,7 @@ <_DockerDir>$(MSBuildThisFileDirectory)tools\docker\ <_PackagingDir>$(MSBuildThisFileDirectory)tools\packaging\ <_DebToolDir>$(MSBuildThisFileDirectory)tools\dotnet-deb-tool-consumer\ - <_TimestampRSSource>$(RepositoryRoot).deps\Signed\Store\ - <_TimestampFreeRSSource>$(RepositoryRoot).deps\Signed\Store-TimestampFree\ + <_RuntimeStoreSource>$(RepositoryRoot).deps\Signed\Store\ <_InstallerSource>$(RepositoryRoot).deps\Installers\ <_WorkRoot>$(RepositoryRoot).w\ <_WorkLayoutDir>$(_WorkRoot).l\ @@ -15,6 +14,7 @@ aspnetcore-store dotnet-hosting + $(HostingInstallerName)-$(PackageVersion)-linux-x64.tar.gz $(_PackagingDir)store_debian_config.json $(_PackagingDir)hosting_debian_config.json @@ -24,9 +24,8 @@ $(PublicCoreFeedPrefix)/aspnetcore/store/2.0.0-26452/Build.RS. $(CoreFeedPrefix)/Runtime/$(MicrosoftNETCoreApp20PackageVersion)/dotnet-runtime-$(MicrosoftNETCoreApp20PackageVersion)-linux-x64.tar.gz - $(_TimestampRSSource)aspnetcore-store-$(PackageVersion)-linux-x64.tar.gz - $(_TimestampFreeRSSource)aspnetcore-store-$(PackageVersionNoTimestamp)- - $(TimestampFreeRSArchivePrefix)linux-x64.tar.gz + $(_RuntimeStoreSource)aspnetcore-store-$(PackageVersion)- + $(RuntimeStoreArchivePrefix)linux-x64.tar.gz @@ -42,20 +41,8 @@ - - - - + Text="Linux archive not found. Expected it to exist in $(RuntimeStoreLinuxArchiveFilePath)." + Condition="!Exists('$(RuntimeStoreLinuxArchiveFilePath)')" /> @@ -121,22 +108,10 @@ <_DependentArchives Include="$(_InstallerSource)Build.RS.linux.tar.gz" /> - - @(_DependentArchives) - $(HostingInstallerName)-$(Version)-linux-x64.tar.gz - $(HostingInstallerName)-$(PackageVersionNoTimestamp)-linux-x64.tar.gz - - - - - + Properties="DependentArchives=@(_DependentArchives);RSArchive=$(RuntimeStoreLinuxArchiveFilePath);OutputArchiveName=$(HostingArchiveName)" /> @@ -150,16 +125,16 @@ - $(TimestampFreeRSArchivePrefix)linux-x64.tar.gz + $(RuntimeStoreArchivePrefix)linux-x64.tar.gz - $(TimestampFreeRSArchivePrefix)osx-x64.tar.gz + $(RuntimeStoreArchivePrefix)osx-x64.tar.gz - $(TimestampFreeRSArchivePrefix)win7-x64.zip + $(RuntimeStoreArchivePrefix)win7-x64.zip - $(TimestampFreeRSArchivePrefix)win7-x86.zip + $(RuntimeStoreArchivePrefix)win7-x86.zip @@ -313,17 +288,10 @@ $(MicrosoftNETCoreApp20PackageVersion) - - $(PackageVersionNoTimestamp) - - - $(MicrosoftNETCoreApp20PackageVersion) - @(HostingDependencies->' -d "%(Identity) >= %(Version)"', ' ') - @(TimestampFreeHostingDependencies->' -d "%(Identity) >= %(Version)"', ' ') @(RSDependencies->' -d "%(Identity) >= %(Version)"', ' ') $(RSDependencyArguments) @(RHStoreDirectories->' --directories "%(FullPath)"', ' ') $(RSDependencyArguments) @(GenericStoreDirectories->' --directories "%(FullPath)"', ' ') @@ -342,48 +310,28 @@ $(CommonHostingArguments);RPMSummary=@(_HostingSummary);RPMDescription=@(_HostingDescription) $(CommonHostingArguments);RPMLicense=@(_HostingLicense);RPMHomepage=@(_HostingHomepage) - $(CommonArguments);$(CommonGenericArguments);$(CommonRSArguments) - $(TimestampRSArguments);RSArchive=$(TimestampRSArchive);RPMVersion=$(PackageVersion);RPMArguments=$(GenericRSArguments) + $(CommonArguments);$(CommonGenericArguments);$(CommonRSArguments) + $(RS_RPM_Arguments);RSArchive=$(RuntimeStoreLinuxArchiveFilePath);RPMVersion=$(PackageVersion);RPMArguments=$(GenericRSArguments) - $(CommonArguments);$(CommonGenericArguments);$(CommonRSArguments) - $(TimestampFreeRSArguments);RSArchive=$(TimestampFreeLinuxRSArchive);RPMVersion=$(PackageVersionNoTimestamp);RPMArguments=$(GenericRSArguments) + $(CommonArguments);$(CommonGenericArguments);$(CommonHostingArguments) + $(Hosting_RPM_RedHat_Arguments);RPMVersion=$(PackageVersion);RPMArguments=$(HostingFPMArguments) - $(CommonArguments);$(CommonGenericArguments);$(CommonHostingArguments) - $(TimestampHostingArguments);RPMVersion=$(PackageVersion);RPMArguments=$(HostingFPMArguments) + $(CommonArguments);$(CommonRHArguments);$(CommonRSArguments) + $(RS_RPM_RedHat_Arguments);RSArchive=$(RuntimeStoreLinuxArchiveFilePath);RPMVersion=$(PackageVersion);RPMArguments=$(RHRSArguments) - $(CommonArguments);$(CommonGenericArguments);$(CommonHostingArguments) - $(TimestampFreeHostingArguments);RPMVersion=$(PackageVersionNoTimestamp);RPMArguments=$(TimestampFreeHostingFPMArguments) - - $(CommonArguments);$(CommonRHArguments);$(CommonRSArguments) - $(RHTimestampRSArguments);RSArchive=$(TimestampRSArchive);RPMVersion=$(PackageVersion);RPMArguments=$(RHRSArguments) - - $(CommonArguments);$(CommonRHArguments);$(CommonRSArguments) - $(RHTimestampFreeRSArguments);RSArchive=$(TimestampFreeLinuxRSArchive);RPMVersion=$(PackageVersionNoTimestamp);RPMArguments=$(RHRSArguments) - - $(CommonArguments);$(CommonRHArguments);$(CommonHostingArguments) - $(RHTimestampHostingArguments);RPMVersion=$(PackageVersion);RPMArguments=$(HostingFPMArguments) - - $(CommonArguments);$(CommonRHArguments);$(CommonHostingArguments) - $(RHTimestampFreeHostingArguments);RPMVersion=$(PackageVersionNoTimestamp);RPMArguments=$(TimestampFreeHostingFPMArguments) + $(CommonArguments);$(CommonRHArguments);$(CommonHostingArguments) + $(Hosting_RPM_Arguments);RPMVersion=$(PackageVersion);RPMArguments=$(HostingFPMArguments) - - - - - - - - + + + + - - - - - - - - + + + + @@ -464,19 +412,11 @@ - + Properties="$(CommonRSArguments);RSArchive=$(RuntimeStoreLinuxArchiveFilePath);DebVersion=$(Version)" /> - @@ -484,7 +424,7 @@ - Version=$(Version);TimestampFreeVersion=$(PackageVersionNoTimestamp) + Version=$(Version) diff --git a/build/Templating.targets b/build/Templating.targets index e94ab11503..9af26681cd 100644 --- a/build/Templating.targets +++ b/build/Templating.targets @@ -5,26 +5,16 @@ - $(IntermediateDir)dependencies.notimestamp.props - + RepositoryRoot=$(TemplatingProjectRoot); DotNetRestoreSourcesPropsPath=$(GeneratedRestoreSourcesPropsPath); + DotNetPackageVersionPropsPath=$(GeneratedPackageVersionPropsPath); BuildNumber=$(BuildNumber); Configuration=$(Configuration); - - - $(TemplateProjCommmonProperties); - DotNetPackageVersionPropsPath=$(GeneratedPackageVersionPropsPath); - VersionMetadata=timestamped; + IsFinalBuild=$(IsFinalBuild); - - $(TemplateProjCommmonProperties); - DotNetPackageVersionPropsPath=$(GeneratedNoTimestampPackageVersionPropsPath); - IsFinalBuild=true; - - @@ -34,35 +24,6 @@ - - - - - - - - <_NoTimestampPackages Include="@(ExternalDependency)" /> - <_NoTimestampPackages Include="%(FinalBuildArtifactInfo.PackageId)" Version="%(FinalBuildArtifactInfo.Version)" Condition=" '%(FinalBuildArtifactInfo.ArtifactType)' == 'NuGetPackage' " /> - <_NoTimestampPackages Include="Microsoft.AspNetCore.All" Version="$(PackageVersionNoTimestamp)" /> - - - - - - - - - - - - diff --git a/build/repo.props b/build/repo.props index 45a74537b4..275a931fe1 100644 --- a/build/repo.props +++ b/build/repo.props @@ -7,6 +7,7 @@ false true + false diff --git a/build/tasks/AddArchiveReferences.cs b/build/tasks/AddArchiveReferences.cs index 5da49ee059..eeb38128f5 100644 --- a/build/tasks/AddArchiveReferences.cs +++ b/build/tasks/AddArchiveReferences.cs @@ -19,9 +19,6 @@ namespace RepoTasks [Required] public string MetaPackageVersion { get; set; } - [Required] - public bool RemoveTimestamp { get; set; } - [Required] public ITaskItem[] BuildArtifacts { get; set; } @@ -61,11 +58,6 @@ namespace RepoTasks .Single(p => string.Equals(p.PackageInfo.Id, packageName, StringComparison.OrdinalIgnoreCase)) .PackageInfo.Version.ToString(); - if (RemoveTimestamp) - { - packageVersion = VersionUtilities.GetTimestampFreeVersion(packageVersion); - } - Log.LogMessage(MessageImportance.High, $" - Package: {packageName} Version: {packageVersion}"); var packageReferenceElement = xmlDoc.CreateElement("PackageReference"); @@ -95,11 +87,6 @@ namespace RepoTasks .Single(p => string.Equals(p.PackageInfo.Id, packageName, StringComparison.OrdinalIgnoreCase)) .PackageInfo.Version.ToString(); - if (RemoveTimestamp) - { - packageVersion = VersionUtilities.GetTimestampFreeVersion(packageVersion); - } - Log.LogMessage(MessageImportance.High, $" - Tool: {packageName} Version: {packageVersion}"); var packageReferenceElement = xmlDoc.CreateElement("DotNetCliToolReference"); diff --git a/build/tasks/Utilities/VersionUtilities.cs b/build/tasks/Utilities/VersionUtilities.cs deleted file mode 100644 index 042ecae378..0000000000 --- a/build/tasks/Utilities/VersionUtilities.cs +++ /dev/null @@ -1,49 +0,0 @@ -// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved. -// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. - -using System; -using NuGet.Versioning; - -namespace RepoTasks.Utilities -{ - public class VersionUtilities - { - public static string GetTimestampFreeVersion(string packageVersion) - { - var version = new NuGetVersion(packageVersion); - var updatedVersion = new NuGetVersion(version.Version, GetTimestampFreeReleaseLabel(version.Release)); - return updatedVersion.ToNormalizedString(); - } - - public static string GetTimestampFreeReleaseLabel(string releaseLabel) - { - if (releaseLabel.StartsWith("rtm-", StringComparison.OrdinalIgnoreCase)) - { - // E.g. change version 2.5.0-rtm-123123 to 2.5.0. - releaseLabel = string.Empty; - } - else - { - var timeStampFreeVersion = Environment.GetEnvironmentVariable("TIMESTAMP_FREE_VERSION"); - if (string.IsNullOrEmpty(timeStampFreeVersion)) - { - timeStampFreeVersion = "final"; - } - - if (!timeStampFreeVersion.StartsWith("-")) - { - timeStampFreeVersion = "-" + timeStampFreeVersion; - } - - // E.g. change version 2.5.0-rc2-123123 to 2.5.0-rc2-final. - var index = releaseLabel.LastIndexOf('-'); - if (index != -1) - { - releaseLabel = releaseLabel.Substring(0, index) + timeStampFreeVersion; - } - } - - return releaseLabel; - } - } -} \ No newline at end of file diff --git a/version.props b/version.props index 53bd896f60..e5fd0676de 100644 --- a/version.props +++ b/version.props @@ -3,9 +3,7 @@ 2.1.0 preview1 $(VersionPrefix) - $(VersionPrefix) $(VersionPrefix)-$(VersionSuffix)-final - $(VersionPrefix)-$(VersionSuffix)-final $(VersionSuffix)-$(BuildNumber)