From dfac28da89263d58dace5f98e8bc6159da352171 Mon Sep 17 00:00:00 2001
From: Chris R <Tratcher@outlook.com>
Date: Mon, 1 Feb 2016 12:33:38 -0800
Subject: [PATCH] Fix warnings, enable warningsAsErrors

---
 samples/TestClient/Program.cs                             | 4 ++--
 src/Microsoft.AspNetCore.Server.WebListener/project.json  | 1 +
 .../Overlapped/PreAllocatedOverlapped.cs                  | 1 -
 .../Overlapped/ThreadPoolBoundHandle.cs                   | 8 ++++----
 src/Microsoft.Net.Http.Server/project.json                | 1 +
 src/Microsoft.Net.WebSockets.Server/WebSocketBuffer.cs    | 2 +-
 src/Microsoft.Net.WebSockets.Server/project.json          | 1 +
 7 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/samples/TestClient/Program.cs b/samples/TestClient/Program.cs
index 23c53b8f89..f57945de42 100644
--- a/samples/TestClient/Program.cs
+++ b/samples/TestClient/Program.cs
@@ -45,8 +45,8 @@ namespace TestClient
             }
 
             // RunWebSocketClient().Wait();
-            Console.WriteLine("Done");
-            Console.ReadKey();
+            // Console.WriteLine("Done");
+            // Console.ReadKey();
         }
 
         public static async Task RunWebSocketClient()
diff --git a/src/Microsoft.AspNetCore.Server.WebListener/project.json b/src/Microsoft.AspNetCore.Server.WebListener/project.json
index 5c4d638fcf..2708965453 100644
--- a/src/Microsoft.AspNetCore.Server.WebListener/project.json
+++ b/src/Microsoft.AspNetCore.Server.WebListener/project.json
@@ -8,6 +8,7 @@
   },
   "compilationOptions": {
     "allowUnsafe": true,
+    "warningsAsErrors": true,
     "keyFile": "../../tools/Key.snk"
   },
   "frameworks": {
diff --git a/src/Microsoft.Net.Http.Server/Overlapped/PreAllocatedOverlapped.cs b/src/Microsoft.Net.Http.Server/Overlapped/PreAllocatedOverlapped.cs
index 465c816391..92572dc9f4 100644
--- a/src/Microsoft.Net.Http.Server/Overlapped/PreAllocatedOverlapped.cs
+++ b/src/Microsoft.Net.Http.Server/Overlapped/PreAllocatedOverlapped.cs
@@ -6,7 +6,6 @@ namespace System.Threading
     {
         internal readonly ThreadPoolBoundHandleOverlapped _overlapped;
         private DeferredDisposableLifetime<PreAllocatedOverlapped> _lifetime;
-        [CLSCompliant(false)]
         public PreAllocatedOverlapped(IOCompletionCallback callback, object state, object pinData)
         {
             if (callback == null)
diff --git a/src/Microsoft.Net.Http.Server/Overlapped/ThreadPoolBoundHandle.cs b/src/Microsoft.Net.Http.Server/Overlapped/ThreadPoolBoundHandle.cs
index 3b7ad7d966..595d347a57 100644
--- a/src/Microsoft.Net.Http.Server/Overlapped/ThreadPoolBoundHandle.cs
+++ b/src/Microsoft.Net.Http.Server/Overlapped/ThreadPoolBoundHandle.cs
@@ -46,7 +46,7 @@ namespace System.Threading
             }
             return new ThreadPoolBoundHandle(handle);
         }
-        [CLSCompliant(false)]
+
         public unsafe NativeOverlapped* AllocateNativeOverlapped(IOCompletionCallback callback, object state, object pinData)
         {
             if (callback == null)
@@ -59,7 +59,7 @@ namespace System.Threading
                 _boundHandle = this
             }._nativeOverlapped;
         }
-        [CLSCompliant(false)]
+
         public unsafe NativeOverlapped* AllocateNativeOverlapped(PreAllocatedOverlapped preAllocated)
         {
             if (preAllocated == null)
@@ -86,7 +86,7 @@ namespace System.Threading
             }
             return nativeOverlapped;
         }
-        [CLSCompliant(false)]
+
         public unsafe void FreeNativeOverlapped(NativeOverlapped* overlapped)
         {
             if (overlapped == null)
@@ -105,7 +105,7 @@ namespace System.Threading
             }
             Overlapped.Free(overlapped);
         }
-        [CLSCompliant(false)]
+
         public unsafe static object GetNativeOverlappedState(NativeOverlapped* overlapped)
         {
             if (overlapped == null)
diff --git a/src/Microsoft.Net.Http.Server/project.json b/src/Microsoft.Net.Http.Server/project.json
index da2b43a592..c63d55703f 100644
--- a/src/Microsoft.Net.Http.Server/project.json
+++ b/src/Microsoft.Net.Http.Server/project.json
@@ -7,6 +7,7 @@
   },
   "compilationOptions": {
     "allowUnsafe": true,
+    "warningsAsErrors": true,
     "keyFile": "../../tools/Key.snk"
   },
   "frameworks": {
diff --git a/src/Microsoft.Net.WebSockets.Server/WebSocketBuffer.cs b/src/Microsoft.Net.WebSockets.Server/WebSocketBuffer.cs
index e71d463f7f..1c87e73334 100644
--- a/src/Microsoft.Net.WebSockets.Server/WebSocketBuffer.cs
+++ b/src/Microsoft.Net.WebSockets.Server/WebSocketBuffer.cs
@@ -66,7 +66,7 @@ namespace Microsoft.Net.WebSockets
         private readonly ArraySegment<byte> _PropertyBuffer;
         private readonly int _SendBufferSize;
         private volatile int _PayloadOffset;
-        private volatile WebSocketReceiveResult _BufferedPayloadReceiveResult;
+        private WebSocketReceiveResult _BufferedPayloadReceiveResult;
         private long _PinnedSendBufferStartAddress;
         private long _PinnedSendBufferEndAddress;
         private ArraySegment<byte> _PinnedSendBuffer;
diff --git a/src/Microsoft.Net.WebSockets.Server/project.json b/src/Microsoft.Net.WebSockets.Server/project.json
index 73d00dc129..cc2fce2d21 100644
--- a/src/Microsoft.Net.WebSockets.Server/project.json
+++ b/src/Microsoft.Net.WebSockets.Server/project.json
@@ -6,6 +6,7 @@
   },
   "compilationOptions": {
     "allowUnsafe": true,
+    "warningsAsErrors": true,
     "keyFile": "../../tools/Key.snk"
   },
   "frameworks": {