diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index 9f5e3eb7ae..0145056f59 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -62,6 +62,10 @@ jobs: - script: ./build.cmd -ci -sign -forceCoreMsbuild /p:DisableCodeSigning=true -projects ./src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj displayName: Build SiteExtension + # Remove all task build output + - script: rmdir /s /q build\tasks\bin + displayName: Clear task build output + # This runs code-signing on all packages, zips, and jar files as defined in build/CodeSign.targets. If https://github.com/dotnet/arcade/issues/1957 is resolved, # consider running code-signing inline with the other previous steps. # Sign check is disabled because it is run in a separate step below, after installers are built. diff --git a/Directory.Build.targets b/Directory.Build.targets index 4623263e54..efafc9f288 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -87,11 +87,15 @@ $(MicrosoftNETCoreAppPackageVersion) - + + + + $(SharedFxVersion) $(SharedFxVersion) $(SharedFxVersion) + diff --git a/eng/Dependencies.props b/eng/Dependencies.props index 16a5996035..1cf1f7f1a7 100644 --- a/eng/Dependencies.props +++ b/eng/Dependencies.props @@ -166,6 +166,16 @@ and are generated based on the last package release. + + + + + + + + + + diff --git a/korebuild-lock.txt b/korebuild-lock.txt index c8758ef040..638dfb3b2a 100644 --- a/korebuild-lock.txt +++ b/korebuild-lock.txt @@ -1,2 +1,2 @@ -version:3.0.0-build-20190314.2 -commithash:e3a8a2aae198f1ef26309714ccba6835be2437c3 +version:3.0.0-build-20190322.1 +commithash:c38761a564c72b5bc96356ec99c89de5f281a358 diff --git a/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj b/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj index f11c2fe3c5..8111e92070 100644 --- a/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj +++ b/src/Framework/src/Microsoft.AspNetCore.App.Runtime.csproj @@ -112,8 +112,9 @@ This package is an internal implementation of the .NET Core SDK and is not meant x64_arm64\$(CrossgenToolPackagePath) x86_arm\$(CrossgenToolPackagePath) - $(NuGetPackageRoot)/runtime.$(RuntimeIdentifier).microsoft.netcore.app/$(MicrosoftNETCoreAppPackageVersion)/ - $(RuntimePackageRoot)tools/$(CrossgenToolPackagePath) + $([System.IO.Path]::Combine('$(NuGetPackageRoot)', 'runtime.$(RuntimeIdentifier).microsoft.netcore.app', '$(MicrosoftNETCoreAppPackageVersion)')) + $([MSBuild]::EnsureTrailingSlash('$(RuntimePackageRoot)')) + $([System.IO.Path]::Combine('$(RuntimePackageRoot)', 'tools', '$(CrossgenToolPackagePath)')) $(AssetTargetFallback);native,Version=0.0 @@ -123,6 +124,8 @@ This package is an internal implementation of the .NET Core SDK and is not meant Runtime;Native + + Platform=$(TargetArchitecture) Platform=Win32 diff --git a/src/Mvc/Mvc.Analyzers/src/Microsoft.AspNetCore.Mvc.Analyzers.csproj b/src/Mvc/Mvc.Analyzers/src/Microsoft.AspNetCore.Mvc.Analyzers.csproj index 1db6be9790..ac65f894d0 100644 --- a/src/Mvc/Mvc.Analyzers/src/Microsoft.AspNetCore.Mvc.Analyzers.csproj +++ b/src/Mvc/Mvc.Analyzers/src/Microsoft.AspNetCore.Mvc.Analyzers.csproj @@ -15,7 +15,7 @@ - + diff --git a/src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj b/src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj index 89fef738b4..848befd504 100644 --- a/src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj +++ b/src/Mvc/Mvc.Api.Analyzers/src/Microsoft.AspNetCore.Mvc.Api.Analyzers.csproj @@ -20,7 +20,7 @@ - + diff --git a/src/Tools/dotnet-watch/test/AppWithDepsTests.cs b/src/Tools/dotnet-watch/test/AppWithDepsTests.cs index 8ec43cf3a5..4ca708d618 100644 --- a/src/Tools/dotnet-watch/test/AppWithDepsTests.cs +++ b/src/Tools/dotnet-watch/test/AppWithDepsTests.cs @@ -1,10 +1,11 @@ -// Copyright (c) .NET Foundation. All rights reserved. +// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.IO; using System.Threading.Tasks; using Microsoft.AspNetCore.Testing; +using Microsoft.AspNetCore.Testing.xunit; using Xunit; using Xunit.Abstractions; @@ -19,7 +20,7 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests _app = new AppWithDeps(logger); } - [Fact] + [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/8267")] public async Task ChangeFileInDependency() { await _app.StartWatcherAsync(); diff --git a/src/Tools/dotnet-watch/test/GlobbingAppTests.cs b/src/Tools/dotnet-watch/test/GlobbingAppTests.cs index 34c4b79d2d..e68e30120b 100644 --- a/src/Tools/dotnet-watch/test/GlobbingAppTests.cs +++ b/src/Tools/dotnet-watch/test/GlobbingAppTests.cs @@ -6,6 +6,7 @@ using System.IO; using System.Linq; using System.Threading; using System.Threading.Tasks; +using Microsoft.AspNetCore.Testing; using Microsoft.AspNetCore.Testing.xunit; using Microsoft.DotNet.Watcher.Tools.Tests; using Xunit; @@ -21,10 +22,9 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests _app = new GlobbingApp(logger); } - [ConditionalTheory] + [Theory(Skip = "https://github.com/aspnet/AspNetCore/issues/8267")] [InlineData(true)] [InlineData(false)] - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/8267 public async Task ChangeCompiledFile(bool usePollingWatcher) { _app.UsePollingWatcher = usePollingWatcher; @@ -42,8 +42,7 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests Assert.Equal(2, types); } - [ConditionalFact] - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/8267 + [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/8267")] public async Task DeleteCompiledFile() { await _app.StartWatcherAsync(); @@ -59,8 +58,7 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests Assert.Equal(1, types); } - [ConditionalFact] - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/8267 + [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/8267")] public async Task DeleteSourceFolder() { await _app.StartWatcherAsync(); diff --git a/src/Tools/dotnet-watch/test/NoDepsAppTests.cs b/src/Tools/dotnet-watch/test/NoDepsAppTests.cs index e3cb61831b..29c2ed8739 100644 --- a/src/Tools/dotnet-watch/test/NoDepsAppTests.cs +++ b/src/Tools/dotnet-watch/test/NoDepsAppTests.cs @@ -5,6 +5,7 @@ using System; using System.Diagnostics; using System.IO; using System.Threading.Tasks; +using Microsoft.AspNetCore.Testing; using Microsoft.AspNetCore.Testing.xunit; using Xunit; using Xunit.Abstractions; @@ -24,8 +25,7 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests _output = logger; } - [ConditionalFact] - [SkipOnHelix] // https://github.com/aspnet/AspNetCore/issues/8267 + [Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/8267")] public async Task RestartProcessOnFileChange() { await _app.StartWatcherAsync(new[] { "--no-exit" }); diff --git a/src/Tools/startvs.cmd b/src/Tools/startvs.cmd new file mode 100644 index 0000000000..a156d3b3b0 --- /dev/null +++ b/src/Tools/startvs.cmd @@ -0,0 +1,3 @@ +@ECHO OFF + +%~dp0..\..\startvs.cmd %~dp0Tools.sln