From de201a544f9564e67311518fd18ba35dbd867962 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Wed, 15 Mar 2017 16:17:33 -0700 Subject: [PATCH] Unify dependencies versions to one file and remove workarounds --- build/dependencies.props | 6 +++- ...spNetCore.Mvc.Razor.ViewCompilation.csproj | 11 ++++++-- .../Infrastructure/CommandResultExtensions.cs | 25 ----------------- ...zor.ViewCompilation.FunctionalTests.csproj | 28 +++++++++++-------- ...Core.Mvc.Razor.ViewCompilation.Test.csproj | 11 +++++--- ...ionUsingPrecompiledViewClassLibrary.csproj | 9 +++--- .../ApplicationUsingRelativePaths.csproj | 9 +++--- .../ApplicationWithConfigureMvc.csproj | 9 +++--- .../ApplicationWithCustomInputFiles.csproj | 9 +++--- .../ApplicationWithParseErrors.csproj | 9 +++--- .../ApplicationWithTagHelpers.csproj | 9 +++--- .../ClassLibraryTagHelper.csproj | 7 ++--- .../ClassLibraryWithPrecompiledViews.csproj | 3 +- .../PublishWithEmbedViewSources.csproj | 9 +++--- testapps/SimpleApp/SimpleApp.csproj | 9 +++--- .../SimpleAppWithAssemblyRename.csproj | 9 +++--- testapps/StrongNamedApp/StrongNamedApp.csproj | 9 +++--- 17 files changed, 80 insertions(+), 101 deletions(-) delete mode 100644 test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Infrastructure/CommandResultExtensions.cs diff --git a/build/dependencies.props b/build/dependencies.props index e704edaec0..713bfbd055 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -1,6 +1,10 @@ - 1.6.1 + 1.2.0-* + 0.3.0-* 4.3.0 + 1.6.1 + 15.0.0 + 2.2.0 diff --git a/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj b/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj index 7e07033b0a..a86693df30 100644 --- a/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj +++ b/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj @@ -1,5 +1,7 @@  + + Build-time references required to enable Razor view compilation as part of building the application. netcoreapp1.1 @@ -9,12 +11,15 @@ build + + - - - + + + + diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Infrastructure/CommandResultExtensions.cs b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Infrastructure/CommandResultExtensions.cs deleted file mode 100644 index 7ac936f576..0000000000 --- a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Infrastructure/CommandResultExtensions.cs +++ /dev/null @@ -1,25 +0,0 @@ -// Copyright (c) .NET Foundation. All rights reserved. -// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. - -using System; -using Microsoft.DotNet.Cli.Utils; -using Xunit; - -namespace Microsoft.AspNetCore.Mvc.Razor.ViewCompilation -{ - public static class CommandResultExtensions - { - public static CommandResult EnsureSuccessful(this CommandResult commandResult) - { - var startInfo = commandResult.StartInfo; - - Assert.True(commandResult.ExitCode == 0, - string.Join(Environment.NewLine, - $"{startInfo.FileName} {startInfo.Arguments} exited with {commandResult.ExitCode}.", - commandResult.StdOut, - commandResult.StdErr)); - - return commandResult; - } - } -} diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj index 182cb42f2d..5ac55d2236 100644 --- a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj +++ b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.FunctionalTests.csproj @@ -1,25 +1,29 @@  - + + + netcoreapp1.1 $(DefineConstants);__remove_this_to__GENERATE_BASELINES + + - - - - - - - - - - + + + + + + + + + - \ No newline at end of file + + diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj index d2a447c2ac..be4160bee4 100644 --- a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj +++ b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj @@ -1,5 +1,7 @@  - + + + netcoreapp1.1 @@ -9,12 +11,13 @@ - - - + + + + diff --git a/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj b/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj index 4c98058991..1678773e75 100644 --- a/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj +++ b/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj @@ -1,16 +1,15 @@  netcoreapp1.1 - Exe - - - - + + + + diff --git a/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj b/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj index 82dbba5e63..8003e38b3f 100644 --- a/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj +++ b/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj @@ -1,14 +1,13 @@  netcoreapp1.1 - Exe true - - - - + + + + diff --git a/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj b/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj index 82dbba5e63..8003e38b3f 100644 --- a/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj +++ b/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj @@ -1,14 +1,13 @@  netcoreapp1.1 - Exe true - - - - + + + + diff --git a/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj b/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj index fac278c0fd..f190cafa4e 100644 --- a/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj +++ b/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj @@ -1,7 +1,6 @@  netcoreapp1.1 - Exe true true @@ -10,9 +9,9 @@ - - - - + + + + diff --git a/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj b/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj index 82dbba5e63..8003e38b3f 100644 --- a/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj +++ b/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj @@ -1,14 +1,13 @@  netcoreapp1.1 - Exe true - - - - + + + + diff --git a/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj b/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj index f57e4e89ce..41dab93ff9 100644 --- a/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj +++ b/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj @@ -1,7 +1,6 @@  netcoreapp1.1 - Exe true @@ -11,9 +10,9 @@ - - - - + + + + diff --git a/testapps/ClassLibraryTagHelper/ClassLibraryTagHelper.csproj b/testapps/ClassLibraryTagHelper/ClassLibraryTagHelper.csproj index 3d49b3a0f1..95e97bdf29 100644 --- a/testapps/ClassLibraryTagHelper/ClassLibraryTagHelper.csproj +++ b/testapps/ClassLibraryTagHelper/ClassLibraryTagHelper.csproj @@ -1,9 +1,8 @@ - - + netstandard1.6 - + - \ No newline at end of file + diff --git a/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj b/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj index 49a0b51292..1b692a6893 100644 --- a/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj +++ b/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj @@ -1,14 +1,13 @@  netcoreapp1.1 - Exe obj\precompiled\$(TargetFramework) true - + diff --git a/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj b/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj index fa6c75fdd3..39d300ec51 100644 --- a/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj +++ b/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj @@ -1,15 +1,14 @@  netcoreapp1.1 - Exe true true - - - - + + + + diff --git a/testapps/SimpleApp/SimpleApp.csproj b/testapps/SimpleApp/SimpleApp.csproj index 82dbba5e63..8003e38b3f 100644 --- a/testapps/SimpleApp/SimpleApp.csproj +++ b/testapps/SimpleApp/SimpleApp.csproj @@ -1,14 +1,13 @@  netcoreapp1.1 - Exe true - - - - + + + + diff --git a/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj b/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj index f0f3a8a7f3..12cc879675 100644 --- a/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj +++ b/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj @@ -2,14 +2,13 @@ NewAssemblyName netcoreapp1.1 - Exe true - - - - + + + + diff --git a/testapps/StrongNamedApp/StrongNamedApp.csproj b/testapps/StrongNamedApp/StrongNamedApp.csproj index 1456d8527d..ccdabeae1f 100644 --- a/testapps/StrongNamedApp/StrongNamedApp.csproj +++ b/testapps/StrongNamedApp/StrongNamedApp.csproj @@ -1,7 +1,6 @@  netcoreapp1.1 - Exe ../../build/Key.snk true true @@ -10,9 +9,9 @@ - - - - + + + +