Security -> Authentication

AuthN renames and design changes
This commit is contained in:
Hao Kung 2015-03-02 15:25:52 -08:00
parent 2f960b9e3b
commit de1e8763dd
25 changed files with 238 additions and 235 deletions

View File

@ -1,30 +1,26 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using System.Linq;
using System.Security.Claims;
using System.Text;
using System.Threading.Tasks;
using Microsoft.AspNet.Http.Security;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Interfaces.Authentication;
using Microsoft.AspNet.Http.Authentication;
namespace Microsoft.AspNet.Http.Core.Security
namespace Microsoft.AspNet.Http.Core.Authentication
{
public class AuthenticateContext : IAuthenticateContext
{
private List<AuthenticationResult> _results;
private List<string> _accepted;
public AuthenticateContext([NotNull] IEnumerable<string> authenticationTypes)
public AuthenticateContext([NotNull] IEnumerable<string> authenticationSchemes)
{
AuthenticationTypes = authenticationTypes;
AuthenticationSchemes = authenticationSchemes;
_results = new List<AuthenticationResult>();
_accepted = new List<string>();
}
public IEnumerable<string> AuthenticationTypes { get; private set; }
public IEnumerable<string> AuthenticationSchemes { get; private set; }
public IEnumerable<AuthenticationResult> Results
{
@ -36,16 +32,16 @@ namespace Microsoft.AspNet.Http.Core.Security
get { return _accepted; }
}
public void Authenticated(ClaimsIdentity identity, IDictionary<string, string> properties, IDictionary<string, object> description)
public void Authenticated(ClaimsPrincipal principal, IDictionary<string, string> properties, IDictionary<string, object> description)
{
var descrip = new AuthenticationDescription(description);
_accepted.Add(descrip.AuthenticationType); // may not match identity.AuthType
_results.Add(new AuthenticationResult(identity, new AuthenticationProperties(properties), descrip));
_accepted.Add(descrip.AuthenticationScheme); // may not match identity.AuthType
_results.Add(new AuthenticationResult(principal, new AuthenticationProperties(properties), descrip));
}
public void NotAuthenticated(string authenticationType, IDictionary<string, string> properties, IDictionary<string, object> description)
public void NotAuthenticated(string authenticationScheme, IDictionary<string, string> properties, IDictionary<string, object> description)
{
_accepted.Add(authenticationType);
_accepted.Add(authenticationScheme);
}
}
}

View File

@ -3,25 +3,22 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Interfaces.Authentication;
namespace Microsoft.AspNet.Http.Core.Security
namespace Microsoft.AspNet.Http.Core.Authentication
{
public class ChallengeContext : IChallengeContext
{
private List<string> _accepted;
public ChallengeContext([NotNull] IEnumerable<string> authenticationTypes, IDictionary<string, string> properties)
public ChallengeContext([NotNull] IEnumerable<string> authenticationSchemes, IDictionary<string, string> properties)
{
AuthenticationTypes = authenticationTypes;
AuthenticationSchemes = authenticationSchemes;
Properties = properties ?? new Dictionary<string, string>(StringComparer.Ordinal);
_accepted = new List<string>();
}
public IEnumerable<string> AuthenticationTypes { get; private set; }
public IEnumerable<string> AuthenticationSchemes { get; private set; }
public IDictionary<string, string> Properties { get; private set; }

View File

@ -1,18 +1,17 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using Microsoft.AspNet.Http.Security;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Authentication;
using Microsoft.AspNet.Http.Interfaces.Authentication;
namespace Microsoft.AspNet.Http.Core.Security
namespace Microsoft.AspNet.Http.Core.Authentication
{
public class AuthTypeContext : IAuthTypeContext
public class DescribeSchemesContext : IDescribeSchemesContext
{
private List<AuthenticationDescription> _results;
public AuthTypeContext()
public DescribeSchemesContext()
{
_results = new List<AuthenticationDescription>();
}

View File

@ -2,9 +2,9 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System.Security.Claims;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Interfaces.Authentication;
namespace Microsoft.AspNet.Http.Core.Security
namespace Microsoft.AspNet.Http.Core.Authentication
{
public class HttpAuthenticationFeature : IHttpAuthenticationFeature
{

View File

@ -0,0 +1,38 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using System.Security.Claims;
using Microsoft.AspNet.Http.Interfaces.Authentication;
namespace Microsoft.AspNet.Http.Core.Authentication
{
public class SignInContext : ISignInContext
{
private bool _accepted;
public SignInContext([NotNull] string authenticationScheme, [NotNull] ClaimsPrincipal principal, IDictionary<string, string> dictionary)
{
AuthenticationScheme = authenticationScheme;
Principal = principal;
Properties = dictionary ?? new Dictionary<string, string>(StringComparer.Ordinal);
}
public ClaimsPrincipal Principal { get; }
public IDictionary<string, string> Properties { get; }
public string AuthenticationScheme { get; }
public bool Accepted
{
get { return _accepted; }
}
public void Accept(IDictionary<string, object> description)
{
_accepted = true;
}
}
}

View File

@ -0,0 +1,31 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using Microsoft.AspNet.Http.Interfaces.Authentication;
namespace Microsoft.AspNet.Http.Core.Authentication
{
public class SignOutContext : ISignOutContext
{
private bool _accepted;
public SignOutContext(string authenticationScheme)
{
AuthenticationScheme = authenticationScheme;
}
public string AuthenticationScheme { get; }
public bool Accepted
{
get { return _accepted; }
}
public void Accept()
{
_accepted = true;
}
}
}

View File

@ -9,14 +9,13 @@ using System.Security.Claims;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNet.FeatureModel;
using Microsoft.AspNet.Http;
using Microsoft.AspNet.Http.Infrastructure;
using Microsoft.AspNet.Http.Security;
using Microsoft.AspNet.Http.Interfaces;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Core.Collections;
using Microsoft.AspNet.Http.Core.Infrastructure;
using Microsoft.AspNet.Http.Core.Security;
using Microsoft.AspNet.Http.Core.Authentication;
using Microsoft.AspNet.Http.Infrastructure;
using Microsoft.AspNet.Http.Interfaces;
using Microsoft.AspNet.Http.Interfaces.Authentication;
using Microsoft.AspNet.Http.Authentication;
namespace Microsoft.AspNet.Http.Core
{
@ -201,7 +200,7 @@ namespace Microsoft.AspNet.Http.Core
_features[type] = instance;
}
public override IEnumerable<AuthenticationDescription> GetAuthenticationTypes()
public override IEnumerable<AuthenticationDescription> GetAuthenticationSchemes()
{
var handler = HttpAuthenticationFeature.Handler;
if (handler == null)
@ -209,46 +208,46 @@ namespace Microsoft.AspNet.Http.Core
return new AuthenticationDescription[0];
}
var authTypeContext = new AuthTypeContext();
handler.GetDescriptions(authTypeContext);
return authTypeContext.Results;
var describeContext = new DescribeSchemesContext();
handler.GetDescriptions(describeContext);
return describeContext.Results;
}
public override IEnumerable<AuthenticationResult> Authenticate([NotNull] IEnumerable<string> authenticationTypes)
public override IEnumerable<AuthenticationResult> Authenticate([NotNull] IEnumerable<string> authenticationSchemes)
{
var handler = HttpAuthenticationFeature.Handler;
var authenticateContext = new AuthenticateContext(authenticationTypes);
var authenticateContext = new AuthenticateContext(authenticationSchemes);
if (handler != null)
{
handler.Authenticate(authenticateContext);
}
// Verify all types ack'd
IEnumerable<string> leftovers = authenticationTypes.Except(authenticateContext.Accepted);
IEnumerable<string> leftovers = authenticationSchemes.Except(authenticateContext.Accepted);
if (leftovers.Any())
{
throw new InvalidOperationException("The following authentication types were not accepted: " + string.Join(", ", leftovers));
throw new InvalidOperationException("The following authentication schemes were not accepted: " + string.Join(", ", leftovers));
}
return authenticateContext.Results;
}
public override async Task<IEnumerable<AuthenticationResult>> AuthenticateAsync([NotNull] IEnumerable<string> authenticationTypes)
public override async Task<IEnumerable<AuthenticationResult>> AuthenticateAsync([NotNull] IEnumerable<string> authenticationSchemes)
{
var handler = HttpAuthenticationFeature.Handler;
var authenticateContext = new AuthenticateContext(authenticationTypes);
var authenticateContext = new AuthenticateContext(authenticationSchemes);
if (handler != null)
{
await handler.AuthenticateAsync(authenticateContext);
}
// Verify all types ack'd
IEnumerable<string> leftovers = authenticationTypes.Except(authenticateContext.Accepted);
IEnumerable<string> leftovers = authenticationSchemes.Except(authenticateContext.Accepted);
if (leftovers.Any())
{
throw new InvalidOperationException("The following authentication types were not accepted: " + string.Join(", ", leftovers));
throw new InvalidOperationException("The following authentication schemes were not accepted: " + string.Join(", ", leftovers));
}
return authenticateContext.Results;
@ -264,4 +263,4 @@ namespace Microsoft.AspNet.Http.Core
return WebSocketFeature.AcceptAsync(new WebSocketAcceptContext() { SubProtocol = subProtocol } );
}
}
}
}

View File

@ -6,17 +6,14 @@ using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Security.Claims;
using System.Text;
using System.Threading.Tasks;
using Microsoft.AspNet.Http;
using Microsoft.AspNet.Http.Infrastructure;
using Microsoft.AspNet.Http.Security;
using Microsoft.AspNet.FeatureModel;
using Microsoft.AspNet.Http.Interfaces;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Core.Collections;
using Microsoft.AspNet.Http.Core.Infrastructure;
using Microsoft.AspNet.Http.Core.Security;
using Microsoft.AspNet.Http.Core.Authentication;
using Microsoft.AspNet.Http.Infrastructure;
using Microsoft.AspNet.Http.Interfaces;
using Microsoft.AspNet.Http.Interfaces.Authentication;
using Microsoft.AspNet.Http.Authentication;
namespace Microsoft.AspNet.Http.Core
{
@ -129,58 +126,56 @@ namespace Microsoft.AspNet.Http.Core
Headers.Set(Constants.Headers.Location, location);
}
public override void Challenge(AuthenticationProperties properties, [NotNull] IEnumerable<string> authenticationTypes)
public override void Challenge(AuthenticationProperties properties, [NotNull] IEnumerable<string> authenticationSchemes)
{
HttpResponseFeature.StatusCode = 401;
var handler = HttpAuthenticationFeature.Handler;
var challengeContext = new ChallengeContext(authenticationTypes, properties == null ? null : properties.Dictionary);
var challengeContext = new ChallengeContext(authenticationSchemes, properties == null ? null : properties.Dictionary);
if (handler != null)
{
handler.Challenge(challengeContext);
}
// Verify all types ack'd
IEnumerable<string> leftovers = authenticationTypes.Except(challengeContext.Accepted);
IEnumerable<string> leftovers = authenticationSchemes.Except(challengeContext.Accepted);
if (leftovers.Any())
{
throw new InvalidOperationException("The following authentication types were not accepted: " + string.Join(", ", leftovers));
}
}
public override void SignIn(AuthenticationProperties properties, [NotNull] IEnumerable<ClaimsIdentity> identities)
public override void SignIn(string authenticationScheme, [NotNull] ClaimsPrincipal principal, AuthenticationProperties properties)
{
var handler = HttpAuthenticationFeature.Handler;
var signInContext = new SignInContext(identities, properties == null ? null : properties.Dictionary);
var signInContext = new SignInContext(authenticationScheme, principal, properties == null ? null : properties.Dictionary);
if (handler != null)
{
handler.SignIn(signInContext);
}
// Verify all types ack'd
IEnumerable<string> leftovers = identities.Select(identity => identity.AuthenticationType).Except(signInContext.Accepted);
if (leftovers.Any())
if (!signInContext.Accepted)
{
throw new InvalidOperationException("The following authentication types were not accepted: " + string.Join(", ", leftovers));
throw new InvalidOperationException("The following authentication scheme was not accepted: " + authenticationScheme);
}
}
public override void SignOut([NotNull] IEnumerable<string> authenticationTypes)
public override void SignOut(string authenticationScheme)
{
var handler = HttpAuthenticationFeature.Handler;
var signOutContext = new SignOutContext(authenticationTypes);
var signOutContext = new SignOutContext(authenticationScheme);
if (handler != null)
{
handler.SignOut(signOutContext);
}
// Verify all types ack'd
IEnumerable<string> leftovers = authenticationTypes.Except(signOutContext.Accepted);
if (leftovers.Any())
if (!string.IsNullOrWhiteSpace(authenticationScheme) && !signOutContext.Accepted)
{
throw new InvalidOperationException("The following authentication types were not accepted: " + string.Join(", ", leftovers));
throw new InvalidOperationException("The following authentication scheme was not accepted: " + authenticationScheme);
}
}
}

View File

@ -1,36 +0,0 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using System.Security.Claims;
using Microsoft.AspNet.Http.Interfaces.Security;
namespace Microsoft.AspNet.Http.Core.Security
{
public class SignInContext : ISignInContext
{
private List<string> _accepted;
public SignInContext([NotNull] IEnumerable<ClaimsIdentity> identities, IDictionary<string, string> dictionary)
{
Identities = identities;
Properties = dictionary ?? new Dictionary<string, string>(StringComparer.Ordinal);
_accepted = new List<string>();
}
public IEnumerable<ClaimsIdentity> Identities { get; private set; }
public IDictionary<string, string> Properties { get; private set; }
public IEnumerable<string> Accepted
{
get { return _accepted; }
}
public void Accept(string authenticationType, IDictionary<string, object> description)
{
_accepted.Add(authenticationType);
}
}
}

View File

@ -1,32 +0,0 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using Microsoft.AspNet.Http.Interfaces.Security;
namespace Microsoft.AspNet.Http.Core.Security
{
public class SignOutContext : ISignOutContext
{
private List<string> _accepted;
public SignOutContext([NotNull] IEnumerable<string> authenticationTypes)
{
AuthenticationTypes = authenticationTypes;
_accepted = new List<string>();
}
public IEnumerable<string> AuthenticationTypes { get; private set; }
public IEnumerable<string> Accepted
{
get { return _accepted; }
}
public void Accept(string authenticationType, IDictionary<string, object> description)
{
_accepted.Add(authenticationType);
}
}
}

View File

@ -4,14 +4,14 @@
using System.Collections.Generic;
using System.Security.Claims;
namespace Microsoft.AspNet.Http.Interfaces.Security
namespace Microsoft.AspNet.Http.Interfaces.Authentication
{
public interface IAuthenticateContext
{
IEnumerable<string> AuthenticationTypes { get; }
IEnumerable<string> AuthenticationSchemes { get; }
void Authenticated(ClaimsIdentity identity, IDictionary<string, string> properties, IDictionary<string, object> description);
void Authenticated(ClaimsPrincipal principal, IDictionary<string, string> properties, IDictionary<string, object> description);
void NotAuthenticated(string authenticationType, IDictionary<string, string> properties, IDictionary<string, object> description);
void NotAuthenticated(string authenticationScheme, IDictionary<string, string> properties, IDictionary<string, object> description);
}
}

View File

@ -3,11 +3,11 @@
using System.Threading.Tasks;
namespace Microsoft.AspNet.Http.Interfaces.Security
namespace Microsoft.AspNet.Http.Interfaces.Authentication
{
public interface IAuthenticationHandler
{
void GetDescriptions(IAuthTypeContext context);
void GetDescriptions(IDescribeSchemesContext context);
void Authenticate(IAuthenticateContext context);
Task AuthenticateAsync(IAuthenticateContext context);

View File

@ -3,11 +3,11 @@
using System.Collections.Generic;
namespace Microsoft.AspNet.Http.Interfaces.Security
namespace Microsoft.AspNet.Http.Interfaces.Authentication
{
public interface IChallengeContext
{
IEnumerable<string> AuthenticationTypes {get;}
IEnumerable<string> AuthenticationSchemes {get;}
IDictionary<string,string> Properties {get;}
void Accept(string authenticationType, IDictionary<string,object> description);

View File

@ -3,9 +3,9 @@
using System.Collections.Generic;
namespace Microsoft.AspNet.Http.Interfaces.Security
namespace Microsoft.AspNet.Http.Interfaces.Authentication
{
public interface IAuthTypeContext
public interface IDescribeSchemesContext
{
void Accept(IDictionary<string,object> description);
}

View File

@ -3,7 +3,7 @@
using System.Security.Claims;
namespace Microsoft.AspNet.Http.Interfaces.Security
namespace Microsoft.AspNet.Http.Interfaces.Authentication
{
public interface IHttpAuthenticationFeature
{

View File

@ -4,13 +4,15 @@
using System.Collections.Generic;
using System.Security.Claims;
namespace Microsoft.AspNet.Http.Interfaces.Security
namespace Microsoft.AspNet.Http.Interfaces.Authentication
{
public interface ISignInContext
{
IEnumerable<ClaimsIdentity> Identities { get; }
//IEnumerable<ClaimsPrincipal> Principals { get; }
ClaimsPrincipal Principal { get; }
IDictionary<string, string> Properties { get; }
string AuthenticationScheme { get; }
void Accept(string authenticationType, IDictionary<string, object> description);
void Accept(IDictionary<string, object> description);
}
}

View File

@ -1,14 +1,12 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System.Collections.Generic;
namespace Microsoft.AspNet.Http.Interfaces.Security
namespace Microsoft.AspNet.Http.Interfaces.Authentication
{
public interface ISignOutContext
{
IEnumerable<string> AuthenticationTypes { get; }
string AuthenticationScheme { get; }
void Accept(string authenticationType, IDictionary<string, object> description);
void Accept();
}
}

View File

@ -1,11 +1,9 @@
// Copyright (c) Microsoft Open Technologies, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Security.Claims;
using System.Security.Principal;
namespace Microsoft.AspNet.Http.Security
namespace Microsoft.AspNet.Http.Authentication
{
/// <summary>
/// Acts as the return value from calls to the IAuthenticationManager's AuthenticeAsync methods.
@ -18,21 +16,18 @@ namespace Microsoft.AspNet.Http.Security
/// <param name="identity">Assigned to Identity. May be null.</param>
/// <param name="properties">Assigned to Properties. Contains extra information carried along with the identity.</param>
/// <param name="description">Assigned to Description. Contains information describing the authentication provider.</param>
public AuthenticationResult(IIdentity identity, [NotNull] AuthenticationProperties properties, [NotNull] AuthenticationDescription description)
public AuthenticationResult(ClaimsPrincipal principal, [NotNull] AuthenticationProperties properties, [NotNull] AuthenticationDescription description)
{
if (identity != null)
{
Identity = identity as ClaimsIdentity ?? new ClaimsIdentity(identity);
}
Principal = principal;
Properties = properties;
Description = description;
}
/// <summary>
/// Contains the claims that were authenticated by the given AuthenticationType. If the authentication
/// type was not successful the Identity property will be null.
/// Contains the claims that were authenticated by the given AuthenticationScheme. If the authentication
/// scheme was not successful the Identity property will be null.
/// </summary>
public ClaimsIdentity Identity { get; private set; }
public ClaimsPrincipal Principal { get; private set; }
/// <summary>
/// Contains extra values that were provided with the original SignIn call.

View File

@ -5,7 +5,7 @@ using System;
using System.Collections.Generic;
using System.Globalization;
namespace Microsoft.AspNet.Http.Security
namespace Microsoft.AspNet.Http.Authentication
{
/// <summary>
/// Contains information describing an authentication provider.
@ -13,7 +13,7 @@ namespace Microsoft.AspNet.Http.Security
public class AuthenticationDescription
{
private const string CaptionPropertyKey = "Caption";
private const string AuthenticationTypePropertyKey = "AuthenticationType";
private const string AuthenticationSchemePropertyKey = "AuthenticationScheme";
/// <summary>
/// Initializes a new instance of the <see cref="AuthenticationDescription"/> class
@ -40,10 +40,10 @@ namespace Microsoft.AspNet.Http.Security
/// <summary>
/// Gets or sets the name used to reference the authentication middleware instance.
/// </summary>
public string AuthenticationType
public string AuthenticationScheme
{
get { return GetString(AuthenticationTypePropertyKey); }
set { Dictionary[AuthenticationTypePropertyKey] = value; }
get { return GetString(AuthenticationSchemePropertyKey); }
set { Dictionary[AuthenticationSchemePropertyKey] = value; }
}
/// <summary>

View File

@ -6,7 +6,7 @@ using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
namespace Microsoft.AspNet.Http.Security
namespace Microsoft.AspNet.Http.Authentication
{
/// <summary>
/// Dictionary used to store state values about the authentication session.

View File

@ -8,7 +8,7 @@ using System.Net.WebSockets;
using System.Security.Claims;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNet.Http.Security;
using Microsoft.AspNet.Http.Authentication;
namespace Microsoft.AspNet.Http
{
@ -52,21 +52,21 @@ namespace Microsoft.AspNet.Http
SetFeature(typeof(T), instance);
}
public abstract IEnumerable<AuthenticationDescription> GetAuthenticationTypes();
public abstract IEnumerable<AuthenticationDescription> GetAuthenticationSchemes();
public virtual AuthenticationResult Authenticate(string authenticationType)
public virtual AuthenticationResult Authenticate(string authenticationScheme)
{
return Authenticate(new[] { authenticationType }).SingleOrDefault();
return Authenticate(new[] { authenticationScheme }).SingleOrDefault();
}
public abstract IEnumerable<AuthenticationResult> Authenticate(IEnumerable<string> authenticationTypes);
public abstract IEnumerable<AuthenticationResult> Authenticate(IEnumerable<string> authenticationSchemes);
public virtual async Task<AuthenticationResult> AuthenticateAsync(string authenticationType)
public virtual async Task<AuthenticationResult> AuthenticateAsync(string authenticationScheme)
{
return (await AuthenticateAsync(new[] { authenticationType })).SingleOrDefault();
return (await AuthenticateAsync(new[] { authenticationScheme })).SingleOrDefault();
}
public abstract Task<IEnumerable<AuthenticationResult>> AuthenticateAsync(IEnumerable<string> authenticationTypes);
public abstract Task<IEnumerable<AuthenticationResult>> AuthenticateAsync(IEnumerable<string> authenticationSchemes);
public virtual Task<WebSocket> AcceptWebSocketAsync()
{

View File

@ -5,7 +5,7 @@ using System;
using System.Collections.Generic;
using System.IO;
using System.Security.Claims;
using Microsoft.AspNet.Http.Security;
using Microsoft.AspNet.Http.Authentication;
namespace Microsoft.AspNet.Http
{
@ -44,70 +44,40 @@ namespace Microsoft.AspNet.Http
Challenge(properties, new string[0]);
}
public virtual void Challenge(string authenticationType)
public virtual void Challenge(string authenticationScheme)
{
Challenge(new[] { authenticationType });
Challenge(new[] { authenticationScheme });
}
public virtual void Challenge(AuthenticationProperties properties, string authenticationType)
public virtual void Challenge(AuthenticationProperties properties, string authenticationScheme)
{
Challenge(properties, new[] { authenticationType });
Challenge(properties, new[] { authenticationScheme });
}
public virtual void Challenge(params string[] authenticationTypes)
public virtual void Challenge(params string[] authenticationSchemes)
{
Challenge((IEnumerable<string>)authenticationTypes);
Challenge((IEnumerable<string>)authenticationSchemes);
}
public virtual void Challenge(IEnumerable<string> authenticationTypes)
public virtual void Challenge(IEnumerable<string> authenticationSchemes)
{
Challenge(properties: null, authenticationTypes: authenticationTypes);
Challenge(properties: null, authenticationSchemes: authenticationSchemes);
}
public virtual void Challenge(AuthenticationProperties properties, params string[] authenticationTypes)
public virtual void Challenge(AuthenticationProperties properties, params string[] authenticationSchemes)
{
Challenge(properties, (IEnumerable<string>)authenticationTypes);
Challenge(properties, (IEnumerable<string>)authenticationSchemes);
}
public abstract void Challenge(AuthenticationProperties properties, IEnumerable<string> authenticationTypes);
public abstract void Challenge(AuthenticationProperties properties, IEnumerable<string> authenticationSchemes);
public virtual void SignIn(ClaimsIdentity identity)
{
SignIn(properties: null, identity: identity);
}
public virtual void SignIn(AuthenticationProperties properties, ClaimsIdentity identity)
{
SignIn(properties, new[] { identity });
}
public virtual void SignIn(params ClaimsIdentity[] identities)
{
SignIn(properties: null, identities: (IEnumerable<ClaimsIdentity>)identities);
}
public virtual void SignIn(IEnumerable<ClaimsIdentity> identities)
{
SignIn(properties: null, identities: identities);
}
public virtual void SignIn(AuthenticationProperties properties, params ClaimsIdentity[] identities)
{
SignIn(properties, (IEnumerable<ClaimsIdentity>)identities);
}
public abstract void SignIn(AuthenticationProperties properties, IEnumerable<ClaimsIdentity> identities);
public abstract void SignIn(string authenticationScheme, ClaimsPrincipal principal, AuthenticationProperties properties = null);
public virtual void SignOut()
{
SignOut(new string[0]);
SignOut(authenticationScheme: null);
}
public virtual void SignOut(string authenticationType)
{
SignOut(new[] { authenticationType });
}
public abstract void SignOut(IEnumerable<string> authenticationTypes);
public abstract void SignOut(string authenticationScheme);
}
}

View File

@ -14,9 +14,9 @@ using System.Security.Principal;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNet.Http;
using Microsoft.AspNet.Http.Core.Authentication;
using Microsoft.AspNet.Http.Interfaces;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Core.Security;
using Microsoft.AspNet.Http.Interfaces.Authentication;
namespace Microsoft.AspNet.Owin
{

View File

@ -16,7 +16,7 @@ using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNet.FeatureModel;
using Microsoft.AspNet.Http.Interfaces;
using Microsoft.AspNet.Http.Interfaces.Security;
using Microsoft.AspNet.Http.Interfaces.Authentication;
namespace Microsoft.AspNet.Owin
{

View File

@ -3,13 +3,12 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Security.Claims;
using System.Threading.Tasks;
using Microsoft.AspNet.Http;
using Microsoft.AspNet.FeatureModel;
using Microsoft.AspNet.Http.Interfaces;
using Microsoft.AspNet.Http.Core.Authentication;
using Microsoft.AspNet.Http.Interfaces.Authentication;
using Xunit;
namespace Microsoft.AspNet.Http.Core.Tests
@ -66,7 +65,7 @@ namespace Microsoft.AspNet.Http.Core.Tests
public void SignInWithNoAuthMiddlewareThrows()
{
var context = CreateContext();
Assert.Throws<InvalidOperationException>(() => context.Response.SignIn(new ClaimsIdentity("Foo")));
Assert.Throws<InvalidOperationException>(() => context.Response.SignIn("Foo", new ClaimsPrincipal()));
}
[Fact]
@ -78,6 +77,58 @@ namespace Microsoft.AspNet.Http.Core.Tests
Assert.Throws<InvalidOperationException>(() => context.Response.SignOut("Foo"));
}
[Fact]
public void SignInOutIn()
{
var context = CreateContext();
var handler = new AuthHandler();
context.SetFeature<IHttpAuthenticationFeature>(new HttpAuthenticationFeature() { Handler = handler });
var user = new ClaimsPrincipal();
context.Response.SignIn("ignored", user);
Assert.True(handler.SignedIn);
context.Response.SignOut("ignored");
Assert.False(handler.SignedIn);
context.Response.SignIn("ignored", user);
Assert.True(handler.SignedIn);
}
private class AuthHandler : IAuthenticationHandler
{
public bool SignedIn { get; set; }
public void Authenticate(IAuthenticateContext context)
{
throw new NotImplementedException();
}
public Task AuthenticateAsync(IAuthenticateContext context)
{
throw new NotImplementedException();
}
public void Challenge(IChallengeContext context)
{
throw new NotImplementedException();
}
public void GetDescriptions(IDescribeSchemesContext context)
{
throw new NotImplementedException();
}
public void SignIn(ISignInContext context)
{
SignedIn = true;
context.Accept(new Dictionary<string, object>());
}
public void SignOut(ISignOutContext context)
{
SignedIn = false;
context.Accept();
}
}
private HttpContext CreateContext()
{
var context = new DefaultHttpContext();