diff --git a/src/Microsoft.AspNetCore.Razor.Evolution/Properties/Resources.Designer.cs b/src/Microsoft.AspNetCore.Razor.Evolution/Properties/Resources.Designer.cs index dc78770483..3f65819cbf 100644 --- a/src/Microsoft.AspNetCore.Razor.Evolution/Properties/Resources.Designer.cs +++ b/src/Microsoft.AspNetCore.Razor.Evolution/Properties/Resources.Designer.cs @@ -136,20 +136,6 @@ namespace Microsoft.AspNetCore.Razor.Evolution internal static string FormatTagHelperAssemblyNameCannotBeEmptyOrNull() => GetString("TagHelperAssemblyNameCannotBeEmptyOrNull"); - /// - /// The assembly '{0}' could not be resolved or contains no tag helpers. - /// - internal static string TagHelperAssemblyCouldNotBeResolved - { - get => GetString("TagHelperAssemblyCouldNotBeResolved"); - } - - /// - /// The assembly '{0}' could not be resolved or contains no tag helpers. - /// - internal static string FormatTagHelperAssemblyCouldNotBeResolved(object p0) - => string.Format(CultureInfo.CurrentCulture, GetString("TagHelperAssemblyCouldNotBeResolved"), p0); - /// /// Path must begin with a forward slash '/'. /// diff --git a/src/Microsoft.AspNetCore.Razor.Evolution/Resources.resx b/src/Microsoft.AspNetCore.Razor.Evolution/Resources.resx index 6db3b53ac4..7040315c9e 100644 --- a/src/Microsoft.AspNetCore.Razor.Evolution/Resources.resx +++ b/src/Microsoft.AspNetCore.Razor.Evolution/Resources.resx @@ -144,9 +144,6 @@ Tag helper directive assembly name cannot be null or empty. - - The assembly '{0}' could not be resolved or contains no tag helpers. - Path must begin with a forward slash '/'. diff --git a/src/Microsoft.AspNetCore.Razor.Evolution/TagHelperBinderSyntaxTreePass.cs b/src/Microsoft.AspNetCore.Razor.Evolution/TagHelperBinderSyntaxTreePass.cs index 649b2dba4c..5f14360255 100644 --- a/src/Microsoft.AspNetCore.Razor.Evolution/TagHelperBinderSyntaxTreePass.cs +++ b/src/Microsoft.AspNetCore.Razor.Evolution/TagHelperBinderSyntaxTreePass.cs @@ -138,12 +138,7 @@ namespace Microsoft.AspNetCore.Razor.Evolution if (!AssemblyContainsTagHelpers(parsed.AssemblyName, tagHelpers)) { - errorSink.OnError( - parsed.AssemblyNameLocation, - Resources.FormatTagHelperAssemblyCouldNotBeResolved(parsed.AssemblyName), - parsed.AssemblyName.Length); - - // Skip this one, it's an error + // No tag helpers in the assembly. break; } @@ -170,12 +165,7 @@ namespace Microsoft.AspNetCore.Razor.Evolution if (!AssemblyContainsTagHelpers(parsed.AssemblyName, tagHelpers)) { - errorSink.OnError( - parsed.AssemblyNameLocation, - Resources.FormatTagHelperAssemblyCouldNotBeResolved(parsed.AssemblyName), - parsed.AssemblyName.Length); - - // Skip this one, it's an error + // No tag helpers in the assembly. break; } diff --git a/test/Microsoft.AspNetCore.Razor.Evolution.Test/TagHelperBinderSyntaxTreePassTest.cs b/test/Microsoft.AspNetCore.Razor.Evolution.Test/TagHelperBinderSyntaxTreePassTest.cs index 4ef18892bc..a9c7000d1e 100644 --- a/test/Microsoft.AspNetCore.Razor.Evolution.Test/TagHelperBinderSyntaxTreePassTest.cs +++ b/test/Microsoft.AspNetCore.Razor.Evolution.Test/TagHelperBinderSyntaxTreePassTest.cs @@ -256,40 +256,6 @@ namespace Microsoft.AspNetCore.Razor.Evolution Assert.Empty(context.TagHelpers); } - [Fact] - public void Execute_AddsErrorWhenNoTagHelpersAreFoundInAssembly() - { - // Arrange - var engine = RazorEngine.Create(builder => - { - builder.Features.Add(new TestTagHelperFeature()); - }); - - var pass = new TagHelperBinderSyntaxTreePass() - { - Engine = engine, - }; - - var sourceDocument = CreateTestSourceDocument(); - var codeDocument = RazorCodeDocument.Create(sourceDocument); - var originalTree = RazorSyntaxTree.Parse(sourceDocument); - - var expectedError = RazorDiagnostic.Create( - new RazorError( - Resources.FormatTagHelperAssemblyCouldNotBeResolved("TestAssembly"), - new SourceLocation(Environment.NewLine.Length + 17, 1, 1), - length: 12)); - - // Act - var outputTree = pass.Execute(codeDocument, originalTree); - - // Assert - Assert.Same(originalTree.Root, outputTree.Root); - - var error = Assert.Single(outputTree.Diagnostics); - Assert.Equal(expectedError, error); - } - [Fact] public void Execute_RecreatesSyntaxTreeOnResolverErrors() {