huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove _tasksCompleted from SocketOutput 

- _tasksCompleted no longer helps avoid locking longer
This commit is contained in:
Stephen Halter 2016-01-07 16:10:05 -08:00
parent df695accb0
commit daa2b7e383
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Microsoft.AspNet.Server.Kestrel/Http/SocketOutput.cs
View File

@ -49,7 +49,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
private Exception _lastWriteError; private Exception _lastWriteError;
private WriteContext _nextWriteContext; private WriteContext _nextWriteContext;
private readonly Queue<TaskCompletionSource<object>> _tasksPending; private readonly Queue<TaskCompletionSource<object>> _tasksPending;
private readonly Queue<TaskCompletionSource<object>> _tasksCompleted;
private readonly Queue<WriteContext> _writeContextPool; private readonly Queue<WriteContext> _writeContextPool;
private readonly Queue<UvWriteReq> _writeReqPool; private readonly Queue<UvWriteReq> _writeReqPool;
@ -70,7 +69,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
_log = log; _log = log;
_threadPool = threadPool; _threadPool = threadPool;
_tasksPending = new Queue<TaskCompletionSource<object>>(_initialTaskQueues); _tasksPending = new Queue<TaskCompletionSource<object>>(_initialTaskQueues);
_tasksCompleted = new Queue<TaskCompletionSource<object>>(_initialTaskQueues);
_writeContextPool = new Queue<WriteContext>(_maxPooledWriteContexts); _writeContextPool = new Queue<WriteContext>(_maxPooledWriteContexts);
_writeReqPool = writeReqPool; _writeReqPool = writeReqPool;
@ -287,7 +285,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
var status = writeContext.WriteStatus; var status = writeContext.WriteStatus;
var error = writeContext.WriteError; var error = writeContext.WriteError;
if (error != null) if (error != null)
{ {
_lastWriteError = new IOException(error.Message, error); _lastWriteError = new IOException(error.Message, error);
@ -314,12 +311,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
_numBytesPreCompleted += bytesToWrite; _numBytesPreCompleted += bytesToWrite;
bytesLeftToBuffer -= bytesToWrite; bytesLeftToBuffer -= bytesToWrite;
_tasksCompleted.Enqueue(tcs);
}
while (_tasksCompleted.Count > 0)
{
var tcs = _tasksCompleted.Dequeue();
if (_lastWriteError == null) if (_lastWriteError == null)
{ {
_threadPool.Complete(tcs); _threadPool.Complete(tcs);
@ -331,7 +322,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
} }
_log.ConnectionWriteCallback(_connectionId, status); _log.ConnectionWriteCallback(_connectionId, status);
_tasksCompleted.Clear();
} }
// This is called on the libuv event loop // This is called on the libuv event loop