huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add request parsing regression tests.

This commit is contained in:
Cesar Blum Silveira 2017-09-13 14:49:45 -07:00 committed by GitHub
parent 1e465e9643
commit da7bc24eec
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/Kestrel.FunctionalTests/BadHttpRequestTests.cs
View File

@ -169,6 +169,22 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
Assert.Equal(LogLevel.Information, maxLogLevel); Assert.Equal(LogLevel.Information, maxLogLevel);
} }
[Fact]
public async Task TestRequestSplitting()
{
using (var server = new TestServer(context => Task.CompletedTask, new TestServiceContext { Log = Mock.Of<IKestrelTrace>() }))
{
using (var client = server.CreateConnection())
{
await client.SendAll(
"GET /\x0D\0x0ALocation:http://www.contoso.com/ HTTP/1.1",
"Host:\r\n\r\n");
await client.ReceiveStartsWith("HTTP/1.1 400");
}
}
}
private async Task TestBadRequest(string request, string expectedResponseStatusCode, string expectedExceptionMessage, string expectedAllowHeader = null) private async Task TestBadRequest(string request, string expectedResponseStatusCode, string expectedExceptionMessage, string expectedAllowHeader = null)
{ {
BadHttpRequestException loggedException = null; BadHttpRequestException loggedException = null;

2
test/shared/HttpParsingData.cs
View File

@ -219,6 +219,7 @@ namespace Microsoft.AspNetCore.Testing
"}", "}",
"get@", "get@",
"post=", "post=",
"[0x00]"
}.Concat(MethodWithNullCharData); }.Concat(MethodWithNullCharData);
} }
} }
@ -435,6 +436,7 @@ namespace Microsoft.AspNetCore.Testing
{ "OPTIONS *", "" }, { "OPTIONS *", "" },
{ "GET /pub/WWW/", "" }, { "GET /pub/WWW/", "" },
{ "GET /pub/WWW/", " " }, { "GET /pub/WWW/", " " },
{ "GET /pub/WWW/", "." },
{ "GET /pub/WWW/", "www.example.org" }, { "GET /pub/WWW/", "www.example.org" },
{ "GET http://localhost/", "localhost" }, { "GET http://localhost/", "localhost" },
{ "GET http://localhost:80/", "localhost:80" }, { "GET http://localhost:80/", "localhost:80" },