From d775e9d959be0706e094e814ce7ded93e6bdd72a Mon Sep 17 00:00:00 2001
From: Brennan <brecon@microsoft.com>
Date: Wed, 22 Apr 2020 15:36:40 -0700
Subject: [PATCH] Fixing build warnings (#21044)

---
 NuGet.config                                  |  2 ++
 .../IIS.Performance/FirstRequestConfig.cs     | 20 +++++++++----------
 .../LoggingBranch/Directory.Build.targets     |  3 +++
 src/SiteExtensions/LoggingBranch/LB.csproj    |  3 ---
 4 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/NuGet.config b/NuGet.config
index 618ac88e70..d12badea78 100644
--- a/NuGet.config
+++ b/NuGet.config
@@ -11,5 +11,7 @@
     <add key="aspnetcore-dev" value="https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json" />
     <add key="aspnetcore-tools" value="https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json" />
     <add key="roslyn-tools" value="https://dotnet.myget.org/F/roslyn-tools/api/v3/index.json" />
+    <!-- Used for the SiteExtension 3.1 bits that are included in the 5.0 build -->
+    <add key="dotnet31-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet3.1-transport/nuget/v3/index.json" />
   </packageSources>
 </configuration>
diff --git a/src/Servers/IIS/IIS/benchmarks/IIS.Performance/FirstRequestConfig.cs b/src/Servers/IIS/IIS/benchmarks/IIS.Performance/FirstRequestConfig.cs
index c048b28f8d..6f288119d3 100644
--- a/src/Servers/IIS/IIS/benchmarks/IIS.Performance/FirstRequestConfig.cs
+++ b/src/Servers/IIS/IIS/benchmarks/IIS.Performance/FirstRequestConfig.cs
@@ -18,22 +18,22 @@ namespace BenchmarkDotNet.Attributes
     {
         public FirstRequestConfig()
         {
-            Add(ConsoleLogger.Default);
-            Add(MarkdownExporter.GitHub);
+            AddLogger(ConsoleLogger.Default);
+            AddExporter(MarkdownExporter.GitHub);
 
-            Add(MemoryDiagnoser.Default);
-            Add(StatisticColumn.OperationsPerSecond);
-            Add(DefaultColumnProviders.Instance);
+            AddDiagnoser(MemoryDiagnoser.Default);
+            AddColumn(StatisticColumn.OperationsPerSecond);
+            AddColumnProvider(DefaultColumnProviders.Instance);
 
-            Add(JitOptimizationsValidator.FailOnError);
+            AddValidator(JitOptimizationsValidator.FailOnError);
 
-            Add(Job.Default
-                .With(CsProjCoreToolchain.From(NetCoreAppSettings.NetCoreApp21))
-                .With(new GcMode { Server = true })
+            AddJob(Job.Default
+                .WithToolchain(CsProjCoreToolchain.From(NetCoreAppSettings.NetCoreApp21))
+                .WithGcMode(new GcMode { Server = true })
                 .WithIterationCount(10)
                 .WithInvocationCount(1)
                 .WithUnrollFactor(1)
-                .With(RunStrategy.ColdStart));
+                .WithStrategy(RunStrategy.ColdStart));
         }
     }
 }
diff --git a/src/SiteExtensions/LoggingBranch/Directory.Build.targets b/src/SiteExtensions/LoggingBranch/Directory.Build.targets
index bc9e13c2e2..30a20538f2 100644
--- a/src/SiteExtensions/LoggingBranch/Directory.Build.targets
+++ b/src/SiteExtensions/LoggingBranch/Directory.Build.targets
@@ -22,4 +22,7 @@
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
   </PropertyGroup>
 
+  <!-- No code in this project to compile. -->
+  <Target Name="Compile" />
+
 </Project>
diff --git a/src/SiteExtensions/LoggingBranch/LB.csproj b/src/SiteExtensions/LoggingBranch/LB.csproj
index 1cf9f52287..5367207897 100644
--- a/src/SiteExtensions/LoggingBranch/LB.csproj
+++ b/src/SiteExtensions/LoggingBranch/LB.csproj
@@ -31,9 +31,6 @@
     </ProjectReference>
   </ItemGroup>
 
-  <!-- No code in this project to compile. -->
-  <Target Name="Compile" />
-
   <!-- Cannot assume this project and Microsoft.AspNetCore.AzureAppServices.HostingStartup have the same package version. -->
   <Target Name="_GetHostingStartupPackageReference" BeforeTargets="GenerateHostingStartupDeps">
     <!-- This target is defined in eng/targets/Packaging.targets and included in every C# and F# project. -->