huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid use of AssemblyQualifiedName in tests 

The type name generated by Razor is an implementation detail and
shouldn't be used in tests outside of the Razor repo. Testing that the
assembly name is correct should be enough to validate what we need for
these tests.
This commit is contained in:
Ryan Nowak 2018-01-13 18:24:50 -08:00
parent c3dedd9feb
commit d686acad87
19 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/FunctionalTests/Resources/ApplicationConsumingPrecompiledViews.Manage.Home.Index.txt
View File

@ -1,7 +1,7 @@
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<body> <body>
AspNetCore._Areas_Manage_Views_Shared__Layout_cshtml, ClassLibraryWithPrecompiledViews.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ClassLibraryWithPrecompiledViews.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
<h1>Admin home page</h1> <h1>Admin home page</h1>

2
test/FunctionalTests/Resources/ApplicationUsingRelativePaths.Home.About.txt
View File

@ -2,7 +2,7 @@
<html> <html>
<body> <body>
AspNetCore._Views_Home_Index_cshtml, ApplicationUsingRelativePaths.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ApplicationUsingRelativePaths.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
Hello from Index! Hello from Index!
</body> </body>
</html> </html>

2
test/FunctionalTests/Resources/ApplicationUsingRelativePaths.Home.Index.txt
View File

@ -2,7 +2,7 @@
<html> <html>
<body> <body>
AspNetCore._Views_Home_Index_cshtml, ApplicationUsingRelativePaths.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ApplicationUsingRelativePaths.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
Hello from Index! Hello from Index!
</body> </body>
</html> </html>

2
test/FunctionalTests/Resources/ApplicationWithConfigureMvc.Home.Index.txt
View File

@ -1,2 +1,2 @@
AspNetCore._Views_Home_Index_cshtml, ApplicationWithConfigureMvc.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ApplicationWithConfigureMvc.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
<br />Hello world! <br />Hello world!

4
test/FunctionalTests/Resources/ApplicationWithTagHelpers.Home.ClassLibraryTagHelper.txt
View File

@ -8,7 +8,7 @@
<body> <body>
<div class="container body-content"> <div class="container body-content">
AspNetCore._Views_Home_ClassLibraryTagHelper_cshtml, ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
<div><b>To boldy tag that no one has ever tagged before...</b></div> <div><b>To boldy tag that no one has ever tagged before...</b></div>
@ -20,6 +20,6 @@ AspNetCore._Views_Home_ClassLibraryTagHelper_cshtml, ApplicationWithTagHelpers.P
</footer> </footer>
</div> </div>
AspNetCore._Views_Shared__Layout_cshtml, ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
</body> </body>
</html> </html>

4
test/FunctionalTests/Resources/ApplicationWithTagHelpers.Home.LocalTagHelper.txt
View File

@ -8,7 +8,7 @@
<body> <body>
<div class="container body-content"> <div class="container body-content">
AspNetCore._Views_Home_LocalTagHelper_cshtml, ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
<test href="/Home/About">TestTagHelper content.</test> <test href="/Home/About">TestTagHelper content.</test>
@ -20,6 +20,6 @@ AspNetCore._Views_Home_LocalTagHelper_cshtml, ApplicationWithTagHelpers.Precompi
</footer> </footer>
</div> </div>
AspNetCore._Views_Shared__Layout_cshtml, ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null ApplicationWithTagHelpers.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
</body> </body>
</html> </html>

4
test/FunctionalTests/Resources/SimpleAppTest.Home.Index.txt
View File

@ -35,7 +35,7 @@
</div> </div>
<div class="container body-content"> <div class="container body-content">
AspNetCore._Views_Home_Index_cshtml, SimpleApp.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null SimpleApp.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
<div id="myCarousel" class="carousel slide" data-ride="carousel" data-interval="6000"> <div id="myCarousel" class="carousel slide" data-ride="carousel" data-interval="6000">
<ol class="carousel-indicators"> <ol class="carousel-indicators">
<li data-target="#myCarousel" data-slide-to="0" class="active"></li> <li data-target="#myCarousel" data-slide-to="0" class="active"></li>
@ -160,6 +160,6 @@ AspNetCore._Views_Home_Index_cshtml, SimpleApp.PrecompiledViews, Version=1.0.0.0
AspNetCore._Views_Shared__Layout_cshtml, SimpleApp.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null SimpleApp.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null
</body> </body>
</html> </html>

2
test/FunctionalTests/Resources/SimpleAppWithAssemblyRenameTest.Home.Index.txt
View File

@ -1,2 +1,2 @@
AspNetCore._Views_Home_Index_cshtml, NewAssemblyName.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null NewAssemblyName.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null

2
test/FunctionalTests/Resources/StrongNamedApp.Home.Index.txt
View File

@ -1 +1 @@
Hello from view in AspNetCore._Views_Home_Index_cshtml, StrongNamedApp.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60 Hello from view in StrongNamedApp.PrecompiledViews, Version=1.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60

2
testapps/ApplicationUsingRelativePaths/Views/Home/Index.cshtml
View File

@ -2,5 +2,5 @@
ViewData["Title"] = "Home Page"; ViewData["Title"] = "Home Page";
} }
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
Hello from Index! Hello from Index!

2
testapps/ApplicationWithConfigureMvc/Views/Home/Index.cshtml
View File

@ -1,2 +1,2 @@
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
Hello world! Hello world!

2
testapps/ApplicationWithTagHelpers/Views/Home/ClassLibraryTagHelper.cshtml
View File

@ -1,6 +1,6 @@
@addTagHelper *, ClassLibraryTagHelper @addTagHelper *, ClassLibraryTagHelper
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
<div bold="bold">To boldy tag that no one has ever tagged before...</div> <div bold="bold">To boldy tag that no one has ever tagged before...</div>

2
testapps/ApplicationWithTagHelpers/Views/Home/LocalTagHelper.cshtml
View File

@ -1,6 +1,6 @@
@addTagHelper *, ApplicationWithTagHelpers @addTagHelper *, ApplicationWithTagHelpers
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
<test controller="Home" action="About"></test> <test controller="Home" action="About"></test>

2
testapps/ApplicationWithTagHelpers/Views/Shared/_Layout.cshtml
View File

@ -16,6 +16,6 @@
</footer> </footer>
</div> </div>
@RenderSection("scripts", required: false) @RenderSection("scripts", required: false)
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
</body> </body>
</html> </html>

2
testapps/ClassLibraryWithPrecompiledViews/Areas/Manage/Views/Shared/_Layout.cshtml
View File

@ -1,7 +1,7 @@
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<body> <body>
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
@RenderBody() @RenderBody()
@RenderSection("TestSection") @RenderSection("TestSection")
</body> </body>

2
testapps/SimpleApp/Views/Home/Index.cshtml
View File

@ -2,7 +2,7 @@
ViewData["Title"] = "Home Page"; ViewData["Title"] = "Home Page";
} }
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
<div id="myCarousel" class="carousel slide" data-ride="carousel" data-interval="6000"> <div id="myCarousel" class="carousel slide" data-ride="carousel" data-interval="6000">
<ol class="carousel-indicators"> <ol class="carousel-indicators">
<li data-target="#myCarousel" data-slide-to="0" class="active"></li> <li data-target="#myCarousel" data-slide-to="0" class="active"></li>

2
testapps/SimpleApp/Views/Shared/_Layout.cshtml
View File

@ -63,6 +63,6 @@
</environment> </environment>
@RenderSection("scripts", required: false) @RenderSection("scripts", required: false)
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName
</body> </body>
</html> </html>

2
testapps/SimpleAppWithAssemblyRename/Views/Home/Index.cshtml
View File

@ -2,4 +2,4 @@
ViewData["Title"] = "Home Page"; ViewData["Title"] = "Home Page";
} }
@GetType().AssemblyQualifiedName @GetType().Assembly.FullName

2
testapps/StrongNamedApp/Views/Home/Index.cshtml
View File

@ -1 +1 @@
Hello from view in @GetType().AssemblyQualifiedName Hello from view in @GetType().Assembly.FullName