Prefer BeforeTargets/AfterTargets over evaluation

We can't rely on property evaluation to attach targets to the build
lifecycle, as we rely on the web sdk to set these properties and they
run after us.
This commit is contained in:
Ryan Nowak 2018-01-18 17:58:52 -08:00
parent eaa201703d
commit d4ed8a7b77
1 changed files with 6 additions and 6 deletions

View File

@ -124,11 +124,6 @@
<Target Name="RazorCompile" DependsOnTargets="$(RazorCompileDependsOn)">
</Target>
<PropertyGroup Condition="'$(RazorCompileOnBuild)'=='true'">
<PrepareForRunDependsOn>RazorCompile;$(PrepareForRunDependsOn);_RazorCopyFilesToOutputDirectory</PrepareForRunDependsOn>
<GetCopyToOutputDirectoryItemsDependsOn>$(GetCopyToOutputDirectoryItemsDependsOn);_RazorGetCopyToOutputDirectoryItems</GetCopyToOutputDirectoryItemsDependsOn>
</PropertyGroup>
<!--
Gathers input source files for code generation. This is a separate target so that we can avoid
lots of work when there are no inputs for code generation.
@ -193,6 +188,7 @@
-->
<Target
Name="_RazorGetCopyToOutputDirectoryItems"
BeforeTargets="GetCopyToOutputDirectoryItems"
DependsOnTargets="RazorCompile"
Condition="'$(RazorCompileOnBuild)'=='true'">
@ -247,7 +243,11 @@
Called as part of CopyFilesToOutputDirectory - this target is called when building the project to copy
files to the output directory.
-->
<Target Name="_RazorCopyFilesToOutputDirectory">
<Target
Name="_RazorCopyFilesToOutputDirectory"
DependsOnTargets="RazorCompile"
AfterTargets="CopyFilesToOutputDirectory"
Condition="'$(RazorCompileOnBuild)'=='true'">
<!-- Copy the Razor dll -->
<Copy