From d4773e831ccf1ca9c157e312028086ed6a12ec75 Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Thu, 12 Apr 2018 18:23:00 +1200 Subject: [PATCH] Set default transport and application buffer sizes (#1964) --- .../HttpConnectionOptions.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.AspNetCore.Http.Connections/HttpConnectionOptions.cs b/src/Microsoft.AspNetCore.Http.Connections/HttpConnectionOptions.cs index a651e7a0ea..62a88cd6ca 100644 --- a/src/Microsoft.AspNetCore.Http.Connections/HttpConnectionOptions.cs +++ b/src/Microsoft.AspNetCore.Http.Connections/HttpConnectionOptions.cs @@ -9,14 +9,18 @@ namespace Microsoft.AspNetCore.Http.Connections { public class HttpConnectionOptions { + // Selected because this is the default value of PipeWriter.PauseWriterThreshold. + // There maybe the opportunity for performance gains by tuning this default. + private const int DefaultPipeBufferSize = 32768; + public HttpConnectionOptions() { AuthorizationData = new List(); Transports = HttpTransports.All; WebSockets = new WebSocketOptions(); LongPolling = new LongPollingOptions(); - TransportMaxBufferSize = 0; - ApplicationMaxBufferSize = 0; + TransportMaxBufferSize = DefaultPipeBufferSize; + ApplicationMaxBufferSize = DefaultPipeBufferSize; } public IList AuthorizationData { get; }