huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove message content from JS client logging (#1694)

This commit is contained in:
James Newton-King 2018-03-23 17:24:51 +13:00 committed by GitHub
parent a47e1051e8
commit d367bdc9aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clients/ts/signalr/src/HubConnection.ts
View File

@ -95,7 +95,7 @@ export class HubConnection {
this.connection.stop(message.error ? new Error("Server returned an error on close: " + message.error) : null); this.connection.stop(message.error ? new Error("Server returned an error on close: " + message.error) : null);
break; break;
default: default:
this.logger.log(LogLevel.Warning, "Invalid message type: " + data); this.logger.log(LogLevel.Warning, "Invalid message type: " + message.type);
break; break;
} }
} }

16
clients/ts/signalr/src/Transports.ts
View File

@ -71,7 +71,7 @@ export class WebSocketTransport implements ITransport {
}; };
webSocket.onmessage = (message: MessageEvent) => { webSocket.onmessage = (message: MessageEvent) => {
this.logger.log(LogLevel.Trace, `(WebSockets transport) data received: ${message.data}`); this.logger.log(LogLevel.Trace, `(WebSockets transport) data received. Length ${getDataLength(message.data)}.`);
if (this.onreceive) { if (this.onreceive) {
this.onreceive(message.data); this.onreceive(message.data);
} }
@ -151,7 +151,7 @@ export class ServerSentEventsTransport implements ITransport {
eventSource.onmessage = (e: MessageEvent) => { eventSource.onmessage = (e: MessageEvent) => {
if (this.onreceive) { if (this.onreceive) {
try { try {
this.logger.log(LogLevel.Trace, `(SSE transport) data received: ${e.data}`); this.logger.log(LogLevel.Trace, `(SSE transport) data received. Length ${getDataLength(e.data)}.`);
this.onreceive(e.data); this.onreceive(e.data);
} catch (error) { } catch (error) {
if (this.onclose) { if (this.onclose) {
@ -276,7 +276,7 @@ export class LongPollingTransport implements ITransport {
} else { } else {
// Process the response // Process the response
if (response.content) { if (response.content) {
this.logger.log(LogLevel.Trace, `(LongPolling transport) data received: ${response.content}`); this.logger.log(LogLevel.Trace, `(LongPolling transport) data received. Length ${getDataLength(response.content)}.`);
if (this.onreceive) { if (this.onreceive) {
this.onreceive(response.content); this.onreceive(response.content);
} }
@ -313,6 +313,16 @@ export class LongPollingTransport implements ITransport {
public onclose: TransportClosed; public onclose: TransportClosed;
} }
function getDataLength(data: any): number {
let length: number = null;
if (data instanceof ArrayBuffer) {
length = data.byteLength;
} else if (data instanceof String) {
length = data.length;
}
return length;
}
async function send(httpClient: HttpClient, url: string, accessTokenFactory: () => string, content: string | ArrayBuffer): Promise<void> { async function send(httpClient: HttpClient, url: string, accessTokenFactory: () => string, content: string | ArrayBuffer): Promise<void> {
let headers; let headers;
const token = accessTokenFactory(); const token = accessTokenFactory();