Change APIs to internal in Diagnostics

These types are still used, but we don't want them to be public.

src/Middleware/Diagnostics.EntityFrameworkCore/ref/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.netcoreapp3.0.cs

@@ -46,53 +46,3 @@ namespace Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore
         public virtual System.Threading.Tasks.Task Invoke(Microsoft.AspNetCore.Http.HttpContext context) { throw null; }
     }
 }
-namespace Microsoft.AspNetCore.DiagnosticsViewPage.Views
-{
-    [System.ObsoleteAttribute("This type is for internal use only and will be removed in a future version.")]
-    public partial class AttributeValue
-    {
-        public AttributeValue(string prefix, object value, bool literal) { }
-        public bool Literal { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public string Prefix { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public object Value { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public static Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue FromTuple(System.Tuple<string, object, bool> value) { throw null; }
-        public static Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue FromTuple(System.Tuple<string, string, bool> value) { throw null; }
-        public static implicit operator Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue (System.Tuple<string, object, bool> value) { throw null; }
-    }
-    [System.ObsoleteAttribute("This type is for internal use only and will be removed in a future version.")]
-    public abstract partial class BaseView
-    {
-        protected BaseView() { }
-        protected Microsoft.AspNetCore.Http.HttpContext Context { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected System.Text.Encodings.Web.HtmlEncoder HtmlEncoder { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
-        protected System.Text.Encodings.Web.JavaScriptEncoder JavaScriptEncoder { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
-        protected System.IO.StreamWriter Output { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected Microsoft.AspNetCore.Http.HttpRequest Request { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected Microsoft.AspNetCore.Http.HttpResponse Response { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected System.Text.Encodings.Web.UrlEncoder UrlEncoder { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
-        protected void BeginWriteAttribute(string name, string begining, int startPosition, string ending, int endPosition, int thingy) { }
-        protected void EndWriteAttribute() { }
-        public abstract System.Threading.Tasks.Task ExecuteAsync();
-        [System.Diagnostics.DebuggerStepThroughAttribute]
-        public System.Threading.Tasks.Task ExecuteAsync(Microsoft.AspNetCore.Http.HttpContext context) { throw null; }
-        protected string HtmlEncodeAndReplaceLineBreaks(string input) { throw null; }
-        protected void Write(Microsoft.AspNetCore.DiagnosticsViewPage.Views.HelperResult result) { }
-        protected void Write(object value) { }
-        protected void Write(string value) { }
-        protected void WriteAttributeTo(System.IO.TextWriter writer, string name, string leader, string trailer, params Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue[] values) { }
-        protected void WriteAttributeValue(string thingy, int startPostion, object value, int endValue, int dealyo, bool yesno) { }
-        protected void WriteLiteral(object value) { }
-        protected void WriteLiteral(string value) { }
-        protected void WriteLiteralTo(System.IO.TextWriter writer, object value) { }
-        protected void WriteLiteralTo(System.IO.TextWriter writer, string value) { }
-        protected void WriteTo(System.IO.TextWriter writer, object value) { }
-        protected void WriteTo(System.IO.TextWriter writer, string value) { }
-    }
-    [System.ObsoleteAttribute("This type is for internal use only and will be removed in a future version.")]
-    public partial class HelperResult
-    {
-        public HelperResult(System.Action<System.IO.TextWriter> action) { }
-        public System.Action<System.IO.TextWriter> WriteAction { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public void WriteTo(System.IO.TextWriter writer) { }
-    }
-}

src/Middleware/Diagnostics/ref/Microsoft.AspNetCore.Diagnostics.netcoreapp3.0.cs

@@ -106,63 +106,3 @@ namespace Microsoft.AspNetCore.Diagnostics
         public System.Threading.Tasks.Task Invoke(Microsoft.AspNetCore.Http.HttpContext context) { throw null; }
     }
 }
-namespace Microsoft.AspNetCore.Diagnostics.Views
-{
-    [System.ObsoleteAttribute("This type is for internal use only and will be removed in a future version.")]
-    public partial class WelcomePage : Microsoft.AspNetCore.DiagnosticsViewPage.Views.BaseView
-    {
-        public WelcomePage() { }
-        [System.Diagnostics.DebuggerStepThroughAttribute]
-        public override System.Threading.Tasks.Task ExecuteAsync() { throw null; }
-    }
-}
-namespace Microsoft.AspNetCore.DiagnosticsViewPage.Views
-{
-    [System.ObsoleteAttribute("This type is for internal use only and will be removed in a future version.")]
-    public partial class AttributeValue
-    {
-        public AttributeValue(string prefix, object value, bool literal) { }
-        public bool Literal { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public string Prefix { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public object Value { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public static Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue FromTuple(System.Tuple<string, object, bool> value) { throw null; }
-        public static Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue FromTuple(System.Tuple<string, string, bool> value) { throw null; }
-        public static implicit operator Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue (System.Tuple<string, object, bool> value) { throw null; }
-    }
-    [System.ObsoleteAttribute("This type is for internal use only and will be removed in a future version.")]
-    public abstract partial class BaseView
-    {
-        protected BaseView() { }
-        protected Microsoft.AspNetCore.Http.HttpContext Context { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected System.Text.Encodings.Web.HtmlEncoder HtmlEncoder { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
-        protected System.Text.Encodings.Web.JavaScriptEncoder JavaScriptEncoder { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
-        protected System.IO.StreamWriter Output { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected Microsoft.AspNetCore.Http.HttpRequest Request { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected Microsoft.AspNetCore.Http.HttpResponse Response { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        protected System.Text.Encodings.Web.UrlEncoder UrlEncoder { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } [System.Runtime.CompilerServices.CompilerGeneratedAttribute]set { } }
-        protected void BeginWriteAttribute(string name, string begining, int startPosition, string ending, int endPosition, int thingy) { }
-        protected void EndWriteAttribute() { }
-        public abstract System.Threading.Tasks.Task ExecuteAsync();
-        [System.Diagnostics.DebuggerStepThroughAttribute]
-        public System.Threading.Tasks.Task ExecuteAsync(Microsoft.AspNetCore.Http.HttpContext context) { throw null; }
-        protected string HtmlEncodeAndReplaceLineBreaks(string input) { throw null; }
-        protected void Write(Microsoft.AspNetCore.DiagnosticsViewPage.Views.HelperResult result) { }
-        protected void Write(object value) { }
-        protected void Write(string value) { }
-        protected void WriteAttributeTo(System.IO.TextWriter writer, string name, string leader, string trailer, params Microsoft.AspNetCore.DiagnosticsViewPage.Views.AttributeValue[] values) { }
-        protected void WriteAttributeValue(string thingy, int startPostion, object value, int endValue, int dealyo, bool yesno) { }
-        protected void WriteLiteral(object value) { }
-        protected void WriteLiteral(string value) { }
-        protected void WriteLiteralTo(System.IO.TextWriter writer, object value) { }
-        protected void WriteLiteralTo(System.IO.TextWriter writer, string value) { }
-        protected void WriteTo(System.IO.TextWriter writer, object value) { }
-        protected void WriteTo(System.IO.TextWriter writer, string value) { }
-    }
-    [System.ObsoleteAttribute("This type is for internal use only and will be removed in a future version.")]
-    public partial class HelperResult
-    {
-        public HelperResult(System.Action<System.IO.TextWriter> action) { }
-        public System.Action<System.IO.TextWriter> WriteAction { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }
-        public void WriteTo(System.IO.TextWriter writer) { }
-    }
-}

src/Middleware/Diagnostics/src/WelcomePage/Views/Obsolete/WelcomePage.cs

@@ -14,8 +14,7 @@ using Microsoft.AspNetCore.Diagnostics
     ;
     using System.Threading.Tasks;
 
-    [Obsolete("This type is for internal use only and will be removed in a future version.")]
+    internal class WelcomePage : Microsoft.AspNetCore.DiagnosticsViewPage.Views.BaseView
-    public class WelcomePage : Microsoft.AspNetCore.DiagnosticsViewPage.Views.BaseView
     {
         #line hidden
         public WelcomePage()

src/Shared/Diagnostics/AttributeValue.cs

@@ -5,8 +5,7 @@ using System;
 
 namespace Microsoft.AspNetCore.DiagnosticsViewPage.Views
 {
-    [Obsolete("This type is for internal use only and will be removed in a future version.")]
+    internal class AttributeValue
-    public class AttributeValue
     {
         public AttributeValue(string prefix, object value, bool literal)
         {

src/Shared/Diagnostics/BaseView.cs

@@ -14,11 +14,7 @@ using Microsoft.AspNetCore.Http;
 
 namespace Microsoft.AspNetCore.DiagnosticsViewPage.Views
 {
-    /// <summary>
+    internal abstract class BaseView
-    /// Infrastructure
-    /// </summary>
-    [Obsolete("This type is for internal use only and will be removed in a future version.")]
-    public abstract class BaseView
     {
         /// <summary>
         /// The request context

src/Shared/Diagnostics/HelperResult.cs

@@ -9,8 +9,7 @@ namespace Microsoft.AspNetCore.DiagnosticsViewPage.Views
     /// <summary>
     /// Represents a deferred write operation in a <see cref="BaseView"/>.
     /// </summary>
-    [Obsolete("This type is for internal use only and will be removed in a future version.")]
+    internal class HelperResult
-    public class HelperResult
     {
         /// <summary>
         /// Creates a new instance of <see cref="HelperResult"/>.