From d2d9a47686585364350353221ee63c5dc591f947 Mon Sep 17 00:00:00 2001
From: Nate McMaster <nate.mcmaster@microsoft.com>
Date: Tue, 3 Jul 2018 10:08:25 -0700
Subject: [PATCH] Invoke dotnet vstest directly instead of using the VSTest
 target

Attempt to workaround Microsoft/vstest#1503 which causes test failure output to be swallowed
---
 build/SharedFx.targets | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/build/SharedFx.targets b/build/SharedFx.targets
index ed0bb6cf96..2c206a87b1 100644
--- a/build/SharedFx.targets
+++ b/build/SharedFx.targets
@@ -540,9 +540,24 @@
         RepositoryCommit=$(RepositoryCommit);
         SharedFxRuntimeIdentifier=$(SharedFXRid)
       </UnitTestFxTestProps>
+      <TrxFile>$(LogOutputDir)SharedFx.UnitTests-$(BuildNumber).trx</TrxFile>
     </PropertyGroup>
     <MSBuild Projects="$(UnitTestFxProject)" Targets="Restore" Properties="_Dummy=restore;$(UnitTestFxTestProps)" />
-    <MSBuild Projects="$(UnitTestFxProject)" Targets="VSTest" Properties="$(UnitTestFxTestProps)" />
+    <MSBuild Projects="$(UnitTestFxProject)" Targets="Build" Properties="$(UnitTestFxTestProps)">
+      <Output TaskParameter="TargetOutputs" ItemName="SharedFxTestAssembly" />
+    </MSBuild>
+    <RunDotNet Arguments="vstest;
+      --Framework:%(TargetFrameworkIdentifier),Version=v%(TargetFrameworkVersion);
+      --Logger:$([MSBuild]::Escape('trx;LogFileName=$(TrxFile)'));
+      %(SharedFxTestAssembly.Identity);
+      --;RunConfiguration.NoAutoReporters=true" IgnoreExitCode="true">
+      <Output TaskParameter="ExitCode" PropertyName="VsTestExitCode" />
+    </RunDotNet>
+
+    <Message Text="##teamcity[importData type='vstest' path='$(TrxFile)']"
+      Importance="High"
+      Condition="'$(TEAMCITY_VERSION)' != '' AND Exists($(TrxFile))" />
+    <Error Text="SharedFx.UnitTests failed with exit code '$(VsTestExitCode)'." Condition=" $(VsTestExitCode) != 0 " />
   </Target>
 
 </Project>