huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve HtmlTokenizer.AtToken performance. (dotnet/aspnetcore-tooling#1880) 

Our razor typing test measured 153 CPU ms in this method. Optimized by fewer calls to CurrentCharacter, not checking '<' twice, and uswing a switch stmt.\n\nCommit migrated from c601c2f11e
This commit is contained in:
Todd Grunke 2020-05-11 10:26:56 -07:00 committed by GitHub
parent f701a188c2
commit d1e7d8e466
1 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/Razor/Microsoft.AspNetCore.Razor.Language/src/Legacy/HtmlTokenizer.cs
View File

@ -253,21 +253,27 @@ namespace Microsoft.AspNetCore.Razor.Language.Legacy
return EndToken(SyntaxKind.NewLine); return EndToken(SyntaxKind.NewLine);
} }
private bool AtToken() private bool AtToken()
{ {
return CurrentCharacter == '<' || switch (CurrentCharacter)
CurrentCharacter == '<' || {
CurrentCharacter == '!' || case '<':
CurrentCharacter == '/' || case '!':
CurrentCharacter == '?' || case '/':
CurrentCharacter == '[' || case '?':
CurrentCharacter == '>' || case '[':
CurrentCharacter == ']' || case '>':
CurrentCharacter == '=' || case ']':
CurrentCharacter == '"' || case '=':
CurrentCharacter == '\'' || case '"':
CurrentCharacter == '@' || case '\'':
(CurrentCharacter == '-' && Peek() == '-'); case '@':
return true;
case '-':
return Peek() == '-';
}
return false;
} }
private StateResult Transition(HtmlTokenizerState state) private StateResult Transition(HtmlTokenizerState state)