huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Reenable cert tests on helix (#20372)

This commit is contained in:
Hao Kung 2020-04-04 13:02:22 -07:00 committed by GitHub
parent 75bdd71ebc
commit cc79bcc67b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Components/Components/test/RendererTest.cs
View File

@ -2810,8 +2810,7 @@ namespace Microsoft.AspNetCore.Components.Test
Assert.Equal(10, component.OnAfterRenderCallCount); Assert.Equal(10, component.OnAfterRenderCallCount);
} }
[ConditionalFact] [Fact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7487")]
public async Task CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync() public async Task CanTriggerEventHandlerDisposedInEarlierPendingBatchAsync()
{ {
// This represents the scenario where the same event handler is being triggered // This represents the scenario where the same event handler is being triggered

5
src/Identity/ApiAuthorization.IdentityServer/test/Configuration/ConfigureSigningCredentialsTests.cs
View File

@ -23,7 +23,6 @@ namespace Microsoft.AspNetCore.ApiAuthorization.IdentityServer
X509KeyStorageFlags.DefaultKeySet); X509KeyStorageFlags.DefaultKeySet);
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")]
[FrameworkSkipCondition(RuntimeFrameworks.CLR)] [FrameworkSkipCondition(RuntimeFrameworks.CLR)]
public void Configure_AddsDevelopmentKeyFromConfiguration() public void Configure_AddsDevelopmentKeyFromConfiguration()
{ {
@ -64,7 +63,7 @@ namespace Microsoft.AspNetCore.ApiAuthorization.IdentityServer
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public void Configure_LoadsPfxCertificateCredentialFromConfiguration() public void Configure_LoadsPfxCertificateCredentialFromConfiguration()
{ {
// Arrange // Arrange
@ -94,7 +93,7 @@ namespace Microsoft.AspNetCore.ApiAuthorization.IdentityServer
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public void Configure_LoadsCertificateStoreCertificateCredentialFromConfiguration() public void Configure_LoadsCertificateStoreCertificateCredentialFromConfiguration()
{ {
try try

6
src/Identity/ApiAuthorization.IdentityServer/test/Configuration/SigningKeysLoaderTests.cs
View File

@ -59,7 +59,7 @@ namespace Microsoft.AspNetCore.ApiAuthorization.IdentityServer.Configuration
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public static void LoadFromStoreCert_SkipsCertificatesNotYetValid() public static void LoadFromStoreCert_SkipsCertificatesNotYetValid()
{ {
try try
@ -82,7 +82,7 @@ namespace Microsoft.AspNetCore.ApiAuthorization.IdentityServer.Configuration
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public static void LoadFromStoreCert_PrefersCertificatesCloserToExpirationDate() public static void LoadFromStoreCert_PrefersCertificatesCloserToExpirationDate()
{ {
try try
@ -105,7 +105,7 @@ namespace Microsoft.AspNetCore.ApiAuthorization.IdentityServer.Configuration
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public static void LoadFromStoreCert_SkipsExpiredCertificates() public static void LoadFromStoreCert_SkipsExpiredCertificates()
{ {
try try

14
src/Tools/FirstRunCertGenerator/test/CertificateManagerTests.cs
View File

@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
public ITestOutputHelper Output { get; } public ITestOutputHelper Output { get; }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public void EnsureCreateHttpsCertificate_CreatesACertificate_WhenThereAreNoHttpsCertificates() public void EnsureCreateHttpsCertificate_CreatesACertificate_WhenThereAreNoHttpsCertificates()
{ {
try try
@ -124,7 +124,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public void EnsureCreateHttpsCertificate_DoesNotCreateACertificate_WhenThereIsAnExistingHttpsCertificates() public void EnsureCreateHttpsCertificate_DoesNotCreateACertificate_WhenThereIsAnExistingHttpsCertificates()
{ {
// Arrange // Arrange
@ -154,8 +154,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
Assert.Equal(httpsCertificate.GetCertHashString(), exportedCertificate.GetCertHashString()); Assert.Equal(httpsCertificate.GetCertHashString(), exportedCertificate.GetCertHashString());
} }
[ConditionalFact] [Fact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateIfVersionIsIncorrect() public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateIfVersionIsIncorrect()
{ {
_fixture.CleanupCertificates(); _fixture.CleanupCertificates();
@ -170,8 +169,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
Assert.Empty(httpsCertificateList); Assert.Empty(httpsCertificateList);
} }
[ConditionalFact] [Fact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")]
public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateForEmptyVersionField() public void EnsureCreateHttpsCertificate_ReturnsExpiredCertificateForEmptyVersionField()
{ {
_fixture.CleanupCertificates(); _fixture.CleanupCertificates();
@ -188,7 +186,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public void EnsureCreateHttpsCertificate_ReturnsValidIfVersionIsZero() public void EnsureCreateHttpsCertificate_ReturnsValidIfVersionIsZero()
{ {
_fixture.CleanupCertificates(); _fixture.CleanupCertificates();
@ -203,7 +201,7 @@ namespace Microsoft.AspNetCore.Certificates.Generation.Tests
} }
[ConditionalFact] [ConditionalFact]
[SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6721")] [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/6720", Queues = "OSX.1014.Amd64;OSX.1014.Amd64.Open")]
public void EnsureCreateHttpsCertificate_ReturnValidIfCertIsNewer() public void EnsureCreateHttpsCertificate_ReturnValidIfCertIsNewer()
{ {
_fixture.CleanupCertificates(); _fixture.CleanupCertificates();