huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

HttpMethodConstraint -> HttpMethodRouteConstraint 

This is consistent with other constraint types in routing, and avoids a
naming conflict with MVC.

This is a change **away** from the names used in System.Web and
System.Web.Http.Routing, but it seems worth doing for consistency and
clarity.
This commit is contained in:
Ryan Nowak 2015-12-14 10:10:17 -08:00
parent 604fc6bb54
commit cc501bc025
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Microsoft.AspNet.Routing/Constraints/HttpMethodRouteConstraint.cs
View File

@ -11,14 +11,14 @@ namespace Microsoft.AspNet.Routing.Constraints
/// <summary> /// <summary>
/// Constrains the HTTP method of request or a route. /// Constrains the HTTP method of request or a route.
/// </summary> /// </summary>
public class HttpMethodConstraint : IRouteConstraint public class HttpRouteMethodConstraint : IRouteConstraint
{ {
/// <summary> /// <summary>
/// Creates a new <see cref="HttpMethodConstraint"/> that accepts the HTTP methods specified /// Creates a new <see cref="HttpRouteMethodConstraint"/> that accepts the HTTP methods specified
/// by <paramref name="allowedMethods"/>. /// by <paramref name="allowedMethods"/>.
/// </summary> /// </summary>
/// <param name="allowedMethods">The allowed HTTP methods.</param> /// <param name="allowedMethods">The allowed HTTP methods.</param>
public HttpMethodConstraint(params string[] allowedMethods) public HttpRouteMethodConstraint(params string[] allowedMethods)
{ {
if (allowedMethods == null) if (allowedMethods == null)
{ {
@ -69,8 +69,8 @@ namespace Microsoft.AspNet.Routing.Constraints
case RouteDirection.UrlGeneration: case RouteDirection.UrlGeneration:
// We need to see if the user specified the HTTP method explicitly. Consider these two routes: // We need to see if the user specified the HTTP method explicitly. Consider these two routes:
// //
// a) Route: template = "/{foo}", Constraints = { httpMethod = new HttpMethodConstraint("GET") } // a) Route: template = "/{foo}", Constraints = { httpMethod = new HttpRouteMethodConstraint("GET") }
// b) Route: template = "/{foo}", Constraints = { httpMethod = new HttpMethodConstraint("POST") } // b) Route: template = "/{foo}", Constraints = { httpMethod = new HttpRouteMethodConstraint("POST") }
// //
// A user might know ahead of time that a URI he/she is generating might be used with a particular HTTP // A user might know ahead of time that a URI he/she is generating might be used with a particular HTTP
// method. If a URI will be used for an HTTP POST but we match on (a) while generating the URI, then // method. If a URI will be used for an HTTP POST but we match on (a) while generating the URI, then

8
test/Microsoft.AspNet.Routing.Tests/Constraints/HttpMethodRouteConstraintTests.cs
View File

@ -15,7 +15,7 @@ namespace Microsoft.AspNet.Routing.Constraints
public void HttpMethodRouteConstraint_IncomingRequest_AcceptsAllowedMethods(string httpMethod) public void HttpMethodRouteConstraint_IncomingRequest_AcceptsAllowedMethods(string httpMethod)
{ {
// Arrange // Arrange
var constraint = new HttpMethodConstraint("GET", "post"); var constraint = new HttpRouteMethodConstraint("GET", "post");
var httpContext = new DefaultHttpContext(); var httpContext = new DefaultHttpContext();
httpContext.Request.Method = httpMethod; httpContext.Request.Method = httpMethod;
@ -36,7 +36,7 @@ namespace Microsoft.AspNet.Routing.Constraints
public void HttpMethodRouteConstraint_IncomingRequest_RejectsOtherMethods(string httpMethod) public void HttpMethodRouteConstraint_IncomingRequest_RejectsOtherMethods(string httpMethod)
{ {
// Arrange // Arrange
var constraint = new HttpMethodConstraint("GET", "post"); var constraint = new HttpRouteMethodConstraint("GET", "post");
var httpContext = new DefaultHttpContext(); var httpContext = new DefaultHttpContext();
httpContext.Request.Method = httpMethod; httpContext.Request.Method = httpMethod;
@ -57,7 +57,7 @@ namespace Microsoft.AspNet.Routing.Constraints
public void HttpMethodRouteConstraint_UrlGeneration_AcceptsAllowedMethods(string httpMethod) public void HttpMethodRouteConstraint_UrlGeneration_AcceptsAllowedMethods(string httpMethod)
{ {
// Arrange // Arrange
var constraint = new HttpMethodConstraint("GET", "post"); var constraint = new HttpRouteMethodConstraint("GET", "post");
var httpContext = new DefaultHttpContext(); var httpContext = new DefaultHttpContext();
var route = Mock.Of<IRouter>(); var route = Mock.Of<IRouter>();
@ -77,7 +77,7 @@ namespace Microsoft.AspNet.Routing.Constraints
public void HttpMethodRouteConstraint_UrlGeneration_RejectsOtherMethods(string httpMethod) public void HttpMethodRouteConstraint_UrlGeneration_RejectsOtherMethods(string httpMethod)
{ {
// Arrange // Arrange
var constraint = new HttpMethodConstraint("GET", "post"); var constraint = new HttpRouteMethodConstraint("GET", "post");
var httpContext = new DefaultHttpContext(); var httpContext = new DefaultHttpContext();
var route = Mock.Of<IRouter>(); var route = Mock.Of<IRouter>();