huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Enable xUnit diagnostic messages (#2505)" (#2522) 

- xUnit diagnostic messages were enabled in #2505 to help identify hung tests
- However, this also enables log messages for non-serializable theory data (https://github.com/aspnet/KestrelHttpServer/issues/2509), which adds noise to logs
- It doesn't seem possible to disable the "non-serializable data" messages but keep the "long-running test" messages
- Converting all tests to serializable theory data is expensive and complicates test code
- The best solution for now is to revert xUnit diagnostic messages to disabled, and re-enable when needed to identify hung tests
This commit is contained in:
Mike Harder 2018-04-24 17:24:43 -07:00 committed by GitHub
parent cc38a8d1fa
commit cc29a503e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/xunit.runner.json
View File

@ -2,6 +2,5 @@
"$schema": "http://json.schemastore.org/xunit.runner.schema", "$schema": "http://json.schemastore.org/xunit.runner.schema",
"appDomain": "denied", "appDomain": "denied",
"methodDisplay": "method", "methodDisplay": "method",
"diagnosticMessages": true,
"longRunningTestSeconds": 60 "longRunningTestSeconds": 60
} }