huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make facts and theories conditional (#1023)

This commit is contained in:
Pavel Krymets 2018-07-09 09:54:48 -07:00 committed by GitHub
parent 96b42dc827
commit cbfd791d7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/IISExpress.FunctionalTests/InProcess/StartupTests.cs
View File

@ -120,7 +120,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
Assert.Equal("Hello World", responseText); Assert.Equal("Hello World", responseText);
} }
[Fact] [ConditionalFact]
public async Task DetectsOveriddenServer() public async Task DetectsOveriddenServer()
{ {
var deploymentResult = await DeployAsync(GetBaseDeploymentParameters("OverriddenServerWebSite")); var deploymentResult = await DeployAsync(GetBaseDeploymentParameters("OverriddenServerWebSite"));

11
test/IISExpress.FunctionalTests/OutOfProcess/GlobalVersionTests.cs
View File

@ -8,6 +8,7 @@ using System.Threading.Tasks;
using System.Xml.Linq; using System.Xml.Linq;
using Microsoft.AspNetCore.Server.IIS.FunctionalTests.Utilities; using Microsoft.AspNetCore.Server.IIS.FunctionalTests.Utilities;
using Microsoft.AspNetCore.Server.IntegrationTesting; using Microsoft.AspNetCore.Server.IntegrationTesting;
using Microsoft.AspNetCore.Testing.xunit;
using Xunit; using Xunit;
using Xunit.Abstractions; using Xunit.Abstractions;
@ -21,7 +22,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
private const string _helloWorldResponse = "Hello World"; private const string _helloWorldResponse = "Hello World";
private const string _outOfProcessVersionVariable = "/p:AspNetCoreModuleOutOfProcessVersion="; private const string _outOfProcessVersionVariable = "/p:AspNetCoreModuleOutOfProcessVersion=";
[Fact] [ConditionalFact]
public async Task GlobalVersion_DefaultWorks() public async Task GlobalVersion_DefaultWorks()
{ {
var deploymentParameters = GetGlobalVersionBaseDeploymentParameters(); var deploymentParameters = GetGlobalVersionBaseDeploymentParameters();
@ -45,7 +46,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
Assert.Equal(_helloWorldResponse, responseText); Assert.Equal(_helloWorldResponse, responseText);
} }
[Theory] // Tests need to publish to change folder locations [ConditionalTheory]
[InlineData("2.1.0")] [InlineData("2.1.0")]
[InlineData("2.1.0-preview")] [InlineData("2.1.0-preview")]
public async Task GlobalVersion_NewVersionNumber_Fails(string version) public async Task GlobalVersion_NewVersionNumber_Fails(string version)
@ -60,7 +61,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
Assert.False(response.IsSuccessStatusCode); Assert.False(response.IsSuccessStatusCode);
} }
[Theory] // Tests need to publish to change folder locations [ConditionalTheory]
[InlineData("2.1.0")] [InlineData("2.1.0")]
[InlineData("2.1.0-preview")] [InlineData("2.1.0-preview")]
public async Task GlobalVersion_NewVersionNumber(string version) public async Task GlobalVersion_NewVersionNumber(string version)
@ -78,7 +79,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
AssertLoadedVersion(version); AssertLoadedVersion(version);
} }
[Theory] // Tests need to publish to change folder locations [ConditionalTheory]
[InlineData("2.1.0")] [InlineData("2.1.0")]
[InlineData("2.1.0-preview")] [InlineData("2.1.0-preview")]
public async Task GlobalVersion_MultipleRequestHandlers_PicksHighestOne(string version) public async Task GlobalVersion_MultipleRequestHandlers_PicksHighestOne(string version)
@ -103,7 +104,7 @@ namespace Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests
AssertLoadedVersion(version); AssertLoadedVersion(version);
} }
[Theory] [ConditionalTheory]
[InlineData("2.1.0")] [InlineData("2.1.0")]
[InlineData("2.1.0-preview")] [InlineData("2.1.0-preview")]
public async Task GlobalVersion_MultipleRequestHandlers_UpgradeWorks(string version) public async Task GlobalVersion_MultipleRequestHandlers_UpgradeWorks(string version)