diff --git a/src/Servers/HttpSys/test/FunctionalTests/Listener/ResponseBodyTests.cs b/src/Servers/HttpSys/test/FunctionalTests/Listener/ResponseBodyTests.cs index 946cb55f22..661c78c360 100644 --- a/src/Servers/HttpSys/test/FunctionalTests/Listener/ResponseBodyTests.cs +++ b/src/Servers/HttpSys/test/FunctionalTests/Listener/ResponseBodyTests.cs @@ -9,6 +9,7 @@ using System.Net.Http; using System.Text; using System.Threading; using System.Threading.Tasks; +using Microsoft.AspNetCore.Testing; using Microsoft.AspNetCore.Testing.xunit; using Xunit; @@ -228,6 +229,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBodyWriteExceptions_ClientDisconnectsBeforeFirstWrite_WriteThrows() { string address; @@ -264,6 +266,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBodyWriteExceptions_ClientDisconnectsBeforeFirstWriteAsync_WriteThrows() { string address; @@ -299,6 +302,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBody_ClientDisconnectsBeforeFirstWrite_WriteCompletesSilently() { string address; @@ -327,6 +331,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBody_ClientDisconnectsBeforeFirstWriteAsync_WriteCompletesSilently() { string address; @@ -354,6 +359,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBodyWriteExceptions_ClientDisconnectsBeforeSecondWrite_WriteThrows() { string address; @@ -393,6 +399,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBodyWriteExceptions_ClientDisconnectsBeforeSecondWriteAsync_WriteThrows() { string address; @@ -431,6 +438,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBody_ClientDisconnectsBeforeSecondWrite_WriteCompletesSilently() { string address; @@ -466,6 +474,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2729", FlakyOn.AzP.Windows)] public async Task ResponseBody_ClientDisconnectsBeforeSecondWriteAsync_WriteCompletesSilently() { string address; diff --git a/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs b/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs index 44225d1eac..cac577355b 100644 --- a/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs +++ b/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs @@ -49,7 +49,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [Theory] [MemberData(nameof(AddressRegistrationDataIPv4Port5000Default))] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public async Task RegisterAddresses_IPv4Port5000Default_Success(string addressInput, string testUrl) { if (!CanBindToEndpoint(IPAddress.Loopback, 5000)) @@ -62,7 +62,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [Theory] [MemberData(nameof(AddressRegistrationDataIPv4Port80))] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public async Task RegisterAddresses_IPv4Port80_Success(string addressInput, string testUrl) { if (!CanBindToEndpoint(IPAddress.Loopback, 80)) @@ -110,7 +110,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalTheory] [MemberData(nameof(IPEndPointRegistrationDataPort443))] [IPv6SupportedCondition] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public async Task RegisterIPEndPoint_Port443_Success(IPEndPoint endpoint, string testUrl) { if (!CanBindToEndpoint(endpoint.Address, 443)) @@ -132,7 +132,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalTheory] [MemberData(nameof(AddressRegistrationDataIPv6Port5000Default))] [IPv6SupportedCondition] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public async Task RegisterAddresses_IPv6Port5000Default_Success(string addressInput, string[] testUrls) { if (!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 5000)) @@ -146,7 +146,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalTheory] [MemberData(nameof(AddressRegistrationDataIPv6Port80))] [IPv6SupportedCondition] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public async Task RegisterAddresses_IPv6Port80_Success(string addressInput, string[] testUrls) { if (!CanBindToEndpoint(IPAddress.Loopback, 80) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 80)) @@ -417,7 +417,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests } [Fact] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public Task DefaultsServerAddress_BindsToIPv4() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000)) @@ -430,7 +430,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalFact] [IPv6SupportedCondition] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public Task DefaultsServerAddress_BindsToIPv6() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 5000)) @@ -442,7 +442,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests } [Fact] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] public Task DefaultsServerAddress_BindsToIPv4WithHttps() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.Loopback, 5001)) @@ -456,7 +456,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalFact] [IPv6SupportedCondition] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1756", FlakyOn.AzP.macOS)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1756", FlakyOn.AzP.All)] public Task DefaultsServerAddress_BindsToIPv6WithHttps() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 5000) diff --git a/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs b/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs index 95403f4281..ee7088ba14 100644 --- a/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs +++ b/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs @@ -109,7 +109,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests } } [Theory] - [Flaky("https://github.com/aspnet/AspNetCore/issues/8054", FlakyOn.AzP.Windows)] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2489", FlakyOn.AzP.All)] [MemberData(nameof(LargeUploadData))] public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause) { diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/ResponseTests.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/ResponseTests.cs index ac98e909bd..005dfd8ad9 100644 --- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/ResponseTests.cs +++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/ResponseTests.cs @@ -19,6 +19,7 @@ using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http; using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure; using Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.TestTransport; using Microsoft.AspNetCore.Testing; +using Microsoft.AspNetCore.Testing.xunit; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Logging; using Microsoft.Extensions.Logging.Testing; @@ -2541,6 +2542,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests } [Fact] + [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2408", FlakyOn.AzP.All)] public async Task AppAbortViaIConnectionLifetimeFeatureIsLogged() { var testContext = new TestServiceContext(LoggerFactory); @@ -3891,7 +3893,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests httpContext.Response.BodyWriter.Complete(); writeEx = Assert.Throws(() => httpContext.Response.BodyWriter.GetMemory()); - + return Task.CompletedTask; }, new TestServiceContext(LoggerFactory))) {