diff --git a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs index 1c0c187eef..4f97df03f1 100644 --- a/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs +++ b/src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperDescriptorFactory.cs @@ -273,7 +273,7 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers { if (ShouldSkipDescriptorCreation(designTime, property)) { - return Enumerable.Empty(); + continue; } var attributeNameAttribute = property.GetCustomAttribute(inherit: false); diff --git a/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/TagHelperDescriptorFactoryTest.cs b/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/TagHelperDescriptorFactoryTest.cs index e34223600a..8b0c68c8e2 100644 --- a/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/TagHelperDescriptorFactoryTest.cs +++ b/test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/TagHelperDescriptorFactoryTest.cs @@ -185,18 +185,19 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers assemblyName: AssemblyName, attributes: new[] { + new TagHelperAttributeDescriptor( + name: "property2", + propertyName: nameof(OverriddenPropertyEditorBrowsableTagHelper.Property2), + typeName: typeof(int).FullName, + isIndexer: false, + designTimeDescriptor: null), new TagHelperAttributeDescriptor( name: "property", propertyName: nameof(OverriddenPropertyEditorBrowsableTagHelper.Property), typeName: typeof(int).FullName, isIndexer: false, designTimeDescriptor: null), - new TagHelperAttributeDescriptor( - name: "property2", - propertyName: nameof(OverriddenPropertyEditorBrowsableTagHelper.Property2), - typeName: typeof(int).FullName, - isIndexer: false, - designTimeDescriptor: null) + }) } }, @@ -244,7 +245,7 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers // Assert Assert.Empty(errorSink.Errors); - Assert.Equal(expectedDescriptors, descriptors, TagHelperDescriptorComparer.Default); + Assert.Equal(expectedDescriptors, descriptors, CaseSensitiveTagHelperDescriptorComparer.Default); } public static TheoryData AttributeTargetData