From c4eaad5df5e4437d2ccf174bd5f11d80f6f71e9d Mon Sep 17 00:00:00 2001 From: John Luo Date: Tue, 30 Jun 2020 14:46:21 -0700 Subject: [PATCH] Fix TLS test (#23489) --- .../Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs index 59af852469..9e3263bb79 100644 --- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs +++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs @@ -22,14 +22,15 @@ using Xunit; namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.Http2 { [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Missing SslStream ALPN support: https://github.com/dotnet/corefx/issues/30492")] - [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81, - SkipReason = "Missing Windows ALPN support: https://en.wikipedia.org/wiki/Application-Layer_Protocol_Negotiation#Support")] + [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10, + SkipReason = "Missing Windows ALPN support: https://en.wikipedia.org/wiki/Application-Layer_Protocol_Negotiation#Support or incompatible ciphers on Windows 8.1")] public class TlsTests : LoggedTest { private static X509Certificate2 _x509Certificate2 = TestResources.GetTestCertificate(); [ConditionalFact] [QuarantinedTest] + [SkipOnHelix("Ubuntu 20.04 disables TLS1.1 by default which SslStream requires in this scenario", Queues = "Ubuntu.2004.Amd64.Open")] public async Task TlsHandshakeRejectsTlsLessThan12() { using (var server = new TestServer(context =>