From c30638b829aa0f52cdc5d2e7c51d7969f276ec90 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Fri, 12 Jun 2020 08:32:41 -0700 Subject: [PATCH] Fixup nullable (#22861) --- src/Http/Headers/src/HeaderUtilities.cs | 10 +++++----- src/Http/Headers/src/MediaTypeHeaderValue.cs | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Http/Headers/src/HeaderUtilities.cs b/src/Http/Headers/src/HeaderUtilities.cs index 75be781c16..1fd6f6ae10 100644 --- a/src/Http/Headers/src/HeaderUtilities.cs +++ b/src/Http/Headers/src/HeaderUtilities.cs @@ -39,7 +39,7 @@ namespace Microsoft.Net.Http.Headers } else { - parameters!.Add(new NameValueHeaderValue(QualityName, qualityString)); + parameters.Add(new NameValueHeaderValue(QualityName, qualityString)); } } else @@ -52,15 +52,14 @@ namespace Microsoft.Net.Http.Headers } } - internal static double? GetQuality(IList parameters) + internal static double? GetQuality(IList? parameters) { var qualityParameter = NameValueHeaderValue.Find(parameters, QualityName); if (qualityParameter != null) { // Note that the RFC requires decimal '.' regardless of the culture. I.e. using ',' as decimal // separator is considered invalid (even if the current culture would allow it). - if (TryParseQualityDouble(qualityParameter.Value, 0, out var qualityValue, out var length)) - + if (TryParseQualityDouble(qualityParameter.Value, 0, out var qualityValue, out _)) { return qualityValue; } @@ -703,7 +702,8 @@ namespace Microsoft.Net.Http.Headers var backSlashCount = CountAndCheckCharactersNeedingBackslashesWhenEncoding(input); // 2 for quotes - return string.Create(input.Length + backSlashCount + 2, input, (span, segment) => { + return string.Create(input.Length + backSlashCount + 2, input, (span, segment) => + { // Helps to elide the bounds check for span[0] span[span.Length - 1] = span[0] = '\"'; diff --git a/src/Http/Headers/src/MediaTypeHeaderValue.cs b/src/Http/Headers/src/MediaTypeHeaderValue.cs index df3d96c0cf..87ca778a7c 100644 --- a/src/Http/Headers/src/MediaTypeHeaderValue.cs +++ b/src/Http/Headers/src/MediaTypeHeaderValue.cs @@ -206,7 +206,7 @@ namespace Microsoft.Net.Http.Headers /// public double? Quality { - get { return HeaderUtilities.GetQuality(Parameters); } + get => HeaderUtilities.GetQuality(_parameters); set { HeaderUtilities.ThrowIfReadOnly(IsReadOnly);