diff --git a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs
index bca0dd88e7..4a3efe43fb 100644
--- a/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs
+++ b/src/Microsoft.AspNetCore.Mvc.ViewFeatures/Rendering/SelectListItem.cs
@@ -33,14 +33,25 @@ namespace Microsoft.AspNetCore.Mvc.Rendering
/// The display text of this .
/// The value of this .
/// Value that indicates whether this is selected.
- /// Value that indicates whether this is disabled.
- public SelectListItem(string text, string value, bool selected, bool disabled)
+ public SelectListItem(string text, string value, bool selected)
: this(text, value)
{
- Disabled = disabled;
Selected = selected;
}
+ ///
+ /// Initializes a new instance of .
+ ///
+ /// The display text of this .
+ /// The value of this .
+ /// Value that indicates whether this is selected.
+ /// Value that indicates whether this is disabled.
+ public SelectListItem(string text, string value, bool selected, bool disabled)
+ : this(text, value, selected)
+ {
+ Disabled = disabled;
+ }
+
///
/// Gets or sets a value that indicates whether this is disabled.
/// This property is typically rendered as a disabled="disabled" attribute in the HTML
diff --git a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperDropDownListExtensionsTest.cs b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperDropDownListExtensionsTest.cs
index d3de94321f..b7d1846b0b 100644
--- a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperDropDownListExtensionsTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperDropDownListExtensionsTest.cs
@@ -15,10 +15,10 @@ namespace Microsoft.AspNetCore.Mvc.Core
{
private static readonly List BasicSelectList = new List
{
- new SelectListItem { Text = "Zero", Value = "0"},
- new SelectListItem { Text = "One", Value = "1"},
- new SelectListItem { Text = "Two", Value = "2"},
- new SelectListItem { Text = "Three", Value = "3"},
+ new SelectListItem("Zero", "0"),
+ new SelectListItem("One", "1"),
+ new SelectListItem("Two", "2"),
+ new SelectListItem("Three", "3"),
};
[Fact]
@@ -78,8 +78,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -103,8 +103,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -130,8 +130,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -178,8 +178,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -204,8 +204,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -230,8 +230,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
diff --git a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperListBoxExtensionsTest.cs b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperListBoxExtensionsTest.cs
index 92c8fe0896..d5277ae2bd 100644
--- a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperListBoxExtensionsTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperListBoxExtensionsTest.cs
@@ -15,10 +15,10 @@ namespace Microsoft.AspNetCore.Mvc.Core
{
private static readonly List BasicSelectList = new List
{
- new SelectListItem { Text = "Zero", Value = "0"},
- new SelectListItem { Text = "One", Value = "1"},
- new SelectListItem { Text = "Two", Value = "2"},
- new SelectListItem { Text = "Three", Value = "3"},
+ new SelectListItem("Zero", "0"),
+ new SelectListItem("One", "1"),
+ new SelectListItem("Two", "2"),
+ new SelectListItem("Three", "3"),
};
[Fact]
@@ -54,8 +54,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -79,8 +79,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -126,8 +126,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
@@ -151,8 +151,8 @@ namespace Microsoft.AspNetCore.Mvc.Core
"";
var selectList = new List
{
- new SelectListItem { Text = "Four", Value = "4" },
- new SelectListItem { Text = "Five", Value = "5" },
+ new SelectListItem("Four", "4"),
+ new SelectListItem("Five", "5"),
};
var metadataProvider = new EmptyModelMetadataProvider();
var helper = DefaultTemplatesUtilities.GetHtmlHelper(new ViewDataDictionary(metadataProvider));
diff --git a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperSelectTest.cs b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperSelectTest.cs
index 73c7692cda..9a0d279ffe 100644
--- a/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperSelectTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Rendering/HtmlHelperSelectTest.cs
@@ -31,38 +31,38 @@ namespace Microsoft.AspNetCore.Mvc.Rendering
private static readonly List BasicSelectList = new List
{
- new SelectListItem { Text = "Zero", Value = "0"},
- new SelectListItem { Text = "One", Value = "1"},
- new SelectListItem { Text = "Two", Value = "2"},
- new SelectListItem { Text = "Three", Value = "3"},
+ new SelectListItem("Zero", "0"),
+ new SelectListItem("One", "1"),
+ new SelectListItem("Two", "2"),
+ new SelectListItem("Three", "3"),
};
private static readonly List SomeDisabledOneSelectedSelectList = new List
{
- new SelectListItem { Disabled = false, Selected = false, Text = "Zero", Value = "0"},
- new SelectListItem { Disabled = true, Selected = true, Text = "One", Value = "1"},
- new SelectListItem { Disabled = false, Selected = false, Text = "Two", Value = "2"},
- new SelectListItem { Disabled = true, Selected = false, Text = "Three", Value = "3"},
+ new SelectListItem("Zero", "0", false, false),
+ new SelectListItem("One", "1", true, true),
+ new SelectListItem("Two", "2", false, false),
+ new SelectListItem("Three", "3", false, true),
};
private static readonly List SomeGroupedSomeSelectedSelectList = new List
{
- new SelectListItem { Group = GroupOne, Selected = true, Text = "Zero", Value = "0"},
- new SelectListItem { Group = GroupTwo, Selected = false, Text = "One", Value = "1"},
- new SelectListItem { Group = GroupOne, Selected = true, Text = "Two", Value = "2"},
- new SelectListItem { Group = null, Selected = false, Text = "Three", Value = "3"},
+ new SelectListItem("Zero", "0", true) { Group = GroupOne },
+ new SelectListItem("One", "1", false) { Group = GroupTwo },
+ new SelectListItem("Two", "2", true) { Group = GroupOne },
+ new SelectListItem("Three", "3", false) { Group = null },
};
private static readonly List OneGroupSomeSelectedSelectList = new List
{
- new SelectListItem { Group = GroupOne, Selected = true, Text = "Zero", Value = "0"},
- new SelectListItem { Group = GroupOne, Selected = true, Text = "One", Value = "1"},
- new SelectListItem { Group = GroupOne, Selected = false, Text = "Two", Value = "2"},
- new SelectListItem { Group = GroupOne, Selected = false, Text = "Three", Value = "3"},
+ new SelectListItem("Zero", "0", true) { Group = GroupOne },
+ new SelectListItem("One", "1", true) { Group = GroupOne },
+ new SelectListItem("Two", "2", false) { Group = GroupOne },
+ new SelectListItem("Three", "3", false) { Group = GroupOne },
};
private static readonly List OneDisabledGroupAllSelectedSelectList = new List
{
- new SelectListItem { Group = DisabledGroup, Selected = true, Text = "Zero", Value = "0"},
- new SelectListItem { Group = DisabledGroup, Selected = true, Text = "One", Value = "1"},
- new SelectListItem { Group = DisabledGroup, Selected = true, Text = "Two", Value = "2"},
- new SelectListItem { Group = DisabledGroup, Selected = true, Text = "Three", Value = "3"},
+ new SelectListItem("Zero", "0", true) { Group = DisabledGroup },
+ new SelectListItem("One", "1", true) { Group = DisabledGroup },
+ new SelectListItem("Two", "2", true) { Group = DisabledGroup },
+ new SelectListItem("Three", "3", true) { Group = DisabledGroup },
};
private static readonly List SourcesSelectList = new List
{