From bf1aa1d81851f14472412867cfd77a7868103aca Mon Sep 17 00:00:00 2001 From: Mikael Mengistu Date: Thu, 20 Sep 2018 12:44:19 -0700 Subject: [PATCH] Make tests classes and HubMessageType enum package private in the Java client(#2992) --- .../main/java/com/microsoft/aspnet/signalr/HubMessageType.java | 2 +- .../com/microsoft/aspnet/signalr/HandshakeProtocolTest.java | 2 +- .../java/com/microsoft/aspnet/signalr/HubConnectionTest.java | 2 +- .../java/com/microsoft/aspnet/signalr/HubExceptionTest.java | 2 +- .../java/com/microsoft/aspnet/signalr/JsonHubProtocolTest.java | 2 +- .../com/microsoft/aspnet/signalr/NegotiateResponseTest.java | 2 +- .../com/microsoft/aspnet/signalr/ResolveNegotiateUrlTest.java | 2 +- .../com/microsoft/aspnet/signalr/WebSocketTransportTest.java | 2 +- .../aspnet/signalr/WebSocketTransportUrlFormatTest.java | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/clients/java/signalr/src/main/java/com/microsoft/aspnet/signalr/HubMessageType.java b/clients/java/signalr/src/main/java/com/microsoft/aspnet/signalr/HubMessageType.java index a02075858a..859ce257b0 100644 --- a/clients/java/signalr/src/main/java/com/microsoft/aspnet/signalr/HubMessageType.java +++ b/clients/java/signalr/src/main/java/com/microsoft/aspnet/signalr/HubMessageType.java @@ -3,7 +3,7 @@ package com.microsoft.aspnet.signalr; -public enum HubMessageType { +enum HubMessageType { INVOCATION(1), STREAM_ITEM(2), COMPLETION(3), diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HandshakeProtocolTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HandshakeProtocolTest.java index ff2ea82184..69eb504189 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HandshakeProtocolTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HandshakeProtocolTest.java @@ -7,7 +7,7 @@ import static org.junit.jupiter.api.Assertions.*; import org.junit.jupiter.api.Test; -public class HandshakeProtocolTest { +class HandshakeProtocolTest { @Test public void VerifyCreateHandshakerequestMessage() { diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubConnectionTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubConnectionTest.java index 47acc2178b..d713bad31a 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubConnectionTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubConnectionTest.java @@ -14,7 +14,7 @@ import java.util.concurrent.atomic.AtomicReference; import org.junit.jupiter.api.Test; -public class HubConnectionTest { +class HubConnectionTest { private static final String RECORD_SEPARATOR = "\u001e"; @Test diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubExceptionTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubExceptionTest.java index 0e306e5890..f6de72d45a 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubExceptionTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/HubExceptionTest.java @@ -7,7 +7,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; import org.junit.jupiter.api.Test; -public class HubExceptionTest { +class HubExceptionTest { @Test public void VeryHubExceptionMesssageIsSet() { String errorMessage = "This is a HubException"; diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/JsonHubProtocolTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/JsonHubProtocolTest.java index 08fe5c1065..ccd4cd33ec 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/JsonHubProtocolTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/JsonHubProtocolTest.java @@ -12,7 +12,7 @@ import java.util.List; import org.junit.jupiter.api.Test; -public class JsonHubProtocolTest { +class JsonHubProtocolTest { private JsonHubProtocol jsonHubProtocol = new JsonHubProtocol(); @Test diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/NegotiateResponseTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/NegotiateResponseTest.java index 7c2be3b9fc..ec2d4180ca 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/NegotiateResponseTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/NegotiateResponseTest.java @@ -8,7 +8,7 @@ import static org.junit.jupiter.api.Assertions.*; import org.junit.jupiter.api.Test; -public class NegotiateResponseTest { +class NegotiateResponseTest { @Test public void VerifyNegotiateResponse() { diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/ResolveNegotiateUrlTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/ResolveNegotiateUrlTest.java index 9f852c7725..8e96e3a2fe 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/ResolveNegotiateUrlTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/ResolveNegotiateUrlTest.java @@ -11,7 +11,7 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; -public class ResolveNegotiateUrlTest { +class ResolveNegotiateUrlTest { private static Stream protocols() { return Stream.of( Arguments.of("http://example.com/hub/", "http://example.com/hub/negotiate"), diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportTest.java index 31116d4d65..d3a2985744 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportTest.java @@ -9,7 +9,7 @@ import java.util.concurrent.TimeUnit; import org.junit.jupiter.api.Test; -public class WebSocketTransportTest { +class WebSocketTransportTest { @Test public void WebsocketThrowsIfItCantConnect() throws Exception { Transport transport = new WebSocketTransport("www.notarealurl12345.fake", new NullLogger()); diff --git a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportUrlFormatTest.java b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportUrlFormatTest.java index f7df0d956f..d4294cd642 100644 --- a/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportUrlFormatTest.java +++ b/clients/java/signalr/src/test/java/com/microsoft/aspnet/signalr/WebSocketTransportUrlFormatTest.java @@ -12,7 +12,7 @@ import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; import org.junit.jupiter.params.provider.MethodSource; -public class WebSocketTransportUrlFormatTest { +class WebSocketTransportUrlFormatTest { private static Stream protocols() { return Stream.of( Arguments.of("http://example.com", "ws://example.com"),