huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Unmark System_UsesProvidedDirectoryAndCertificate as flaky (#11125)

This commit is contained in:
Nate McMaster 2019-06-12 09:35:49 -07:00 committed by GitHub
parent db72ea04a2
commit bbff308d22
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/DataProtection/Extensions/test/DataProtectionProviderTests.cs
View File

@ -115,7 +115,6 @@ namespace Microsoft.AspNetCore.DataProtection
} }
[ConditionalFact] [ConditionalFact]
[Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2177", FlakyOn.AzP.Windows)]
[X509StoreIsAvailable(StoreName.My, StoreLocation.CurrentUser)] [X509StoreIsAvailable(StoreName.My, StoreLocation.CurrentUser)]
[SkipOnHelix("https://github.com/aspnet/AspNetCore/issues/6720")] [SkipOnHelix("https://github.com/aspnet/AspNetCore/issues/6720")]
public void System_UsesProvidedDirectoryAndCertificate() public void System_UsesProvidedDirectoryAndCertificate()
@ -133,7 +132,7 @@ namespace Microsoft.AspNetCore.DataProtection
var certificateStore = new X509Store(StoreName.My, StoreLocation.CurrentUser); var certificateStore = new X509Store(StoreName.My, StoreLocation.CurrentUser);
certificateStore.Open(OpenFlags.ReadWrite); certificateStore.Open(OpenFlags.ReadWrite);
var certificate = certificateStore.Certificates.Find(X509FindType.FindBySubjectName, "TestCert", false)[0]; var certificate = certificateStore.Certificates.Find(X509FindType.FindBySubjectName, "TestCert", false)[0];
Assert.True(certificate.HasPrivateKey, "Cert should have a private key");
try try
{ {
// Step 1: directory should be completely empty // Step 1: directory should be completely empty
@ -186,7 +185,7 @@ namespace Microsoft.AspNetCore.DataProtection
certificateStore.Open(OpenFlags.ReadWrite); certificateStore.Open(OpenFlags.ReadWrite);
var certInStore = certificateStore.Certificates.Find(X509FindType.FindBySubjectName, "TestCert", false)[0]; var certInStore = certificateStore.Certificates.Find(X509FindType.FindBySubjectName, "TestCert", false)[0];
Assert.NotNull(certInStore); Assert.NotNull(certInStore);
Assert.False(certInStore.HasPrivateKey); Assert.False(certInStore.HasPrivateKey, "Cert should not have private key");
try try
{ {